Justin Freeman [Thu, 23 Jun 2022 05:05:08 +0000 (15:05 +1000)]
CIVICRM-2004 CiviCRM Personal Campaign Pages (PCP), incorrectly display "Don't list my contribution in the honor roll" even if the Contribution Honour Roll feature is not enabled or the user has opted out of the Honour Roll
Eileen McNaughton [Wed, 22 Jun 2022 21:42:42 +0000 (09:42 +1200)]
Merge pull request #23868 from civicrm/5.51
5.51 to master
Eileen McNaughton [Wed, 22 Jun 2022 21:38:29 +0000 (09:38 +1200)]
Merge pull request #23867 from demeritcowboy/currency551
dev/core#3680 - Currency incorrectly displayed for price set when default is not USD
demeritcowboy [Wed, 22 Jun 2022 13:34:12 +0000 (09:34 -0400)]
use the actual currency if there is one not the default
Eileen McNaughton [Wed, 22 Jun 2022 10:29:06 +0000 (22:29 +1200)]
Merge pull request #23866 from civicrm/5.51
5.51 to master
Eileen McNaughton [Wed, 22 Jun 2022 09:50:42 +0000 (21:50 +1200)]
Merge pull request #23865 from colemanw/behalf
dev/core#3675 Fix Permissioned Relationship pseudoconstant
Coleman Watts [Wed, 22 Jun 2022 08:05:40 +0000 (04:05 -0400)]
dev/core#3675 Fix Permissioned Relationship pseudoconstant
Fixes dev/core#3675 Permissioned Relationship no longer set up
for "On Behalf of Organization" Membership Contribution Form submissions
Eileen McNaughton [Wed, 22 Jun 2022 03:30:27 +0000 (15:30 +1200)]
Merge pull request #23860 from civicrm/5.51
5.51
Eileen McNaughton [Wed, 22 Jun 2022 01:45:48 +0000 (13:45 +1200)]
Merge pull request #23847 from eileenmcnaughton/sync
Attempt to make function more readable by extracting in-line function
Seamus Lee [Tue, 21 Jun 2022 23:58:10 +0000 (09:58 +1000)]
Merge pull request #23839 from eileenmcnaughton/import_outy
dev/core#3665 import summary fixes
Seamus Lee [Tue, 21 Jun 2022 23:27:32 +0000 (09:27 +1000)]
Merge pull request #23849 from eileenmcnaughton/import_55
dev/core#3673 do not attempt to import empty related contact
demeritcowboy [Tue, 21 Jun 2022 23:26:33 +0000 (19:26 -0400)]
Merge pull request #23855 from mlutfy/fixAccentsIcalAgain
dev/core#1541 Fix ICalendar random invalid utf8 (PHP <7.4 compat) and tests
Eileen McNaughton [Tue, 21 Jun 2022 23:08:41 +0000 (11:08 +1200)]
Merge pull request #23836 from stesi561/dev/core/#3671
Refs: dev/core#3671 Fix regression involving CiviCRM Webform + Cases.
Eileen McNaughton [Tue, 21 Jun 2022 00:58:07 +0000 (12:58 +1200)]
Attempt to make function more readable by extracting in-line function
Eileen McNaughton [Tue, 21 Jun 2022 22:59:55 +0000 (10:59 +1200)]
Merge pull request #23858 from seamuslee001/guzzle_658
[REF] Update Guzzle to be 6.5.8
demeritcowboy [Tue, 21 Jun 2022 22:46:58 +0000 (18:46 -0400)]
Merge pull request #23846 from seamuslee001/fix_warning_karma
[REF] Follow on from #23749 and remove refernece to ui-utils from kar…
Seamus Lee [Tue, 21 Jun 2022 21:37:50 +0000 (07:37 +1000)]
[REF] Update Guzzle to be 6.5.8
Mathieu Lu [Tue, 21 Jun 2022 19:53:00 +0000 (15:53 -0400)]
Merge pull request #23850 from demeritcowboy/rsspubdate
Alternate to 23826 - Events RSS feed does not output a pubDate for each Event
demeritcowboy [Tue, 21 Jun 2022 17:25:05 +0000 (13:25 -0400)]
Merge pull request #23853 from pradpnayak/updatecasefixes
Fixed fatal error on update multiple case
Mathieu Lutfy [Tue, 21 Jun 2022 13:54:05 +0000 (09:54 -0400)]
dev/core#1541 Fix ICalendar random invalid utf8 (PHP <7.4 compat) and tests
Pradeep Nayak [Tue, 21 Jun 2022 13:47:38 +0000 (14:47 +0100)]
Fixed fatal error on update multiple case
Eileen McNaughton [Tue, 21 Jun 2022 03:36:11 +0000 (15:36 +1200)]
dev/core#3673 do not attempt to report empty related contact
Yashodha Chaku [Tue, 21 Jun 2022 07:55:25 +0000 (13:25 +0530)]
Merge pull request #23834 from colemanw/deleteCustomOption
Call hooks when deleting an option value from CustomOption BAO
Yashodha Chaku [Tue, 21 Jun 2022 04:02:57 +0000 (09:32 +0530)]
Merge pull request #23840 from mlutfy/fixAccentsIcal
dev/core#1541 Fix ICalendar random invalid utf8
demeritcowboy [Tue, 21 Jun 2022 00:36:49 +0000 (20:36 -0400)]
CIVICRM-1998 CiviCRM Events RSS feed does not output a pubDate for each Event, use the Event Start Date as the pubDate which is generally how other Event systems use RSS
Eileen McNaughton [Tue, 21 Jun 2022 02:27:10 +0000 (14:27 +1200)]
Merge pull request #23822 from MegaphoneJon/3661-551
fixes core#3661: Don't check API permissions in CRM_Mailing_BAO_Mailing::getGroupNames()
Seamus Lee [Tue, 21 Jun 2022 00:57:17 +0000 (10:57 +1000)]
[REF] Follow on from #23749 and remove refernece to ui-utils from karama conf
Seamus Lee [Tue, 21 Jun 2022 00:20:37 +0000 (10:20 +1000)]
Merge pull request #23843 from seamuslee001/master
5.51
Seamus Lee [Tue, 21 Jun 2022 00:17:59 +0000 (10:17 +1000)]
Merge branch '5.51'
Seamus Lee [Tue, 21 Jun 2022 00:12:19 +0000 (10:12 +1000)]
Merge pull request #23842 from seamuslee001/regen_3658
[REF] dev/core#3658 Regenerate civicrm_generated to ensure that group…
Seamus Lee [Mon, 20 Jun 2022 22:22:23 +0000 (08:22 +1000)]
[REF] dev/core#3658 Regenerate civicrm_generated to ensure that grouping is added on installs
Eileen McNaughton [Mon, 20 Jun 2022 21:16:35 +0000 (09:16 +1200)]
Merge pull request #23841 from civicrm/5.51
5.51 to master
Eileen McNaughton [Mon, 20 Jun 2022 05:47:22 +0000 (17:47 +1200)]
Add related contacts to the group too, per prior version
Eileen McNaughton [Mon, 20 Jun 2022 05:27:49 +0000 (17:27 +1200)]
dev/core#3665 import summary fixes
m
Jon Goldberg [Thu, 16 Jun 2022 17:13:38 +0000 (13:13 -0400)]
fixes core#3661: Don't check API permissions in CRM_Mailing_BAO_Mailing::getGroupNames()
Mathieu Lutfy [Mon, 20 Jun 2022 15:35:18 +0000 (11:35 -0400)]
dev/core#1541 Fix ICalendar random invalid utf8
Mathieu Lu [Mon, 20 Jun 2022 15:33:36 +0000 (11:33 -0400)]
Merge pull request #23638 from jensschuppe/fix/iCalHtmlEntities
Decode HTML entities in iCalendar text
colemanw [Mon, 20 Jun 2022 14:10:03 +0000 (10:10 -0400)]
Merge pull request #23838 from eileenmcnaughton/import_out
Add view link to user job monitoring page
colemanw [Mon, 20 Jun 2022 14:06:31 +0000 (10:06 -0400)]
Merge pull request #23821 from eileenmcnaughton/import_long
dev/core#3662 increase length of import table status message
colemanw [Mon, 20 Jun 2022 14:01:06 +0000 (10:01 -0400)]
Merge pull request #23835 from eileenmcnaughton/related
dev/core#3667 fix failure to match existing contacts in skip mode
Eileen McNaughton [Mon, 20 Jun 2022 02:14:28 +0000 (14:14 +1200)]
Make monitoring page degrade gracefully if the import job is deleted
Eileen McNaughton [Mon, 20 Jun 2022 01:45:34 +0000 (13:45 +1200)]
Add view link to user job monitoring page
Eileen McNaughton [Mon, 20 Jun 2022 00:52:12 +0000 (12:52 +1200)]
Merge pull request #23837 from civicrm/5.51
5.51 to master
Eileen McNaughton [Mon, 20 Jun 2022 00:51:20 +0000 (12:51 +1200)]
Merge pull request #23823 from eileenmcnaughton/contact_test
dev/core#3663 fix output regression on csv output for import
Eileen McNaughton [Sun, 19 Jun 2022 23:41:14 +0000 (11:41 +1200)]
Merge pull request #23825 from colemanw/profileExport
APIv4 - Enable exporting profiles with custom fields
Eileen McNaughton [Sun, 19 Jun 2022 21:15:05 +0000 (09:15 +1200)]
Merge pull request #23818 from colemanw/afformDep
Afform - fix dependency injection for autogenerated forms
Eileen McNaughton [Sat, 18 Jun 2022 23:30:33 +0000 (11:30 +1200)]
dev/core#3667 fix failure to match existing contacts in skip mode
As reported by Andy C and verified by me 5.48 does create new related
contacts in skip mode
Luke Stewart [Sat, 18 Jun 2022 23:58:01 +0000 (11:58 +1200)]
Refs: dev/core#3671 Fix regression involving CiviCRM Webform + Cases.
Ignores permissions on api4 call in Recent::getTitle()
Eileen McNaughton [Fri, 17 Jun 2022 21:52:00 +0000 (09:52 +1200)]
Always throw exception in tests for pdf out
headers_sent() was always true before and hence the tests were written to expect the
exception would be called. Fixing that caused the tests to fail - but fixing it is good
Coleman Watts [Fri, 17 Jun 2022 23:28:00 +0000 (19:28 -0400)]
Call hooks when deleting an option value from CustomOption BAO
Fixes dev/core#3668
Eileen McNaughton [Fri, 17 Jun 2022 22:14:57 +0000 (10:14 +1200)]
Merge pull request #23832 from demeritcowboy/casedetails-static
dev/core#2983 - Make static function static - AJAX::caseDetails()
demeritcowboy [Fri, 17 Jun 2022 18:24:06 +0000 (14:24 -0400)]
make static function static
Coleman Watts [Fri, 17 Jun 2022 01:18:03 +0000 (21:18 -0400)]
APIv4 - Enable exporting profiles with custom fields
Before: Impossible to export a profile with custom fields as a managed entity because of the dependence on custom ids as the fieldname.
After: Uses APIv4-style names when exporting custom fields for profiles, which makes them portable.
demeritcowboy [Fri, 17 Jun 2022 16:13:42 +0000 (12:13 -0400)]
Merge pull request #23816 from eileenmcnaughton/inv_org
Fix double organization name in invoice, use token
Tim Otten [Fri, 17 Jun 2022 06:03:23 +0000 (23:03 -0700)]
Merge pull request #23827 from eileenmcnaughton/empty_date
Handle empty date token gracefully
Eileen McNaughton [Fri, 17 Jun 2022 04:15:51 +0000 (16:15 +1200)]
Handle empty date token gracefully
Eileen McNaughton [Fri, 17 Jun 2022 03:39:02 +0000 (15:39 +1200)]
Output to stdErr rather than echo
colemanw [Fri, 17 Jun 2022 03:08:35 +0000 (23:08 -0400)]
Merge pull request #23824 from totten/mixin-refresh
(dev/core#3660) Ensure that rebuildMenuAndCaches has current mixins+classloaders
Eileen McNaughton [Fri, 17 Jun 2022 00:11:12 +0000 (12:11 +1200)]
dev/core#3663 fix output regression on csv output
This fixes a very-recent rc regression whereby the file error output was
not correctly referring to the fields to be exported.
Note that in order to make it testable I had to
- remove header-setting that duplicates work done by the csv package
- remove extraneous echos in the GenCode
Tim Otten [Fri, 17 Jun 2022 00:00:48 +0000 (17:00 -0700)]
(dev/core#3660) Ensure that rebuildMenuAndCaches has current mixins+classloaders
Overview
--------
This fixes an issue in transitioning from `hook_managed` to `mixin/mgd-php@1`, wherein
managed-entities are briefly deleted (but later recreated).
Steps to Reproduce
------------------
1. (Web) Install an extension with a revision that uses `hook_managed`
2. (CLI) Switch the extension to a revision that uses `mixin/mgd-php@1`
3. (CLI) View contents of `civicrm_managed`
4. (Web) Run `civicrm/menu/rebuild`
5. (CLI) View contents of `civicrm_managed`
6. (Web) Run `civicrm/menu/rebuild`
7. (CLI) View contents of `civicrm_managed`
Before
------
While processing step 4 (`civicrm/menu/rebuild`), it fails to run the hooks for `mgd-php`.
Consequently, the list of managed-entities is lost and will disappear at step 5.
After
-----
While processing step 4 (`civicrm/menu/rebuild`), it activates the hooks for `mgd-php`.
Technical Details
------------------
When processing `civicrm/menu/rebuild`, there are a couple big substeps:
* `Civi\Core\Container::boot()` - During this process, it loads extensions. As usual,
this reads cached metadata, sets up classloaders, sets up mixins/hooks, etc.
* `CRM_Core_Invoke::rebuildMenuAndCaches()` - During this process, it clears
out caches and rebuilds several things (menus, managed-entities, etc).
The problem is this:
* The cache used during `boot()` has stale metadata (specifically,
`civicrm_cache` has old values of `mixinScan` and `mixinBoot`).
So it doesn't setup any new mixins/hooks.
* Then `rebuildMenuAndCaches()` depends on the mixins/hooks that are already setup.
While the function does clear persistent caches, it assumes that the
PHP runtime environment is up-to-spec. But it's not -- becuase our hooks
were based on the caches.
The patch uses the same `refresh()` mechanism as the extension-administration subsystem (which
has to reset the classloaders+mixins after enabling or disabling an extension).
Eileen McNaughton [Thu, 16 Jun 2022 22:11:16 +0000 (10:11 +1200)]
dev/core#3662 increase length of import table status message
This addresses https://lab.civicrm.org/dev/core/-/issues/3662 but
I think the underlying issue is that it has matched so many contacts, for
some reason, that the list of them is longer than 65,535 characters
so it is addressing a symptom, not the cause. 65,535 characters
feels like it should be long enough but changing to LONGTEXT
for a single field seems harmless so I'm a little on the
fence - but even if it just helps us debug....
Mathieu Lu [Thu, 16 Jun 2022 19:49:15 +0000 (15:49 -0400)]
Merge pull request #23807 from colemanw/fixAfformTitle
SearchKit - Only add filter values to Afform title if passed internally
Coleman Watts [Wed, 15 Jun 2022 21:49:51 +0000 (17:49 -0400)]
SearchKit - Only add filter values to Afform title if passed internally
This narrows the scope of contextual titles from #22319 to
only those filters passed internally, as used in drilldown forms.
It makes sense to exclude values from exposed filters because that
can lead to a confusing UI.
Coleman Watts [Thu, 16 Jun 2022 14:21:24 +0000 (10:21 -0400)]
Afform - fix dependency injection for autogenerated forms
demeritcowboy [Thu, 16 Jun 2022 13:54:33 +0000 (09:54 -0400)]
Merge pull request #23800 from seamuslee001/ref_date_filter
[REF] [PHP8.1] Replace usage of smarty's date_filter to ensure we don't call s…
colemanw [Thu, 16 Jun 2022 12:47:25 +0000 (08:47 -0400)]
Merge pull request #23419 from chrisgaraffa/contactheader-regions
Add crmRegions to contact headers and associated inline forms
Eileen McNaughton [Thu, 16 Jun 2022 10:59:11 +0000 (22:59 +1200)]
Merge pull request #23817 from civicrm/5.51
5.51 to master
Eileen McNaughton [Thu, 16 Jun 2022 10:47:47 +0000 (22:47 +1200)]
Merge pull request #23815 from seamuslee001/date_second_customformat
[REF] Fix second output in customFormat function and extend unit test
Eileen McNaughton [Thu, 16 Jun 2022 08:30:33 +0000 (20:30 +1200)]
Fix double organization name in invoice, use token
Seamus Lee [Thu, 16 Jun 2022 07:49:51 +0000 (17:49 +1000)]
[REF] Fix second output in customFormat function and extend unit test
Seamus Lee [Wed, 15 Jun 2022 03:20:20 +0000 (13:20 +1000)]
[REF] Replace usage of smarty's date_filter to ensure we don't call strftime which is deprecated in php8.1
Ensure start date format is the same
Seamus Lee [Thu, 16 Jun 2022 07:39:02 +0000 (17:39 +1000)]
Merge pull request #23806 from eileenmcnaughton/invoice_domain
Invoice Workflow template - add domain tokens
Tim Otten [Thu, 16 Jun 2022 05:56:12 +0000 (22:56 -0700)]
(NFC) Domain Tokens - Use consistent capitalization (title-case)
The current labels have mixed capitalization. Notwitstanding
one notable exception (`{action.*}`), most tokens use title-case.
So this patch applies title-case.
Eileen McNaughton [Thu, 16 Jun 2022 04:58:47 +0000 (16:58 +1200)]
Merge pull request #23697 from bsilvern/CRM-3495
dev/core#3495 - Fix fields with wildcards in Advanced Search
Eileen McNaughton [Thu, 16 Jun 2022 03:58:10 +0000 (15:58 +1200)]
Merge pull request #23813 from totten/master-tokproc-exc
(REF) TokenProcessor - Tweak error message
Eileen McNaughton [Thu, 16 Jun 2022 03:06:04 +0000 (15:06 +1200)]
Merge pull request #23811 from totten/master-wfmsg-dataprovider
(REF) WorkflowMessageTest - Use dataProvider
Eileen McNaughton [Thu, 16 Jun 2022 02:53:04 +0000 (14:53 +1200)]
Merge pull request #23810 from totten/5.51-msgadm-htmlraw
message_admin - Enable another preview mode ("HTML (Raw)")
Eileen McNaughton [Thu, 16 Jun 2022 02:45:39 +0000 (14:45 +1200)]
Merge pull request #23814 from civicrm/5.51
5.51 to master
Tim Otten [Wed, 15 Jun 2022 09:16:18 +0000 (02:16 -0700)]
TokenProcessor - Tweak error message
Tim Otten [Wed, 15 Jun 2022 08:12:28 +0000 (01:12 -0700)]
(REF) WorkflowMessageTest - Use dataProvider
Tim Otten [Thu, 16 Jun 2022 01:04:58 +0000 (18:04 -0700)]
message_admin - Enable another preview mode ("HTML (Raw)")
This is similar to the "HTML" preview, except it shows the raw HTML (with syntax highlighting).
Tim Otten [Thu, 16 Jun 2022 01:03:59 +0000 (18:03 -0700)]
Merge pull request #23801 from eileenmcnaughton/cont_work
Fix breakage in message preview on workflow contributions
Tim Otten [Thu, 16 Jun 2022 00:30:03 +0000 (17:30 -0700)]
Merge pull request #23768 from mlutfy/cloud17
dev/core#3542 Store extdir cache in sqlcache rather than the filesystem
Seamus Lee [Thu, 16 Jun 2022 00:20:11 +0000 (10:20 +1000)]
Merge pull request #23723 from mattwire/ufmatchsearchkit
Allow UFMatch to be used in SearchKit - this allows you to filter by eg. 'has a CMS account'
colemanw [Wed, 15 Jun 2022 22:21:34 +0000 (18:21 -0400)]
Merge pull request #23790 from mattwire/editcontributionlinkshook
Add hook to modify 'contribution payment links'
Coleman Watts [Wed, 15 Jun 2022 21:15:04 +0000 (17:15 -0400)]
Metadata - Add title for UfMatch entity
Eileen McNaughton [Wed, 15 Jun 2022 13:07:12 +0000 (01:07 +1200)]
Invoice Workflow template - add domain tokens
Matthew Wire [Tue, 14 Jun 2022 17:42:02 +0000 (18:42 +0100)]
Add hook to modify 'contribution payment links'
Monish Deb [Wed, 15 Jun 2022 14:43:43 +0000 (20:13 +0530)]
Merge pull request #23805 from mattwire/devfinancial197alt
dev/financial#197 Revert freezing on total_amount field on recurring form (alt to #23796)
Mathieu Lutfy [Sat, 11 Jun 2022 14:19:11 +0000 (10:19 -0400)]
dev/cloud-native#17 Store extdir cache in sqlcache rather than the filesystem
demeritcowboy [Wed, 15 Jun 2022 12:50:14 +0000 (08:50 -0400)]
Merge pull request #23799 from turrisxyz/Pinned-Dependencies-GitHub
chore: Set permissions for GitHub actions
Matthew Wire [Wed, 15 Jun 2022 11:21:39 +0000 (12:21 +0100)]
Revert freezing on total_amount field on recurring form
Monish Deb [Wed, 15 Jun 2022 11:19:47 +0000 (16:49 +0530)]
Merge pull request #23798 from seamuslee001/fix_auto_renew_membership
Fix Automatic renewal membership from front end contribution forms
Eileen McNaughton [Wed, 15 Jun 2022 03:44:52 +0000 (15:44 +1200)]
Fix breakage in message preview on workflow contributions
Eileen McNaughton [Wed, 15 Jun 2022 01:41:09 +0000 (13:41 +1200)]
Merge pull request #23797 from eileenmcnaughton/remove_field_types
[REF] Remove param that has a set value
nathannaveen [Wed, 15 Jun 2022 00:59:10 +0000 (00:59 +0000)]
chore: Set permissions for GitHub actions
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Seamus Lee [Tue, 14 Jun 2022 23:49:26 +0000 (09:49 +1000)]
[REF] Fix Automatic renewal membership from front end contribution forms
Properly fix regression and update unit tests to match what the form does
Seamus Lee [Tue, 14 Jun 2022 23:53:48 +0000 (09:53 +1000)]
Merge pull request #23774 from demeritcowboy/recur-curious
dev/financial#199 - Add failing test to demonstrate the problem
Eileen McNaughton [Tue, 14 Jun 2022 23:33:13 +0000 (11:33 +1200)]
[REF] Remove param that has a set value
Tim Otten [Tue, 14 Jun 2022 21:11:43 +0000 (14:11 -0700)]
Merge pull request #23785 from totten/5.51-hook-log
dev/core#3502 - CiviEventDispatcher - Softer errors for not-ready. More comments.