civicrm-core.git
5 years agoMerge pull request #13006 from seamuslee001/lab_core_472
colemanw [Mon, 29 Oct 2018 12:29:29 +0000 (08:29 -0400)]
Merge pull request #13006 from seamuslee001/lab_core_472

dev/core#472 Allow for APIv3 to find examples in Extenion folders as …

5 years agoMerge pull request #12586 from eileenmcnaughton/dao_in_export
Eileen McNaughton [Mon, 29 Oct 2018 11:41:16 +0000 (00:41 +1300)]
Merge pull request #12586 from eileenmcnaughton/dao_in_export

Export code cleanup: Convert relationships to pseudonames at the point of loading

5 years agoMerge pull request #13023 from eileenmcnaughton/mailing_settings
Eileen McNaughton [Mon, 29 Oct 2018 11:00:53 +0000 (00:00 +1300)]
Merge pull request #13023 from eileenmcnaughton/mailing_settings

Fix notices on mailing components screen, convert to metadata based

5 years agoCRM-14098 Membership reminders: don't exclude people who inherit other memberships...
Andrew Hunt [Mon, 29 Oct 2018 10:43:37 +0000 (06:43 -0400)]
CRM-14098 Membership reminders: don't exclude people who inherit other memberships (#12510)

* CRM-14098 Membership reminders: don't exclude people who inherit other memberships

* Membership reminders: test had two reminders with same name, differing params

* CRM-14098 Membership reminders: test for inherited members

----------------------------------------
* CRM-14098: Scheduled reminders silently skipped for contacts with a non-permissioned relationship associated with ANY inherited membership type
  https://issues.civicrm.org/jira/browse/CRM-14098

* Membership reminders: comments to document some shaky assumptions

* CRM-14098 Membership reminders: fix relies on joins, causing DB error on repeat

* CRM-14098 Membership reminders: missing alias on date field

* CRM-14098 Reminders test: explicitly make emails primary

5 years agoMerge pull request #12993 from eileenmcnaughton/strtolower_mailing
Seamus Lee [Mon, 29 Oct 2018 07:14:57 +0000 (18:14 +1100)]
Merge pull request #12993 from eileenmcnaughton/strtolower_mailing

Remove use of LOWER from mailing_name searches

5 years agoMerge pull request #12987 from eileenmcnaughton/strtolower_sort
Seamus Lee [Mon, 29 Oct 2018 07:13:53 +0000 (18:13 +1100)]
Merge pull request #12987 from eileenmcnaughton/strtolower_sort

Remove instances of LOWER casing searches from sort_name, display_name

5 years agoMerge pull request #12988 from eileenmcnaughton/strtolower_email
Seamus Lee [Mon, 29 Oct 2018 07:12:49 +0000 (18:12 +1100)]
Merge pull request #12988 from eileenmcnaughton/strtolower_email

Remove instances of LOWER casing searches from

5 years agoMerge pull request #12991 from eileenmcnaughton/strtolower_city
Seamus Lee [Mon, 29 Oct 2018 07:11:45 +0000 (18:11 +1100)]
Merge pull request #12991 from eileenmcnaughton/strtolower_city

Remove use of LOWER from city & street searches

5 years agoFix notices on mailing components screen, convert to metadata based
eileen [Mon, 29 Oct 2018 02:18:07 +0000 (15:18 +1300)]
Fix notices on mailing components screen, convert to metadata based

5 years agoMerge pull request #13022 from eileenmcnaughton/contribution_settings
Seamus Lee [Mon, 29 Oct 2018 07:06:42 +0000 (18:06 +1100)]
Merge pull request #13022 from eileenmcnaughton/contribution_settings

Fix Contribution settings form per dev/core/473

5 years agodev/core#472 Allow for APIv3 to find examples in Extenion folders as well as core
Seamus Lee [Wed, 24 Oct 2018 23:54:55 +0000 (10:54 +1100)]
dev/core#472 Allow for APIv3 to find examples in Extenion folders as well as core

Improve inclusion scanning by using get_include_path as suggested by Coleamn and alpha sort the list of entities

Deal with windows directory separators and more helpfully handle the trailing and non trailing slash directories

Further fixes for windows Directory Separators

5 years agoFix Contribution settings form per dev/core/473
eileen [Mon, 29 Oct 2018 00:29:09 +0000 (13:29 +1300)]
Fix Contribution settings form per dev/core/473

5 years agoMerge pull request #13021 from mattwire/caseactivity_array
colemanw [Sun, 28 Oct 2018 00:49:17 +0000 (20:49 -0400)]
Merge pull request #13021 from mattwire/caseactivity_array

Activities can be linked to multiple cases. Handle caseIds being an array

5 years agoActivities can be linked to multiple cases. Handle caseIds being an array
Matthew Wire (MJW Consulting) [Sat, 27 Oct 2018 20:01:55 +0000 (21:01 +0100)]
Activities can be linked to multiple cases. Handle caseIds being an array

5 years agoFix double handling of fields with unique names.
eileen [Thu, 25 Oct 2018 11:34:43 +0000 (00:34 +1300)]
Fix double handling of fields with unique names.

The relationship array is being built with 'names' & the main array with 'unique names' which later need to be wrangled back into sync. Do relationships the same as main array

5 years agoMerge pull request #13017 from yashodha/dev-479
Eileen McNaughton [Sat, 27 Oct 2018 02:58:23 +0000 (15:58 +1300)]
Merge pull request #13017 from yashodha/dev-479

(dev/core#479) Contribution Summary report throw DB error with custom…

5 years agoConvert relationships to pseudonames at the point of loading
eileen [Sat, 28 Jul 2018 04:38:28 +0000 (16:38 +1200)]
Convert relationships to pseudonames at the point of loading

5 years agoMerge pull request #12736 from calbasi/master
Eileen McNaughton [Sat, 27 Oct 2018 02:44:29 +0000 (15:44 +1300)]
Merge pull request #12736 from calbasi/master

Style improvement of radio form elements

5 years agoMerge pull request #13008 from eileenmcnaughton/activity_src
Seamus Lee [Fri, 26 Oct 2018 22:50:57 +0000 (09:50 +1100)]
Merge pull request #13008 from eileenmcnaughton/activity_src

Fix Activity api to cope with renamed record type labels (e.g renaming 'Target' to 'Directed At')

5 years agoMerge pull request #13010 from jitendrapurohit/core-474
Seamus Lee [Fri, 26 Oct 2018 20:31:54 +0000 (07:31 +1100)]
Merge pull request #13010 from jitendrapurohit/core-474

dev/core#474 - Show missing log table warning only if logging is enabled

5 years ago(dev/core#479) Contribution Summary report throw DB error with custom data and soft...
yashodha [Fri, 26 Oct 2018 06:18:35 +0000 (11:48 +0530)]
(dev/core#479) Contribution Summary report throw DB error with custom data and soft credit fields

5 years agodev/core#474 - Show missing log table warning only if logging is enabled
Jitendra Purohit [Thu, 25 Oct 2018 11:20:02 +0000 (16:50 +0530)]
dev/core#474 - Show missing log table warning only if logging is enabled

5 years agoMerge pull request #12971 from mattwire/entityfields_metadatadescription
Eileen McNaughton [Thu, 25 Oct 2018 21:30:38 +0000 (10:30 +1300)]
Merge pull request #12971 from mattwire/entityfields_metadatadescription

Use description from schema if available when using entityForm

5 years agoMerge pull request #13005 from eileenmcnaughton/dao_desc_ts
colemanw [Thu, 25 Oct 2018 21:28:30 +0000 (17:28 -0400)]
Merge pull request #13005 from eileenmcnaughton/dao_desc_ts

Translate description in DAO files

5 years agoMerge pull request #13003 from agh1/obsoleteIcons
colemanw [Thu, 25 Oct 2018 21:20:27 +0000 (17:20 -0400)]
Merge pull request #13003 from agh1/obsoleteIcons

Replace translation and calendar image icons

5 years agoMerge pull request #12979 from mattwire/datepicker_eventparticipant_register
Seamus Lee [Thu, 25 Oct 2018 20:30:49 +0000 (07:30 +1100)]
Merge pull request #12979 from mattwire/datepicker_eventparticipant_register

Convert Event Participant Registration Date to datepicker

5 years agoMerge pull request #12957 from scardinius/core-457
colemanw [Thu, 25 Oct 2018 16:20:48 +0000 (12:20 -0400)]
Merge pull request #12957 from scardinius/core-457

[dev/core#457] Add $ids to hook_civicrm_export

5 years agoDatepicker: explain the unicode hex for the calendar icon
Andrew Hunt [Thu, 25 Oct 2018 13:14:16 +0000 (09:14 -0400)]
Datepicker: explain the unicode hex for the calendar icon

Also remove a comment that belonged to CSS that was previously removed

5 years ago[dev/core#457] Add $ids to hook_civicrm_export
scardinius [Thu, 2 Aug 2018 12:09:41 +0000 (14:09 +0200)]
[dev/core#457] Add $ids to hook_civicrm_export

5 years agoMerge pull request #12615 from eileenmcnaughton/amex
Eileen McNaughton [Thu, 25 Oct 2018 09:15:34 +0000 (22:15 +1300)]
Merge pull request #12615 from eileenmcnaughton/amex

CRM-21311 fix handling of credit cards where Amex has been given a different label

5 years agoMerge pull request #13009 from seamuslee001/nfc_comment_fix
Seamus Lee [Thu, 25 Oct 2018 06:57:24 +0000 (17:57 +1100)]
Merge pull request #13009 from seamuslee001/nfc_comment_fix

(NFC) Fix comment as hook name was changed

5 years agoMerge pull request #12687 from seamuslee001/get_phone_improvement
Seamus Lee [Thu, 25 Oct 2018 06:57:01 +0000 (17:57 +1100)]
Merge pull request #12687 from seamuslee001/get_phone_improvement

Improve type checking in getContactPhone and use CRM_Utils_Request::r…

5 years agoImprove type checking in getContactPhone and use CRM_Utils_Request::retrieve to get...
Seamus Lee [Sun, 19 Aug 2018 01:03:24 +0000 (11:03 +1000)]
Improve type checking in getContactPhone and use CRM_Utils_Request::retrieve to get data from GET

Fix retrieving value from GET param as per review by Eileen

Replace inserted variables with placeholders as per standards

5 years agoMerge pull request #12711 from agileware/CIVICRM-965
Eileen McNaughton [Thu, 25 Oct 2018 03:57:14 +0000 (16:57 +1300)]
Merge pull request #12711 from agileware/CIVICRM-965

Added relationship active filter in CiviCRM Case reports.

5 years agoMerge pull request #13007 from seamuslee001/nfc_doc_trait_namespace
Eileen McNaughton [Thu, 25 Oct 2018 03:56:24 +0000 (16:56 +1300)]
Merge pull request #13007 from seamuslee001/nfc_doc_trait_namespace

(NFC) Fix Namespace issue in Api3DocTrait when calling smarty

5 years ago(NFC) Fix comment as hook name was changed
Seamus Lee [Thu, 25 Oct 2018 01:00:45 +0000 (12:00 +1100)]
(NFC) Fix comment as hook name was changed

5 years agoMerge pull request #12928 from seamuslee001/dev_financial_33
Eileen McNaughton [Thu, 25 Oct 2018 00:12:53 +0000 (13:12 +1300)]
Merge pull request #12928 from seamuslee001/dev_financial_33

dev/financial#33 Add in Hook postIPNProcess to allow Extensions to do c…

5 years agoFix Activity api to cope with renamed record type ids.
eileen [Thu, 25 Oct 2018 00:05:09 +0000 (13:05 +1300)]
Fix Activity api to cope with renamed record type ids.

Filter activities based on the name of activity contacts options instead of option label

5 years agoFix Namespace issue in Api3DocTrait when calling smarty
Seamus Lee [Thu, 25 Oct 2018 00:04:48 +0000 (11:04 +1100)]
Fix Namespace issue in Api3DocTrait when calling smarty

5 years agoTranslate description in DAO files
eileen [Wed, 24 Oct 2018 22:34:34 +0000 (11:34 +1300)]
Translate description in DAO files

This relates to the attempt here https://github.com/civicrm/civicrm-core/pull/12971
to use description directly in the Entity Forms & questions as to whether it is translated.

Currently they are not but there seems like no downside in translating them

5 years agoMerge pull request #12930 from jackrabbithanna/core-dev-436
Eileen McNaughton [Wed, 24 Oct 2018 22:17:24 +0000 (11:17 +1300)]
Merge pull request #12930 from jackrabbithanna/core-dev-436

do not strtolower() string values while building where clause for cus…

5 years agoMerge pull request #12982 from jitendrapurohit/core-461
Seamus Lee [Wed, 24 Oct 2018 20:24:01 +0000 (07:24 +1100)]
Merge pull request #12982 from jitendrapurohit/core-461

dev/core#461 - Duplicate Message template is generated when it is sav…

5 years agoReplace calendar GIF icon with placeholder font icon
Andrew Hunt [Wed, 24 Oct 2018 20:10:33 +0000 (16:10 -0400)]
Replace calendar GIF icon with placeholder font icon

5 years agoReplace squares with translation icon
Andrew Hunt [Wed, 24 Oct 2018 19:43:48 +0000 (15:43 -0400)]
Replace squares with translation icon

5 years agoMerge pull request #12925 from eileenmcnaughton/setting
Eileen McNaughton [Wed, 24 Oct 2018 19:30:12 +0000 (08:30 +1300)]
Merge pull request #12925 from eileenmcnaughton/setting

Setting conversion

5 years agoMerge pull request #12999 from mlutfy/translation15
Eileen McNaughton [Wed, 24 Oct 2018 19:28:53 +0000 (08:28 +1300)]
Merge pull request #12999 from mlutfy/translation15

dev/translation#15 Fix backend CC contributions left pending if statuses are localised

5 years agoMerge pull request #13002 from civicrm/5.7
Eileen McNaughton [Wed, 24 Oct 2018 19:25:12 +0000 (08:25 +1300)]
Merge pull request #13002 from civicrm/5.7

5.7 to master

5 years agoMerge pull request #12997 from eileenmcnaughton/5.7
colemanw [Wed, 24 Oct 2018 13:56:03 +0000 (09:56 -0400)]
Merge pull request #12997 from eileenmcnaughton/5.7

Fix default for repetition_start_date

5 years agodev/translation#15 Fix backend CC contributions left pending if statuses are localised
Mathieu Lutfy [Wed, 24 Oct 2018 12:22:45 +0000 (08:22 -0400)]
dev/translation#15 Fix backend CC contributions left pending if statuses are localised

5 years agoFix default for repetition_start_date
eileen [Wed, 24 Oct 2018 04:25:40 +0000 (17:25 +1300)]
Fix default for repetition_start_date

5 years agoMerge pull request #12974 from mattwire/recurringentity_dateformat
Eileen McNaughton [Wed, 24 Oct 2018 04:06:02 +0000 (17:06 +1300)]
Merge pull request #12974 from mattwire/recurringentity_dateformat

Don't format date twice for RecurringEntity form

5 years agoMerge pull request #12992 from mattwire/datepicker_eventfees
Eileen McNaughton [Wed, 24 Oct 2018 03:46:52 +0000 (16:46 +1300)]
Merge pull request #12992 from mattwire/datepicker_eventfees

Convert EventFees to datepicker

5 years agoMerge pull request #12994 from eileenmcnaughton/activity_extract
Seamus Lee [Wed, 24 Oct 2018 02:47:38 +0000 (13:47 +1100)]
Merge pull request #12994 from eileenmcnaughton/activity_extract

[NFC] Extract function to get component permissions

5 years agoExtract function to get component permissions
eileen [Thu, 18 Oct 2018 04:44:08 +0000 (17:44 +1300)]
Extract function to get component permissions

5 years agoRemove use of LOWER from mailing_name searches
eileen [Tue, 23 Oct 2018 23:58:21 +0000 (12:58 +1300)]
Remove use of LOWER from mailing_name searches

This is already covered by the tess in CRM_Mailing_BAO_QueryTest::testSearch

The main risk with these things is removing php strtolower
& not mysql LOWER (the reverse still works). Here they are
close together

5 years agoRemove use of LOWER from city & street searches
eileen [Tue, 23 Oct 2018 19:54:54 +0000 (08:54 +1300)]
Remove use of LOWER from city & street searches

Adding LOWER to mysql queries makes them slower. lowercasing php strings
breaks under some character sets with some server configs.

5 years agoConvert EventFees to datepicker
Matthew Wire (MJW Consulting) [Fri, 19 Oct 2018 15:25:52 +0000 (16:25 +0100)]
Convert EventFees to datepicker

5 years agoConvert register_date to datepicker
Matthew Wire (MJW Consulting) [Fri, 19 Oct 2018 18:11:08 +0000 (19:11 +0100)]
Convert register_date to datepicker

5 years agodo not strtolower() string values while building where clause for custom field queries
Mark Hanna [Fri, 12 Oct 2018 15:21:42 +0000 (10:21 -0500)]
do not strtolower() string values while building where clause for custom field queries

remove empty row

test updates for dev issue 436

fixes for test updates for dev issue 436

fixes for test updates for dev issue 436

another fix for new multi-valued custom field test additions

another fix for new multi-valued custom field test additions

fix to testCustomDataGet to remove false positive

add exception for note entity in testCustomDataGet

5 years agoMerge pull request #12949 from eileenmcnaughton/activity_extract
colemanw [Tue, 23 Oct 2018 20:31:47 +0000 (16:31 -0400)]
Merge pull request #12949 from eileenmcnaughton/activity_extract

[NFC] Extract case activity permission check.

5 years agoMerge pull request #12989 from colemanw/ts
Tim Otten [Tue, 23 Oct 2018 19:53:35 +0000 (12:53 -0700)]
Merge pull request #12989 from colemanw/ts

Add ts to untranslated string

5 years agoAdd ts to untranslated string
Coleman Watts [Tue, 23 Oct 2018 17:19:18 +0000 (13:19 -0400)]
Add ts to untranslated string

5 years agoRemove strtolower as applied to email, test
eileen [Tue, 23 Oct 2018 06:06:00 +0000 (19:06 +1300)]
Remove strtolower as applied to email, test

5 years agoRemove instances of LOWERE casing searches from sort_name, display_name.
eileen [Tue, 23 Oct 2018 05:54:45 +0000 (18:54 +1300)]
Remove instances of LOWERE casing searches from sort_name, display_name.

Per https://github.com/civicrm/civicrm-core/pull/12494 mysql handles lcase.

Adding LOWER to mysql queries makes them slower. lowercasing php strings
breaks under some character sets with some server configs. Less is more

5 years agoMerge pull request #12977 from mattwire/datepicker_manageevent_fees
Eileen McNaughton [Tue, 23 Oct 2018 02:44:58 +0000 (15:44 +1300)]
Merge pull request #12977 from mattwire/datepicker_manageevent_fees

Convert ManageEvent Fees to datepicker

5 years agoMerge pull request #12985 from civicrm/5.7
Eileen McNaughton [Mon, 22 Oct 2018 23:34:14 +0000 (12:34 +1300)]
Merge pull request #12985 from civicrm/5.7

5.7 to master

5 years agoMerge pull request #12984 from mlutfy/5.7-core462
Eileen McNaughton [Mon, 22 Oct 2018 23:33:37 +0000 (12:33 +1300)]
Merge pull request #12984 from mlutfy/5.7-core462

dev/core#462 Exclude tmp tables from Advanced Logging missing table check

5 years agodev/core#462 Exclude tmp tables from Advanced Logging missing table check.
Mathieu Lutfy [Mon, 22 Oct 2018 19:26:27 +0000 (15:26 -0400)]
dev/core#462 Exclude tmp tables from Advanced Logging missing table check.

5 years agoMerge pull request #12956 from vingle/patch-3
Seamus Lee [Mon, 22 Oct 2018 19:59:42 +0000 (06:59 +1100)]
Merge pull request #12956 from vingle/patch-3

Joomla admin theme menu, empty blocks & padding clean-up

5 years agodev/core#461 - Duplicate Message template is generated when it is saved through sched...
Jitendra Purohit [Mon, 22 Oct 2018 09:29:47 +0000 (14:59 +0530)]
dev/core#461 - Duplicate Message template is generated when it is saved through schedule reminder form

5 years agoConvert user dashboard options
eileen [Thu, 11 Oct 2018 15:00:06 +0000 (16:00 +0100)]
Convert user dashboard options

5 years agoConvert a couple more settings fields.
eileen [Thu, 11 Oct 2018 14:47:58 +0000 (15:47 +0100)]
Convert a couple more settings fields.

These are the 2 textarea fields at the end of the display form - sort format & display format.

The text boxes are too small on page load - but this is unchanged IMHO

5 years agoConvert ManageEvent Fees to datepicker
Matthew Wire (MJW Consulting) [Fri, 19 Oct 2018 20:21:59 +0000 (21:21 +0100)]
Convert ManageEvent Fees to datepicker

5 years agoUse description from schema if available when using entityForm
Matthew Wire (MJW Consulting) [Fri, 19 Oct 2018 14:36:44 +0000 (15:36 +0100)]
Use description from schema if available when using entityForm

5 years agoMerge pull request #12975 from mattwire/datepicker_manageevent_registration
Seamus Lee [Sun, 21 Oct 2018 00:51:08 +0000 (11:51 +1100)]
Merge pull request #12975 from mattwire/datepicker_manageevent_registration

Convert ManageEvent Registration Tab to datepicker

5 years agoMerge pull request #12976 from civicrm/5.7
Eileen McNaughton [Sat, 20 Oct 2018 22:08:21 +0000 (11:08 +1300)]
Merge pull request #12976 from civicrm/5.7

5.7 to master

5 years agoMerge pull request #12972 from mattwire/datepicker_relationshipform
Eileen McNaughton [Sat, 20 Oct 2018 22:01:08 +0000 (11:01 +1300)]
Merge pull request #12972 from mattwire/datepicker_relationshipform

Convert relationship form to datepicker

5 years agoMerge pull request #12941 from colemanw/summaryTabs57
Eileen McNaughton [Sat, 20 Oct 2018 21:52:58 +0000 (10:52 +1300)]
Merge pull request #12941 from colemanw/summaryTabs57

Cleanup contact summary tabs code

5 years agoConvert ManageEvent Registration to datepicker
Matthew Wire (MJW Consulting) [Fri, 19 Oct 2018 20:29:48 +0000 (21:29 +0100)]
Convert ManageEvent Registration to datepicker

5 years agoDon't format date twice for RecurringEntity form
Matthew Wire (MJW Consulting) [Wed, 5 Sep 2018 11:13:49 +0000 (12:13 +0100)]
Don't format date twice for RecurringEntity form

5 years agoMerge pull request #12960 from eileenmcnaughton/member_settings
Eileen McNaughton [Sat, 20 Oct 2018 20:51:08 +0000 (09:51 +1300)]
Merge pull request #12960 from eileenmcnaughton/member_settings

Fix notices on Membership Settings form.

5 years agoMerge pull request #12958 from pradpnayak/Tags
colemanw [Sat, 20 Oct 2018 15:16:39 +0000 (11:16 -0400)]
Merge pull request #12958 from pradpnayak/Tags

Remove contact tags when none selected on edit screen

5 years agoRemove contact tags when none selected on edit screen
Pradeep Nayak [Thu, 18 Oct 2018 14:38:01 +0000 (15:38 +0100)]
Remove contact tags when none selected on edit screen

5 years agoConvert relationship form to datepicker
Matthew Wire (MJW Consulting) [Fri, 19 Oct 2018 15:07:44 +0000 (16:07 +0100)]
Convert relationship form to datepicker

5 years agoMerge pull request #12968 from christianwach/issue-459
Tim Otten [Fri, 19 Oct 2018 18:13:47 +0000 (11:13 -0700)]
Merge pull request #12968 from christianwach/issue-459

Fix "crmURL" parameters in various templates

5 years agoMerge pull request #12959 from totten/master-theme-lite
Tim Otten [Fri, 19 Oct 2018 17:47:57 +0000 (10:47 -0700)]
Merge pull request #12959 from totten/master-theme-lite

CRM_Core_Resources - Allow container to swap the implementation

5 years agoMerge pull request #12967 from eileenmcnaughton/report57
Tim Otten [Fri, 19 Oct 2018 17:13:34 +0000 (10:13 -0700)]
Merge pull request #12967 from eileenmcnaughton/report57

Contact summary report with location type selected :Fixed fatal error for function not found

5 years agoMerge pull request #12962 from seamuslee001/dev_core_448_57
Tim Otten [Fri, 19 Oct 2018 17:11:26 +0000 (10:11 -0700)]
Merge pull request #12962 from seamuslee001/dev_core_448_57

dev/core#448 Fix issue where when building mailings with smart groups, removed members of the smart group were being included

5 years agoFix "crmURL" parameters in various templates
Christian Wach [Fri, 19 Oct 2018 13:21:02 +0000 (14:21 +0100)]
Fix "crmURL" parameters in various templates

5 years agoMerge pull request #12966 from seamuslee001/activity_report_group_fgb
Eileen McNaughton [Fri, 19 Oct 2018 02:04:19 +0000 (15:04 +1300)]
Merge pull request #12966 from seamuslee001/activity_report_group_fgb

Disable ONLY_FULL_GROUP_BY sql mode when doing add2group function on …

5 years agoMerge pull request #12964 from civicrm/5.7
Eileen McNaughton [Fri, 19 Oct 2018 00:22:47 +0000 (13:22 +1300)]
Merge pull request #12964 from civicrm/5.7

5.7 to master

5 years agoMerge pull request #12963 from eileenmcnaughton/activity57
Eileen McNaughton [Fri, 19 Oct 2018 00:19:42 +0000 (13:19 +1300)]
Merge pull request #12963 from eileenmcnaughton/activity57

Fix regression on activity detail report add to group

5 years agoFixed fatal error for function not found
Pradeep Nayak [Thu, 18 Oct 2018 09:23:00 +0000 (10:23 +0100)]
Fixed fatal error for function not found

5 years agoDisable ONLY_FULL_GROUP_BY sql mode when doing add2group function on the Activity...
Seamus Lee [Thu, 18 Oct 2018 21:28:00 +0000 (08:28 +1100)]
Disable ONLY_FULL_GROUP_BY sql mode when doing add2group function on the Activity Detail report to avoid fatal error

5 years agoMerge pull request #12961 from seamuslee001/concurrency_oronery
Eileen McNaughton [Thu, 18 Oct 2018 20:58:08 +0000 (09:58 +1300)]
Merge pull request #12961 from seamuslee001/concurrency_oronery

(NFC) Make the test concurrency test not run on PR testing but on mat…

5 years agoFix regression on activity detail report add to group
eileen [Thu, 18 Oct 2018 20:57:47 +0000 (09:57 +1300)]
Fix regression on activity detail report add to group

5 years agosmart groups as mailing lists were not taking unsubscribed users into account
Thomas [Tue, 16 Oct 2018 16:20:58 +0000 (12:20 -0400)]
smart groups as mailing lists were not taking unsubscribed users into account

dev/core#448 Add in a Unit test to demonstrate the problem with smart groups and contats removed from smart groups not being properly checked

5 years ago(NFC) Make the test concurrency test not run on PR testing but on matrix alone until...
Seamus Lee [Thu, 18 Oct 2018 20:43:04 +0000 (07:43 +1100)]
(NFC) Make the test concurrency test not run on PR testing but on matrix alone until we can sort out the issue

5 years agodev/financial#33 Add in Hook alterIPNData to allow Extensions to do custom processing...
Seamus Lee [Fri, 12 Oct 2018 00:25:47 +0000 (11:25 +1100)]
dev/financial#33 Add in Hook alterIPNData to allow Extensions to do custom processing of the IPN Data

Add in unit test of alterIPNData hook and ensure that it is called in all styles of IPN Notifications

Shift hook call to be done in handlePaymentMethod function as per Eileen's comment and remove the hook from deprecated pathways and passbyrefeence in hook

Change name to be postIPNProcess to be more explicit about the purpose of the hook

5 years agoFix notics on Membership Settings form.
eileen [Thu, 18 Oct 2018 19:59:33 +0000 (08:59 +1300)]
Fix notics on Membership Settings form.

Membership settings form has some enotices off the back of work on the
display form. This fixes those & makes it a 'pure' form in that it relies fully on the
metadata