civicrm-core.git
12 months agoNotice fix on payment block
Eileen McNaughton [Sat, 18 Nov 2023 04:17:09 +0000 (17:17 +1300)]
Notice fix on payment block

We don't need to check if we are dealing with a multiple participant event because that
is the only scenario where the field additional_participants is present
& it will fail gracefully if it is not present. This has been causing notices across
all flows that include the payment block

12 months agoMerge pull request #28174 from eileenmcnaughton/mem_online_2
Eileen McNaughton [Sat, 18 Nov 2023 03:35:14 +0000 (16:35 +1300)]
Merge pull request #28174 from eileenmcnaughton/mem_online_2

Fix membership online preview to display subject (using token)

12 months agoUpdate CRM/Member/WorkflowMessage/Membership/Membership.php
Eileen McNaughton [Fri, 17 Nov 2023 23:16:18 +0000 (12:16 +1300)]
Update CRM/Member/WorkflowMessage/Membership/Membership.php

Co-authored-by: colemanw <coleman@civicrm.org>
12 months agoMerge pull request #28169 from demeritcowboy/l10ndir-check
Tim Otten [Fri, 17 Nov 2023 22:33:16 +0000 (15:33 -0700)]
Merge pull request #28169 from demeritcowboy/l10ndir-check

System check for multiple l10n dirs

12 months agosystem check for multiple l10n dirs
demeritcowboy [Thu, 16 Nov 2023 19:02:24 +0000 (14:02 -0500)]
system check for multiple l10n dirs

12 months agoMerge pull request #28193 from civicrm/5.68
Eileen McNaughton [Fri, 17 Nov 2023 20:40:37 +0000 (09:40 +1300)]
Merge pull request #28193 from civicrm/5.68

5.68

12 months agoMerge pull request #28192 from lcdservices/civicrm-core-4780b
Eileen McNaughton [Fri, 17 Nov 2023 20:39:30 +0000 (09:39 +1300)]
Merge pull request #28192 from lcdservices/civicrm-core-4780b

dev/core#4780 handle bounce processing when verp unverified

12 months agoMerge pull request #28187 from colemanw/groupConcatUiFix
demeritcowboy [Fri, 17 Nov 2023 19:57:20 +0000 (14:57 -0500)]
Merge pull request #28187 from colemanw/groupConcatUiFix

SearchKit - Fix missing label on group concat distinct dropdown

12 months agotrying again to fix conflict
demeritcowboy [Fri, 17 Nov 2023 19:27:21 +0000 (14:27 -0500)]
trying again to fix conflict

12 months agotry to fix merge conflict
demeritcowboy [Fri, 17 Nov 2023 19:25:56 +0000 (14:25 -0500)]
try to fix merge conflict

12 months agoMerge pull request #28164 from colemanw/groupFirst
Aidan Saunders [Fri, 17 Nov 2023 18:58:01 +0000 (18:58 +0000)]
Merge pull request #28164 from colemanw/groupFirst

APIv4 - Add GROUP_FIRST aggregate function

12 months agoMerge pull request #28189 from aydun/adminui_cp_fix_rc
demeritcowboy [Fri, 17 Nov 2023 18:37:17 +0000 (13:37 -0500)]
Merge pull request #28189 from aydun/adminui_cp_fix_rc

dev/core#4783 Fix ability to clone and delete Contribution Pages when AdminUI enabled

12 months agodev/core#4780 handle bounce processing when verp unverified
Brian Shaughnessy [Fri, 17 Nov 2023 18:23:38 +0000 (13:23 -0500)]
dev/core#4780 handle bounce processing when verp unverified

12 months agoMove civicrm/contribute/manage to civicrm/admin/contribute/manage
Aidan Saunders [Thu, 16 Nov 2023 21:46:41 +0000 (21:46 +0000)]
Move civicrm/contribute/manage to civicrm/admin/contribute/manage
Update one reference to old path
Change Contribution Page clone and delete to use new path

12 months agoSearchKit - Fix wrong flags shown when switching field functions
colemanw [Fri, 17 Nov 2023 14:04:37 +0000 (09:04 -0500)]
SearchKit - Fix wrong flags shown when switching field functions

12 months agoSearchKit - Support ORDER BY with aggregate functions
colemanw [Fri, 17 Nov 2023 01:15:59 +0000 (20:15 -0500)]
SearchKit - Support ORDER BY with aggregate functions

12 months agoAPIv4 - Add GROUP_FIRST aggregate function
colemanw [Thu, 16 Nov 2023 01:12:18 +0000 (20:12 -0500)]
APIv4 - Add GROUP_FIRST aggregate function

This fills a gap in the MySql spec. It returns the first result of a GROUP_CONCAT set.

12 months agoSearchKit - Fix missing label on group concat distinct dropdown
colemanw [Fri, 17 Nov 2023 14:17:39 +0000 (09:17 -0500)]
SearchKit - Fix missing label on group concat distinct dropdown

12 months agoMerge pull request #28171 from eileenmcnaughton/568_tax
colemanw [Fri, 17 Nov 2023 13:33:00 +0000 (08:33 -0500)]
Merge pull request #28171 from eileenmcnaughton/568_tax

Fix tax total not showing on thank you

12 months agoMerge pull request #28180 from eileenmcnaughton/notice_n
Seamus Lee [Fri, 17 Nov 2023 07:43:58 +0000 (18:43 +1100)]
Merge pull request #28180 from eileenmcnaughton/notice_n

Reverse variable check to fix notice

12 months agoReverse variable check to fix notice
Eileen McNaughton [Fri, 17 Nov 2023 03:19:04 +0000 (16:19 +1300)]
Reverse variable check to fix notice

12 months agoMerge pull request #28165 from colemanw/mockTestMove
colemanw [Fri, 17 Nov 2023 02:55:22 +0000 (21:55 -0500)]
Merge pull request #28165 from colemanw/mockTestMove

[REF] Afform - Namespace mock tests for autoloading

12 months agoMerge pull request #28179 from totten/master-langs
colemanw [Fri, 17 Nov 2023 02:53:50 +0000 (21:53 -0500)]
Merge pull request #28179 from totten/master-langs

setup/res/languages.php - Always generate style-compliant code

12 months agoMerge pull request #28177 from eileenmcnaughton/mem_online_white
Tim Otten [Fri, 17 Nov 2023 01:51:56 +0000 (18:51 -0700)]
Merge pull request #28177 from eileenmcnaughton/mem_online_white

Reformat whitespace in online membership receipt

12 months agoRegenerate `languages.php` and `langs.php`
Tim Otten [Fri, 17 Nov 2023 01:47:30 +0000 (17:47 -0800)]
Regenerate `languages.php` and `langs.php`

12 months agoGenCode - When generating 'setup/res/languages.php', it should be pass linter
Tim Otten [Fri, 17 Nov 2023 01:30:16 +0000 (17:30 -0800)]
GenCode - When generating 'setup/res/languages.php', it should be pass linter

12 months agoFix tests to not notice when faking form flow
Eileen McNaughton [Thu, 16 Nov 2023 22:59:01 +0000 (11:59 +1300)]
Fix tests to not notice when faking form flow

12 months agoReformat whitespace in online membership receipt
Eileen McNaughton [Fri, 17 Nov 2023 00:19:21 +0000 (13:19 +1300)]
Reformat whitespace in online membership receipt

12 months agoMerge pull request #28172 from eileenmcnaughton/mem_online
Seamus Lee [Fri, 17 Nov 2023 00:43:41 +0000 (11:43 +1100)]
Merge pull request #28172 from eileenmcnaughton/mem_online

Fix setting of misnamed property

12 months agoAfform - Namespace mock tests for autoloading
colemanw [Thu, 16 Nov 2023 02:23:01 +0000 (21:23 -0500)]
Afform - Namespace mock tests for autoloading

12 months agoFix tax total not showing on thank you
Eileen McNaughton [Thu, 16 Nov 2023 20:53:38 +0000 (09:53 +1300)]
Fix tax total not showing on thank you

12 months agoFix membership online preview to display subject (using token)
Eileen McNaughton [Thu, 16 Nov 2023 22:13:55 +0000 (11:13 +1300)]
Fix membership online preview to display subject (using token)

12 months agoMerge pull request #28170 from totten/5.68-mixin-since
Eileen McNaughton [Thu, 16 Nov 2023 23:02:02 +0000 (12:02 +1300)]
Merge pull request #28170 from totten/5.68-mixin-since

(NFC) setting-admin@1 - Fix the `@since` metadata

12 months agoMerge pull request #28173 from mattwire/contnewtab
Aidan Saunders [Thu, 16 Nov 2023 22:26:46 +0000 (22:26 +0000)]
Merge pull request #28173 from mattwire/contnewtab

Manage Contribution Pages: Open Live/Test page in new tab like old screen

12 months agoManage Contribution Pages: Open Live/Test page in new tab like old screen
Matthew Wire [Thu, 16 Nov 2023 21:04:46 +0000 (21:04 +0000)]
Manage Contribution Pages: Open Live/Test page in new tab like old screen

12 months agoFix setting of misnamed property
Eileen McNaughton [Thu, 16 Nov 2023 20:45:10 +0000 (09:45 +1300)]
Fix setting of misnamed property

The property is ID, not id

12 months agosetting-admin@1 - Raise version to 1.1.0
Tim Otten [Thu, 16 Nov 2023 20:00:00 +0000 (12:00 -0800)]
setting-admin@1 - Raise version to 1.1.0

The original implementation uses some small niceties that don't backport well. Let's call this 1.1.x.

I've got a separate variant that backports better. We'll call that 1.0.x.

12 months ago(NFC) setting-admin@1 - Fix the `@since` metadata
Tim Otten [Thu, 16 Nov 2023 19:33:13 +0000 (11:33 -0800)]
(NFC) setting-admin@1 - Fix the `@since` metadata

The code was originally written during 5.67.alpha1 and then merged during
5.68.alpha. So the `@since` is slightly off.

12 months agoMerge pull request #28139 from mlutfy/l10nPartTwo
demeritcowboy [Thu, 16 Nov 2023 15:43:00 +0000 (10:43 -0500)]
Merge pull request #28139 from mlutfy/l10nPartTwo

setup: Allow language selection regardless of whether languages are available

12 months agoMerge pull request #28163 from seamuslee001/notice_fixes_contribution_edit
demeritcowboy [Thu, 16 Nov 2023 02:16:32 +0000 (21:16 -0500)]
Merge pull request #28163 from seamuslee001/notice_fixes_contribution_edit

[REF] Fix Smarty Notice Errors on Contribution Edit

12 months agoMerge pull request #28076 from eileenmcnaughton/parse
Seamus Lee [Thu, 16 Nov 2023 01:31:44 +0000 (12:31 +1100)]
Merge pull request #28076 from eileenmcnaughton/parse

Clarify that the values passed are the submitted values, not altered values

12 months agoMerge pull request #28161 from totten/master-allflowstest
Eileen McNaughton [Thu, 16 Nov 2023 01:25:31 +0000 (14:25 +1300)]
Merge pull request #28161 from totten/master-allflowstest

(REF) Authx - Split `AllFlowsTest` into smaller, themetic tests

12 months agoMerge pull request #28159 from civicrm/5.68
Seamus Lee [Thu, 16 Nov 2023 00:50:56 +0000 (11:50 +1100)]
Merge pull request #28159 from civicrm/5.68

5.68

12 months agoMerge pull request #28160 from wikimediaWfan/upstream
Seamus Lee [Thu, 16 Nov 2023 00:50:33 +0000 (11:50 +1100)]
Merge pull request #28160 from wikimediaWfan/upstream

Update Merger.php to compare strict type for checkboxes where a dummy…

12 months ago[REF] Fix Smarty Notice Errors on Contribution Edit
Seamus Lee [Thu, 16 Nov 2023 00:36:56 +0000 (11:36 +1100)]
[REF] Fix Smarty Notice Errors on Contribution Edit

12 months ago(REF) Split `AllFlowsTest` into smaller, thematic tests
Tim Otten [Thu, 16 Nov 2023 00:04:24 +0000 (16:04 -0800)]
(REF) Split `AllFlowsTest` into smaller, thematic tests

12 months agoUpdate Merger.php to compare strict type for checkboxes where a dummy-string is being...
wfan [Thu, 16 Nov 2023 00:04:07 +0000 (16:04 -0800)]
Update Merger.php to compare strict type for checkboxes where a dummy-string is being used, to prevent this matching 'true'

12 months agoMerge pull request #28137 from colemanw/havingFix
Seamus Lee [Thu, 16 Nov 2023 00:00:37 +0000 (11:00 +1100)]
Merge pull request #28137 from colemanw/havingFix

APIv4 - Fix index interfering with HAVING

12 months agoMerge pull request #28158 from seamuslee001/regen_28144
Seamus Lee [Wed, 15 Nov 2023 23:42:31 +0000 (10:42 +1100)]
Merge pull request #28158 from seamuslee001/regen_28144

[REF] Regen after #28144

12 months ago(REF) Extract base class `AbstractFlowsTest`
Tim Otten [Wed, 15 Nov 2023 23:24:28 +0000 (15:24 -0800)]
(REF) Extract base class `AbstractFlowsTest`

12 months agoMerge pull request #28150 from colemanw/today
Aidan Saunders [Wed, 15 Nov 2023 22:58:29 +0000 (22:58 +0000)]
Merge pull request #28150 from colemanw/today

[REF] APIv4 - Minor cleanup of redundant variables

12 months ago[REF] Regen after #28144
Seamus Lee [Wed, 15 Nov 2023 22:38:51 +0000 (09:38 +1100)]
[REF] Regen after #28144

12 months agoMerge pull request #28144 from eileenmcnaughton/online_receipt
Seamus Lee [Wed, 15 Nov 2023 22:35:28 +0000 (09:35 +1100)]
Merge pull request #28144 from eileenmcnaughton/online_receipt

Replace math in template with variable, smarty3 support

12 months agoMerge pull request #28140 from eileenmcnaughton/event_text
Seamus Lee [Wed, 15 Nov 2023 22:34:43 +0000 (09:34 +1100)]
Merge pull request #28140 from eileenmcnaughton/event_text

Remove last references to `_contributeMode`

12 months agoMerge pull request #28155 from totten/master-localtasks
Seamus Lee [Wed, 15 Nov 2023 21:25:03 +0000 (08:25 +1100)]
Merge pull request #28155 from totten/master-localtasks

Page Templates - Remove unused `$localTasks` (`localNav.tpl`)

12 months agoMerge pull request #28154 from civicrm/5.68
demeritcowboy [Wed, 15 Nov 2023 21:03:21 +0000 (16:03 -0500)]
Merge pull request #28154 from civicrm/5.68

5.68

12 months agoPage Templates - Remove unused `$localTasks` (`localNav.tpl`)
Tim Otten [Wed, 15 Nov 2023 20:19:38 +0000 (12:19 -0800)]
Page Templates - Remove unused `$localTasks` (`localNav.tpl`)

12 months agoMerge pull request #28153 from demeritcowboy/menu-missing
Seamus Lee [Wed, 15 Nov 2023 20:10:59 +0000 (07:10 +1100)]
Merge pull request #28153 from demeritcowboy/menu-missing

dev/core#4778 - php notice causes civi menu to go missing

12 months agoMerge pull request #28000 from seamuslee001/guzzle_update
demeritcowboy [Wed, 15 Nov 2023 20:01:38 +0000 (15:01 -0500)]
Merge pull request #28000 from seamuslee001/guzzle_update

Update Guzzle to 7.6.1 for Drupal 7/Backdrop/WordPress/Joomla

12 months agoAPIv4 - Fix index interfering with HAVING
colemanw [Tue, 14 Nov 2023 18:40:29 +0000 (13:40 -0500)]
APIv4 - Fix index interfering with HAVING

It's not always safe to delete items from the SELECT clause... so let's not.
Fixes dev/core#4017

12 months agophp notice
demeritcowboy [Wed, 15 Nov 2023 19:10:28 +0000 (14:10 -0500)]
php notice

12 months agoMerge pull request #28143 from eileenmcnaughton/online_cont_tax_check
demeritcowboy [Wed, 15 Nov 2023 18:38:54 +0000 (13:38 -0500)]
Merge pull request #28143 from eileenmcnaughton/online_cont_tax_check

Add test cover for tax details in Dummy payment online contribution receipt

12 months agoMerge pull request #28149 from civicrm/5.68
demeritcowboy [Wed, 15 Nov 2023 18:03:44 +0000 (13:03 -0500)]
Merge pull request #28149 from civicrm/5.68

5.68

12 months agoAPIv4 - Minor cleanup of redundant variables
colemanw [Wed, 15 Nov 2023 16:34:45 +0000 (11:34 -0500)]
APIv4 - Minor cleanup of redundant variables

Is it just me, or does staring at the word today for too long stop making sense?

12 months agoMerge pull request #28136 from ErikHommel/master
demeritcowboy [Wed, 15 Nov 2023 16:16:23 +0000 (11:16 -0500)]
Merge pull request #28136 from ErikHommel/master

fix issue #4770 Ensure the followup_assignee_contact_id is an array so all assignees are saved, not just the first one

12 months agoMerge pull request #28145 from colemanw/parentNames
colemanw [Wed, 15 Nov 2023 16:11:12 +0000 (11:11 -0500)]
Merge pull request #28145 from colemanw/parentNames

dev/core#4740 - Fix missing tagsets when label doesn't match name

12 months agoMerge pull request #28117 from demeritcowboy/casedashboard-warnings2
Mathieu Lu [Wed, 15 Nov 2023 14:38:16 +0000 (09:38 -0500)]
Merge pull request #28117 from demeritcowboy/casedashboard-warnings2

[php8] php warnings on case dashboard

12 months agoMerge pull request #28146 from seamuslee001/fix_tests
demeritcowboy [Wed, 15 Nov 2023 14:03:30 +0000 (09:03 -0500)]
Merge pull request #28146 from seamuslee001/fix_tests

[REF] Fix test fails caused by changes to mailing footer

12 months agoMerge pull request #28070 from eileenmcnaughton/participant_backoffice
colemanw [Wed, 15 Nov 2023 13:54:30 +0000 (08:54 -0500)]
Merge pull request #28070 from eileenmcnaughton/participant_backoffice

Clean up contributionParams - backoffice participant form

12 months agofix on review
Erik Hommel [Wed, 15 Nov 2023 13:42:38 +0000 (14:42 +0100)]
fix on review

Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
12 months agoMerge pull request #28119 from lcdservices/dev-core-4772
Tim Otten [Wed, 15 Nov 2023 07:55:45 +0000 (00:55 -0700)]
Merge pull request #28119 from lcdservices/dev-core-4772

dev/core#4772 fix authx on Joomla

12 months ago[REF] Fix test fails caused by changes to mailing footer
Seamus Lee [Wed, 15 Nov 2023 05:05:16 +0000 (16:05 +1100)]
[REF] Fix test fails caused by changes to mailing footer

12 months agoUpdate Guzzle to 7.6.1 for Drupal 7/Backdrop/WordPress/Joomla
Seamus Lee [Thu, 2 Nov 2023 21:51:06 +0000 (08:51 +1100)]
Update Guzzle to 7.6.1 for Drupal 7/Backdrop/WordPress/Joomla

12 months agodev/core#4740 - Fix missing tagsets when label doesn't match name
colemanw [Wed, 15 Nov 2023 01:10:38 +0000 (20:10 -0500)]
dev/core#4740 - Fix missing tagsets when label doesn't match name

CRM_Core_Form_Tag::buildQuickForm was previously being passed an array of [id => name]
but it was wastefully ignoring the passed ids and looking it up from the name.

Now due to bcf668d is being passed an array of [id => label] which is all it needs,
just had to remove the wasteful id lookup when it's already there.

12 months agoMerge pull request #28142 from eileenmcnaughton/notice_cms
Eileen McNaughton [Wed, 15 Nov 2023 01:07:09 +0000 (14:07 +1300)]
Merge pull request #28142 from eileenmcnaughton/notice_cms

Fix notice on showCMS:

12 months agoMerge pull request #28133 from colemanw/civiCasePerms
colemanw [Wed, 15 Nov 2023 00:48:55 +0000 (19:48 -0500)]
Merge pull request #28133 from colemanw/civiCasePerms

dev/core#4769 APIv4 - Fix access to case activities for administrators

12 months agoMerge pull request #28141 from eileenmcnaughton/object_notice
Eileen McNaughton [Tue, 14 Nov 2023 23:21:37 +0000 (12:21 +1300)]
Merge pull request #28141 from eileenmcnaughton/object_notice

Fix notice on payment processor object

12 months agoReplace math in template with variable, smarty3 support
Eileen McNaughton [Tue, 14 Nov 2023 22:59:59 +0000 (11:59 +1300)]
Replace math in template with variable, smarty3 support

The handling for math in smarty2 & 3 differs wrt precedence, when used
with a modifier. It's a bit tricky supporting both but in this
case we can simply rely on another key in the array that already exists
and is equivalent

Note that the membership online template is excluded deliberately for now
as it does not currently access the same lineItems variable
as all the other templates

12 months agoAdd test cover for tax details in Dummy payment online contribution receipt
Eileen McNaughton [Tue, 14 Nov 2023 22:52:28 +0000 (11:52 +1300)]
Add test cover for tax details in Dummy payment online contribution receipt

12 months agoFix notice on showCMS:
Eileen McNaughton [Tue, 14 Nov 2023 22:27:38 +0000 (11:27 +1300)]
Fix notice on showCMS:

12 months agoFix notice on payment processor object
Eileen McNaughton [Tue, 14 Nov 2023 22:22:28 +0000 (11:22 +1300)]
Fix notice on payment processor object

12 months agoMerge pull request #28138 from eileenmcnaughton/online_cont_tax_check
demeritcowboy [Tue, 14 Nov 2023 22:10:57 +0000 (17:10 -0500)]
Merge pull request #28138 from eileenmcnaughton/online_cont_tax_check

Check tax is present in online contribution page receipt

12 months agoRemove last references to _contributeMode
Eileen McNaughton [Tue, 14 Nov 2023 21:39:44 +0000 (10:39 +1300)]
Remove last references to _contributeMode

12 months agoMerge pull request #28065 from eileenmcnaughton/event_text
Eileen McNaughton [Tue, 14 Nov 2023 21:35:56 +0000 (10:35 +1300)]
Merge pull request #28065 from eileenmcnaughton/event_text

Replace last tpl uses of `contributeMode`

12 months agoCheck tax is present in online contribution page receipt
Eileen McNaughton [Tue, 14 Nov 2023 19:27:48 +0000 (08:27 +1300)]
Check tax is present in online contribution page receipt

12 months agoReplace last tpl uses of contributeMode
Eileen McNaughton [Fri, 22 Sep 2023 22:27:22 +0000 (10:27 +1200)]
Replace last tpl uses of contributeMode

This adds the strings to what the processor can determin, allowing us to stop checkign contributeMode

12 months agoMerge pull request #28053 from agileware/CIVICRM-2190
Mathieu Lu [Tue, 14 Nov 2023 20:44:14 +0000 (15:44 -0500)]
Merge pull request #28053 from agileware/CIVICRM-2190

Default mailing footer component incorrectly describes opt-out action as unsubscribe

12 months agosetup: Allow language selection regarless of whether languages are available
Mathieu Lu [Tue, 14 Nov 2023 20:18:25 +0000 (15:18 -0500)]
setup: Allow language selection regarless of whether languages are available

12 months agoMerge pull request #28061 from jaapjansma/l10n_downloader
demeritcowboy [Tue, 14 Nov 2023 19:23:01 +0000 (14:23 -0500)]
Merge pull request #28061 from jaapjansma/l10n_downloader

Setup: able to download translation files automatically

12 months agoMerge pull request #28033 from colemanw/assetCheck
demeritcowboy [Tue, 14 Nov 2023 18:09:25 +0000 (13:09 -0500)]
Merge pull request #28033 from colemanw/assetCheck

dev/core#4754 - Add status check to warn of missing/outdated public assets

12 months agoadded plugin to download l10n translation files
Jaap Jansma [Tue, 14 Nov 2023 16:16:22 +0000 (17:16 +0100)]
added plugin to download l10n translation files

12 months agoMerge pull request #28112 from colemanw/searchKitInputMode
colemanw [Tue, 14 Nov 2023 15:35:55 +0000 (10:35 -0500)]
Merge pull request #28112 from colemanw/searchKitInputMode

SearchKit - Add inputMode setting to allow clauses to reference column values

12 months agodev/core#4754 - Add status check to warn of missing/outdated public assets
colemanw [Tue, 7 Nov 2023 01:36:56 +0000 (20:36 -0500)]
dev/core#4754 - Add status check to warn of missing/outdated public assets

12 months agofix issue #4770
Erik Hommel [Tue, 14 Nov 2023 10:04:16 +0000 (11:04 +0100)]
fix issue #4770

Making sure the followup_assignee_contact_id is an array so all assignees are saved, not just the first one

12 months agoMerge pull request #28060 from eileenmcnaughton/error_verbose
Matthew Wire [Tue, 14 Nov 2023 09:11:22 +0000 (09:11 +0000)]
Merge pull request #28060 from eileenmcnaughton/error_verbose

Use `supportsNoReturn()` instead of contributeMode check

12 months agoMerge pull request #28135 from civicrm/5.68
Seamus Lee [Tue, 14 Nov 2023 02:51:48 +0000 (13:51 +1100)]
Merge pull request #28135 from civicrm/5.68

5.68

12 months agoMerge pull request #28130 from eileenmcnaughton/568
Seamus Lee [Tue, 14 Nov 2023 02:50:02 +0000 (13:50 +1100)]
Merge pull request #28130 from eileenmcnaughton/568

Update the parameters passed to the hook_QueueTaskError

12 months agoMerge pull request #28131 from civicrm/5.68
Seamus Lee [Tue, 14 Nov 2023 02:49:53 +0000 (13:49 +1100)]
Merge pull request #28131 from civicrm/5.68

5.68

12 months agoAPIv4 - Fix access to case activities for administrators
colemanw [Tue, 14 Nov 2023 01:57:26 +0000 (20:57 -0500)]
APIv4 - Fix access to case activities for administrators

Fixes dev/core#4769

Before: Case administrators with 'access deleted contacts' permission blocked from viewing Case activities in APIv4
After: Permissions work correctly.

The problem was the hook logic was incorrectly interpreting empty permissions to mean "no access"
when it actually means "unrestricted access".

12 months agoMove set up of complicated price set to the ContributionPageTestTrait & test to the...
Eileen McNaughton [Mon, 13 Nov 2023 18:19:51 +0000 (07:19 +1300)]
Move set up of complicated price set to the ContributionPageTestTrait & test to the confirmTest

We need to add some more testing but most of our existing tests are within the apiv3 test harness
which is not a great location. This moves one test over to the full form test flow
and also pimps the helper trait to support this complex price scenario (with fields
of a mixture of types & financial types.

I want to add some checks on the email output but this specific test is pay later
so I won't do it in this PR