Eileen McNaughton [Mon, 1 Jul 2019 05:10:14 +0000 (17:10 +1200)]
Merge pull request #14654 from JMAConsulting/dev-1079
dev-core#1079: Improper character encoding breaks xml processor
Eileen McNaughton [Mon, 1 Jul 2019 04:38:39 +0000 (16:38 +1200)]
Merge pull request #14682 from demeritcowboy/div-div-div-div-div
dev/core#1086 - Mismatched div and /div tags in caseTypeDetails.html
Eileen McNaughton [Mon, 1 Jul 2019 02:09:40 +0000 (14:09 +1200)]
Merge pull request #14683 from eileenmcnaughton/unserial2
Block classes in unserialize field for IDE cheer
colemanw [Mon, 1 Jul 2019 00:45:21 +0000 (20:45 -0400)]
Merge pull request #14681 from eileenmcnaughton/format
[NFC][test] reformat jobTest class
eileen [Mon, 1 Jul 2019 00:21:49 +0000 (12:21 +1200)]
Block classes in unserialize field for IDE cheer
DemeritCowboy [Sun, 30 Jun 2019 23:52:34 +0000 (19:52 -0400)]
one too many divs
eileen [Sun, 30 Jun 2019 23:00:18 +0000 (11:00 +1200)]
[NFC][test] reformat jobTest class
Eileen McNaughton [Sun, 30 Jun 2019 22:31:32 +0000 (10:31 +1200)]
Merge pull request #14679 from colemanw/Improve
Improve protected field metadata
Coleman Watts [Sun, 30 Jun 2019 04:33:30 +0000 (00:33 -0400)]
Improve protected field metadata
Eileen McNaughton [Sat, 29 Jun 2019 23:52:53 +0000 (11:52 +1200)]
Merge pull request #14677 from civicrm/5.15
5.15 to master
Eileen McNaughton [Sat, 29 Jun 2019 23:52:16 +0000 (11:52 +1200)]
Merge pull request #14656 from eileenmcnaughton/ad_hoc_mailing
dev/core#1030 fix mis-saving of hidden smart group when sending mail from search builder
Seamus Lee [Sat, 29 Jun 2019 00:01:47 +0000 (10:01 +1000)]
Merge pull request #14670 from eileenmcnaughton/cust_field_2
[REF] do not receive by reference in CustomField::create
Seamus Lee [Fri, 28 Jun 2019 23:05:47 +0000 (09:05 +1000)]
Merge pull request #14477 from eileenmcnaughton/part_defaults
URL support for some params in event search
eileen [Fri, 28 Jun 2019 22:43:33 +0000 (10:43 +1200)]
[REF] do not receive by reference in CustomField::create
I audited the places where this is called in core and the object is not later interogated for changes
Seamus Lee [Fri, 28 Jun 2019 22:24:49 +0000 (08:24 +1000)]
Merge pull request #14625 from eileenmcnaughton/cust_rel_fix
dev/core#389 Fix custom data relative date searching
Eileen McNaughton [Fri, 28 Jun 2019 22:18:11 +0000 (10:18 +1200)]
Merge pull request #14669 from civicrm/5.15
5.15
Seamus Lee [Fri, 28 Jun 2019 22:16:36 +0000 (08:16 +1000)]
Merge pull request #14657 from eileenmcnaughton/smart_15
Remove cached smart group entries when removing from a group
eileen [Fri, 28 Jun 2019 22:07:29 +0000 (10:07 +1200)]
Store header to statics in unit tests
eileen [Thu, 27 Jun 2019 11:37:19 +0000 (23:37 +1200)]
dev/core#1074 fix failure of actions from manage groups screen
eileen [Thu, 27 Jun 2019 12:56:31 +0000 (00:56 +1200)]
dev/core#1030 fix mis-saving of hidden smart group when sending mail from search builder
Fixes a bug where sending a civimail from search builder was sending out to the wrong list
Seamus Lee [Fri, 28 Jun 2019 22:01:49 +0000 (08:01 +1000)]
Merge pull request #14256 from greenpeace-cee/innodb-log-tables
dev/core#663 - Use InnoDB engine for extended log tables
Eileen McNaughton [Fri, 28 Jun 2019 21:46:10 +0000 (09:46 +1200)]
Merge pull request #14665 from seamuslee001/mechanisenros_key
Add in Andrei Mondoc(mecachisenros) to contributor key
Eileen McNaughton [Fri, 28 Jun 2019 21:45:45 +0000 (09:45 +1200)]
Merge pull request #14666 from demeritcowboy/finborg
dev/core#1082 - test demonstrating message template mixup
DemeritCowboy [Fri, 28 Jun 2019 08:59:35 +0000 (04:59 -0400)]
test demonstrating dev/core#1082
Seamus Lee [Fri, 28 Jun 2019 05:09:01 +0000 (15:09 +1000)]
Add in Andrei Mondoc(mecachisenros) to contributor key
Seamus Lee [Fri, 28 Jun 2019 05:57:29 +0000 (15:57 +1000)]
Merge pull request #13477 from mecachisenros/invoice-line-items
Fix incorrect display of Line Items created via API when printing invoice (for Participants)
Eileen McNaughton [Fri, 28 Jun 2019 03:55:40 +0000 (15:55 +1200)]
Merge pull request #14664 from civicrm/5.15
5.15
Eileen McNaughton [Fri, 28 Jun 2019 01:50:19 +0000 (13:50 +1200)]
Merge pull request #14659 from seamuslee001/5.15
dev/core#1082 properly regenerate civicrm_generated file
Eileen McNaughton [Fri, 28 Jun 2019 01:39:03 +0000 (13:39 +1200)]
Merge pull request #14660 from colemanw/apiKeyCheck
Move api_key read/write permission checks from api to BAO
colemanw [Fri, 28 Jun 2019 01:16:43 +0000 (21:16 -0400)]
Merge pull request #14622 from eileenmcnaughton/recordpartial
[REF] Copy assignProportional Line items back into Payment.create function
colemanw [Fri, 28 Jun 2019 01:10:57 +0000 (21:10 -0400)]
Merge pull request #14650 from eileenmcnaughton/cust_field_create
[REF] minor code cleanup - move indexExist calculation to the only place in the code that needs it
colemanw [Fri, 28 Jun 2019 01:09:37 +0000 (21:09 -0400)]
Merge pull request #14651 from eileenmcnaughton/cust_field_2
[REF] Remove columnName field
Andrei Mondoc [Thu, 27 Jun 2019 16:37:19 +0000 (17:37 +0100)]
add test for invoice line items
eileen [Thu, 27 Jun 2019 13:23:43 +0000 (01:23 +1200)]
Remove cached smart group entries when removing from a group
In 5.15 we have added fixes for smart groups regarding removed entries. Possibly related to this but also possibly pre-existing
I'm seeing contacts who have been removed from smart groups showing up after removal in search results for the duration of the smart group cache.
Regardless the fix feels safe, sensible and correct so I'm comfortable targetting the rc without further research as to whether it
is a regression. The fix being removal of the cache entry when the group entry is removed.
Andrei Mondoc [Wed, 16 Jan 2019 21:35:40 +0000 (21:35 +0000)]
retrieve LineItems by contributionID regardless of component
Coleman Watts [Thu, 27 Jun 2019 22:57:08 +0000 (18:57 -0400)]
Move api_key write permission checks from api to BAO
Seamus Lee [Mon, 20 May 2019 22:34:52 +0000 (08:34 +1000)]
Move api_key read permission checks from api to BAO
Seamus Lee [Thu, 27 Jun 2019 22:53:35 +0000 (08:53 +1000)]
dev/core#1082 properly regenerate civicrm_generated file
Eileen McNaughton [Thu, 27 Jun 2019 11:57:10 +0000 (23:57 +1200)]
Merge pull request #14645 from colemanw/noAmp
Remove superfluous pass-by-ref in api3
Monish Deb [Thu, 27 Jun 2019 11:33:28 +0000 (17:03 +0530)]
dev-core#1079: Improper character encoding breaks xml processor
eileen [Fri, 31 May 2019 00:47:30 +0000 (12:47 +1200)]
dev/core#389 Fix custom data relative date searching
This addresses a fairly old regression where smart groups based on relative dates stopped being relative
Eileen McNaughton [Thu, 27 Jun 2019 08:29:26 +0000 (20:29 +1200)]
Merge pull request #14653 from eileenmcnaughton/test_clean
[REF + test] extract buildFieldChangeSql and add unit test
Eileen McNaughton [Thu, 27 Jun 2019 06:53:35 +0000 (18:53 +1200)]
Merge pull request #14637 from seamuslee001/unit_test_dev_core_1069
[Test] Add in unit test attempting to demonstrate issue caused by dev…
eileen [Thu, 27 Jun 2019 06:22:49 +0000 (18:22 +1200)]
[REF + test] extract buildFieldChangeSql and add unit test
Eileen McNaughton [Thu, 27 Jun 2019 06:08:53 +0000 (18:08 +1200)]
Merge pull request #14649 from eileenmcnaughton/test_clean
[NFC] formatting on test class cleanup
eileen [Thu, 27 Jun 2019 02:30:57 +0000 (14:30 +1200)]
[NFC] formatting on test class cleanup
Eileen McNaughton [Thu, 27 Jun 2019 04:45:59 +0000 (16:45 +1200)]
Merge pull request #14652 from eileenmcnaughton/cust_field_3
[REF] extract createOptionValue function in CustomField::create
eileen [Thu, 27 Jun 2019 03:23:55 +0000 (15:23 +1200)]
[REF] extract createOptionValue function in CustomField::create
eileen [Thu, 27 Jun 2019 03:16:40 +0000 (15:16 +1200)]
Remove columnName field
This field always holds the same information as ['column_name']. It was introduced
before https://github.com/civicrm/civicrm-core/pull/1206/files which removed some of it's
use but not the variable. There is test coverage on passing in column_name
in testCreateCustomFieldColumnName
Eileen McNaughton [Thu, 27 Jun 2019 03:01:44 +0000 (15:01 +1200)]
Merge pull request #14646 from colemanw/pledgeSpec
Removing unused spec function
eileen [Thu, 27 Jun 2019 02:59:03 +0000 (14:59 +1200)]
[REF] minor code cleanup - move indexExist calculation to the only place in the code that needs it
Readability fix
Eileen McNaughton [Thu, 27 Jun 2019 01:47:28 +0000 (13:47 +1200)]
Merge pull request #14643 from eileenmcnaughton/schemah
Remove a few places where pass by reference is used but does not need to be
Coleman Watts [Thu, 27 Jun 2019 01:06:47 +0000 (21:06 -0400)]
Removing unused spec function
Coleman Watts [Thu, 27 Jun 2019 01:04:03 +0000 (21:04 -0400)]
Remove superfluous pass-by-ref in api3
eileen [Thu, 27 Jun 2019 00:24:43 +0000 (12:24 +1200)]
Remove a few places where pass by reference is used but does not need to be
Eileen McNaughton [Wed, 26 Jun 2019 23:11:25 +0000 (11:11 +1200)]
Merge pull request #14642 from civicrm/5.15
5.15
Seamus Lee [Wed, 26 Jun 2019 22:50:09 +0000 (08:50 +1000)]
Merge pull request #14571 from eileenmcnaughton/mem
dev/core#1038 partial - fix checksum url for cancelling recurring with mid in the url
Seamus Lee [Wed, 26 Jun 2019 22:18:29 +0000 (08:18 +1000)]
Merge pull request #14641 from agh1/fix-cron-help-link
Scheduled jobs: replace outdated wiki link
Andrew Hunt [Wed, 26 Jun 2019 15:43:27 +0000 (11:43 -0400)]
Scheduled jobs: replace outdated wiki link
Eileen McNaughton [Wed, 26 Jun 2019 05:48:45 +0000 (17:48 +1200)]
Merge pull request #14601 from seamuslee001/dev_core_1067
dev/core#1067 Clean Money before creating Campaign record and add test
Eileen McNaughton [Wed, 26 Jun 2019 00:05:32 +0000 (12:05 +1200)]
Merge pull request #14626 from eileenmcnaughton/notice
Fix notice on editing contribution
eileen [Mon, 24 Jun 2019 02:43:16 +0000 (14:43 +1200)]
Fix notice on editing contribution
Seamus Lee [Tue, 25 Jun 2019 22:23:35 +0000 (08:23 +1000)]
Merge pull request #14499 from mattwire/extract_getdefaultroleid
REF Extract getDefaultRoleID for add participant
Tim Otten [Tue, 25 Jun 2019 21:58:14 +0000 (14:58 -0700)]
Merge pull request #14634 from colemanw/checklist
Add checklist-model angular module
Seamus Lee [Tue, 25 Jun 2019 21:56:23 +0000 (07:56 +1000)]
Merge pull request #14636 from colemanw/revertDate
Partially revert "Update example dates from 2009 to current year"
Seamus Lee [Tue, 25 Jun 2019 21:50:28 +0000 (07:50 +1000)]
Merge pull request #14597 from colemanw/Reset
Reset language at end of localized api call
Eileen McNaughton [Tue, 25 Jun 2019 21:46:02 +0000 (09:46 +1200)]
Merge pull request #14638 from civicrm/5.15
5.15 to master
Seamus Lee [Tue, 25 Jun 2019 21:37:50 +0000 (07:37 +1000)]
Merge pull request #14624 from eileenmcnaughton/force_defaults
dev/core#1059 Fix contribution search to work with url parameters in force mode
Seamus Lee [Tue, 25 Jun 2019 21:37:14 +0000 (07:37 +1000)]
Merge pull request #14618 from eileenmcnaughton/5.15
dev/core#926 & dev/core#1048 Fix group search builder bugs
Seamus Lee [Tue, 25 Jun 2019 21:16:02 +0000 (07:16 +1000)]
[Test] Add in unit test attempting to demonstrate issue caused by dev/core#1069
Eileen McNaughton [Tue, 25 Jun 2019 20:43:42 +0000 (08:43 +1200)]
Merge pull request #14632 from colemanw/datePicker
Handle relative start & end dates passed to datepicker widget
Coleman Watts [Tue, 25 Jun 2019 20:33:31 +0000 (16:33 -0400)]
Partially revert "Update example dates from 2009 to current year"
This reverts most of commit
86ef49af1894a4e68a9bf84d40bb5fa0cb98c586.
Eileen McNaughton [Tue, 25 Jun 2019 20:17:35 +0000 (08:17 +1200)]
Merge pull request #14635 from colemanw/2019
Update example dates from 2009 to current year
Coleman Watts [Tue, 25 Jun 2019 13:51:13 +0000 (09:51 -0400)]
Update example dates from 2009 to current year
Coleman Watts [Tue, 25 Jun 2019 13:37:01 +0000 (09:37 -0400)]
Add checklist-model angular module
Eileen McNaughton [Tue, 25 Jun 2019 03:11:21 +0000 (15:11 +1200)]
Merge pull request #14630 from mlutfy/activityStatus
Activity formRule status check cleanup
Coleman Watts [Tue, 25 Jun 2019 02:57:10 +0000 (22:57 -0400)]
Handle relative start & end dates passed to datepicker widget
Seamus Lee [Tue, 25 Jun 2019 00:06:46 +0000 (10:06 +1000)]
Merge pull request #14607 from seamuslee001/clear_memory_backed_groups_cache
Ensure that contact groups caches are cleared if memory backed
Eileen McNaughton [Mon, 24 Jun 2019 23:31:43 +0000 (11:31 +1200)]
Merge pull request #14631 from seamuslee001/remove_legacy_prevnext_group
Remove handling for legacy PrevNextCache group as it has now been con…
eileen [Sun, 23 Jun 2019 23:59:18 +0000 (11:59 +1200)]
dev/core#1059 Fix contribution search to work with url parameters in force mode
Note this is part of the general 'convert receive_date to datepicker' work
eileen [Fri, 7 Jun 2019 05:16:59 +0000 (17:16 +1200)]
Support url defaults on event search
This adds url support for sort_name & participant_status_id & participant_register_date to event search
civicrm/event/search?reset=1&sort_name=p&participant_status_id=1&participant_register_date_low=
20180101
Seamus Lee [Mon, 24 Jun 2019 22:05:55 +0000 (08:05 +1000)]
Remove handling for legacy PrevNextCache group as it has now been converted
Seamus Lee [Mon, 24 Jun 2019 21:51:47 +0000 (07:51 +1000)]
Merge pull request #14627 from eileenmcnaughton/cont_date
Follow up to receive_date convert to datepicker - update test
Eileen McNaughton [Mon, 24 Jun 2019 20:42:52 +0000 (08:42 +1200)]
Merge pull request #14588 from colemanw/js
Improve utilities & tests for working with js notation
Eileen McNaughton [Mon, 24 Jun 2019 20:20:35 +0000 (08:20 +1200)]
Merge pull request #14629 from seamuslee001/test_dev_core_357
[TEST] Update Email Common Test to incorporate testing for the fix fo…
Coleman Watts [Thu, 20 Jun 2019 15:42:51 +0000 (11:42 -0400)]
Improve utilities & tests for working with js notation
Mathieu Lutfy [Mon, 24 Jun 2019 14:21:42 +0000 (10:21 -0400)]
Activity formRule status check cleanup
Under some circumstances, the activity_type_id from fields and from the getKey
call can both return NULL, causing the formRule to raise an error that one cannot
record a scheduled SMS activity.
colemanw [Mon, 24 Jun 2019 13:19:08 +0000 (09:19 -0400)]
Merge pull request #14602 from mattwire/event_selectedchild
Add a helper function to ensure we always set the correct tab for manage events
Seamus Lee [Mon, 24 Jun 2019 10:44:33 +0000 (20:44 +1000)]
[TEST] Update Email Common Test to incorporate testing for the fix for dev/core#357 for signatures
Seamus Lee [Mon, 24 Jun 2019 06:08:37 +0000 (16:08 +1000)]
Merge pull request #14612 from seamuslee001/fix_contribution_status_default_search_form
Ensure that completed status is selected by default on search contrib…
Seamus Lee [Sun, 23 Jun 2019 05:56:04 +0000 (15:56 +1000)]
Ensure that completed status is selected by default on search contribution form
Use PseudoConstant function as label could change (good point thanks pradeep)
eileen [Mon, 24 Jun 2019 02:55:19 +0000 (14:55 +1200)]
Follow up to receive_date convert to datepicker - update test
eileen [Sun, 23 Jun 2019 19:03:34 +0000 (07:03 +1200)]
Cast = to IN as tests show this PR otherwise breaks on resolving parent-child
Eileen McNaughton [Mon, 24 Jun 2019 00:13:01 +0000 (12:13 +1200)]
Merge pull request #14609 from seamuslee001/5.15
[NFC] Ensure that test is properly cleaned up
Eileen McNaughton [Sun, 23 Jun 2019 23:39:57 +0000 (11:39 +1200)]
Merge pull request #14604 from colemanw/dev/core#1066
dev/core#1066 Fix mailing permissions
Eileen McNaughton [Sun, 23 Jun 2019 23:38:41 +0000 (11:38 +1200)]
Merge pull request #14613 from seamuslee001/dev_core_1059
dev/core#1059 Replace deprecated start and end url params with receiv…
Eileen McNaughton [Sun, 23 Jun 2019 23:30:38 +0000 (11:30 +1200)]
Merge pull request #14611 from eileenmcnaughton/url_support
Follow up fix on start as a url parameter
Eileen McNaughton [Sun, 23 Jun 2019 23:29:53 +0000 (11:29 +1200)]
Merge pull request #14605 from eileenmcnaughton/cust_deadlock
Reduce deadlocks on inserting custom data by only using 'ON DUPLICATE' when it is not a new row
Eileen McNaughton [Sun, 23 Jun 2019 23:29:25 +0000 (11:29 +1200)]
Merge pull request #14623 from eileenmcnaughton/receive
Add query object support for receive_date_high & receive_date_low and generically date fields
eileen [Sun, 23 Jun 2019 22:32:52 +0000 (10:32 +1200)]
Add query object support for receive_date_high & receive_date_low and generically date fields