colemanw [Tue, 26 Sep 2023 19:07:23 +0000 (15:07 -0400)]
Remove es6 polyfill
demeritcowboy [Tue, 26 Sep 2023 16:30:28 +0000 (12:30 -0400)]
Merge pull request #27646 from civicrm/5.66
5.66
colemanw [Tue, 26 Sep 2023 13:31:52 +0000 (09:31 -0400)]
Merge pull request #27612 from eileenmcnaughton/party_trait
Share event lookup functions in a trait
colemanw [Tue, 26 Sep 2023 12:37:15 +0000 (08:37 -0400)]
Merge pull request #27635 from demeritcowboy/custbr
Remove weird `<br>` tag on clear buttons on custom radio fields
colemanw [Tue, 26 Sep 2023 11:26:50 +0000 (07:26 -0400)]
Merge pull request #27639 from mlutfy/core4623
dev/core#4623 Standalone: fix currentPath on AngularJS pages (ex: New Mailing)
Tim Otten [Tue, 26 Sep 2023 08:02:55 +0000 (01:02 -0700)]
Merge pull request #27640 from eileenmcnaughton/mailing_backfill
dev/core#4567 Add upgrade script to mailing-queue-table alter
Tim Otten [Tue, 26 Sep 2023 05:39:11 +0000 (22:39 -0700)]
Merge pull request #27626 from colemanw/mailService
Fix dev/core#4566 by ensuring groupNames are fetched
Tim Otten [Tue, 26 Sep 2023 04:29:31 +0000 (21:29 -0700)]
Merge pull request #27641 from colemanw/extensionUpgrades
Upgrade all core extensions to civix 23.02.1
colemanw [Tue, 26 Sep 2023 02:05:50 +0000 (22:05 -0400)]
Upgrade all core extensions to civix 23.02.1
Mathieu Lu [Tue, 26 Sep 2023 01:09:21 +0000 (21:09 -0400)]
dev/core#4623 Standalone: fix currentPath on AngularJS pages (ex: New Mailing)
Eileen McNaughton [Tue, 26 Sep 2023 01:08:11 +0000 (14:08 +1300)]
Add upgrade script to mailing-queue-table alter
Eileen McNaughton [Mon, 25 Sep 2023 22:41:17 +0000 (11:41 +1300)]
Merge pull request #27633 from demeritcowboy/place-holder
Remove unused place_holder
demeritcowboy [Mon, 25 Sep 2023 19:30:28 +0000 (15:30 -0400)]
place_holder only ever defined in one place
demeritcowboy [Mon, 25 Sep 2023 21:56:06 +0000 (17:56 -0400)]
Merge pull request #27636 from eileenmcnaughton/mailing
Remove unreachable code
Eileen McNaughton [Mon, 25 Sep 2023 21:38:38 +0000 (10:38 +1300)]
Merge pull request #27634 from demeritcowboy/desc
php notices for "description"
Eileen McNaughton [Mon, 25 Sep 2023 21:17:10 +0000 (10:17 +1300)]
Remove unreachable code
Mailing is hard-coded to FALSE so anything that relies on it being TRUE
is unreachable
demeritcowboy [Mon, 25 Sep 2023 20:26:49 +0000 (16:26 -0400)]
Merge pull request #27630 from civicrm/5.66
5.66
demeritcowboy [Mon, 25 Sep 2023 20:04:39 +0000 (16:04 -0400)]
remove weird br tag
demeritcowboy [Mon, 25 Sep 2023 19:54:51 +0000 (15:54 -0400)]
notices
Matthew Wire [Mon, 25 Sep 2023 19:54:34 +0000 (20:54 +0100)]
Merge pull request #27631 from colemanw/afformProximity
SearchKit - Expose Address.proximity filter as Afform search filter
colemanw [Mon, 25 Sep 2023 17:19:00 +0000 (13:19 -0400)]
SearchKit - Expose Address.proximity filter as Afform search filter
demeritcowboy [Mon, 25 Sep 2023 15:32:56 +0000 (11:32 -0400)]
Merge pull request #27629 from colemanw/fixSearchById
Autocomplete - Fix search-by-id for entities without a numeric id
colemanw [Mon, 25 Sep 2023 14:02:21 +0000 (10:02 -0400)]
Autocomplete - Fix search-by-id for entities without a numeric id
Fixes dev/core#4560 and the intermittent failure of AfformGetTest.testAfformAutocomplete
colemanw [Mon, 25 Sep 2023 02:17:23 +0000 (22:17 -0400)]
Fix dev/core#4566 by ensuring groupNames are fetched
The problem was that EditUnsubGroupCtrl needed CRM.crmMailing.groupNames to be fetched,
but wasn't doing anything about it. Instead it was passively waiting around for someone
else to call for them to be loaded. The only place doing this was ViewRecipCtrl, and not consistently.
It was working in core but not in Mosaico.
I solved this by moving the loader functions to a service so they could be called from both places.
colemanw [Mon, 25 Sep 2023 13:45:45 +0000 (09:45 -0400)]
Merge pull request #27628 from mattwire/schedjoblog
AdminUI: Fix filtering logs by scheduled job
Matthew Wire [Mon, 25 Sep 2023 13:02:50 +0000 (14:02 +0100)]
Fix filtering logs by scheduled job
Eileen McNaughton [Mon, 25 Sep 2023 05:31:29 +0000 (18:31 +1300)]
Merge pull request #27627 from demeritcowboy/field
Fix typos in field.tpl
demeritcowboy [Mon, 25 Sep 2023 03:51:47 +0000 (23:51 -0400)]
Merge pull request #27600 from eileenmcnaughton/unreachable
Add deprecated notice to unreachable code
demeritcowboy [Mon, 25 Sep 2023 03:25:37 +0000 (23:25 -0400)]
typo on post_html_text
demeritcowboy [Mon, 25 Sep 2023 03:25:25 +0000 (23:25 -0400)]
typo, but pre_html_text is never used in universe
colemanw [Sun, 24 Sep 2023 23:41:05 +0000 (19:41 -0400)]
Merge pull request #27616 from colemanw/pagerCont
SearchKit - When hiding pager, also hide page count
colemanw [Sun, 24 Sep 2023 22:53:35 +0000 (18:53 -0400)]
Merge pull request #27595 from eileenmcnaughton/part_email_token
Replace email smarty var with token
colemanw [Sun, 24 Sep 2023 22:52:40 +0000 (18:52 -0400)]
Merge pull request #27623 from eileenmcnaughton/no_req
Revove always true if
Eileen McNaughton [Sun, 24 Sep 2023 21:02:03 +0000 (10:02 +1300)]
Merge pull request #27621 from larssandergreen/Remove-missed-backticks-for-Smarty-3
dev/core#4146: Remove missed backticks for Smarty 3, follow up to #27547
Eileen McNaughton [Sun, 24 Sep 2023 21:01:32 +0000 (10:01 +1300)]
Merge pull request #27617 from colemanw/afformBreadcrumb
Afform - run `civix upgrade`
Eileen McNaughton [Sun, 24 Sep 2023 20:59:47 +0000 (09:59 +1300)]
Replace email smarty var with token
This replaces the variable email with the appropriate smarty token
I spent some time tracking back the various contact ID & email refs
but concluded this value would always be the participant email, with
is assigned as contact to the tokens.
Eileen McNaughton [Sun, 24 Sep 2023 20:57:46 +0000 (09:57 +1300)]
Merge pull request #27594 from larssandergreen/Don't-repeat-Smarty-blocks
dev/core#4146 Don't repeat Smarty blocks
Eileen McNaughton [Sun, 24 Sep 2023 20:53:39 +0000 (09:53 +1300)]
Revove always true if
Eileen McNaughton [Sun, 24 Sep 2023 20:51:02 +0000 (09:51 +1300)]
Merge pull request #27619 from larssandergreen/Delete-unused-smarty-blocks
Delete unused Smarty block serialize
colemanw [Sun, 24 Sep 2023 19:58:28 +0000 (15:58 -0400)]
Merge pull request #27591 from eileenmcnaughton/joomla
Add dummy file in place of removed file for Joomla! installers
larssandergreen [Sun, 24 Sep 2023 19:26:25 +0000 (13:26 -0600)]
Don't repeat Smarty blocks
larssandergreen [Sun, 24 Sep 2023 18:51:37 +0000 (12:51 -0600)]
Delete block.serialize.php
colemanw [Sun, 24 Sep 2023 18:50:01 +0000 (14:50 -0400)]
Merge pull request #27620 from larssandergreen/Fix-coding-error-in-#27604
dev/core#4146 Fix coding error in #27604
colemanw [Sun, 24 Sep 2023 18:49:10 +0000 (14:49 -0400)]
Merge pull request #27622 from larssandergreen/Fix-broken-help-for-edit-pledge
Fix broken help for edit pledge
larssandergreen [Sun, 24 Sep 2023 17:14:13 +0000 (11:14 -0600)]
Fix broken help for edit pledge
larssandergreen [Sun, 24 Sep 2023 16:10:47 +0000 (10:10 -0600)]
Remove missed backticks for Smarty 3
larssandergreen [Sun, 24 Sep 2023 16:31:06 +0000 (10:31 -0600)]
Fix coding error in #27604
colemanw [Sun, 24 Sep 2023 16:18:58 +0000 (12:18 -0400)]
Merge pull request #27609 from eileenmcnaughton/no_req
Stop passing unused parameter
colemanw [Sun, 24 Sep 2023 15:17:14 +0000 (11:17 -0400)]
Merge pull request #27606 from eileenmcnaughton/online_pending
Remove always-same parameter from function signature
colemanw [Sun, 24 Sep 2023 15:10:26 +0000 (11:10 -0400)]
Merge pull request #27587 from eileenmcnaughton/smarty_mod
dev/core##4146 Add instance of smarty modifier to prevent errors when running smarty 3
colemanw [Sun, 24 Sep 2023 13:22:54 +0000 (09:22 -0400)]
Afform - run civix upgrade
colemanw [Sun, 24 Sep 2023 12:30:05 +0000 (08:30 -0400)]
SearchKit - When hiding pager, also hide page count
colemanw [Sun, 24 Sep 2023 10:17:54 +0000 (06:17 -0400)]
Merge pull request #27614 from eileenmcnaughton/role_token
Fix a couple more places to use tokens participant role
Eileen McNaughton [Thu, 21 Sep 2023 19:03:12 +0000 (07:03 +1200)]
Fix a couple more places to use tokens
I could make no sense of the whole default role ID thing
I removed it
colemanw [Sun, 24 Sep 2023 02:14:43 +0000 (22:14 -0400)]
Merge pull request #27598 from eileenmcnaughton/offline
[php8] Swap out some tpl variables for tokens in offline receipt template
colemanw [Sun, 24 Sep 2023 01:35:13 +0000 (21:35 -0400)]
Merge pull request #27605 from eileenmcnaughton/part_trait
Flatten array
Eileen McNaughton [Sat, 23 Sep 2023 23:30:26 +0000 (12:30 +1300)]
Share event lookup functions in a trait
This is a step to standardising our event-related forms to all supporting the same consistent
public functions
- getEventID()
- getParticipantID()
- getEventValue()
- getPartcipantValue()
& ouside this PR
- getContactID
- getContactValue()
- getPriceSetID()
- getDiscountID()
Note I didn't implement the participant stuff for the online registration form
at this point because it needs a bit more though
Eileen McNaughton [Sat, 23 Sep 2023 23:33:02 +0000 (12:33 +1300)]
Merge pull request #27604 from larssandergreen/Fix-Smarty-3-broken-help
dev/core##4146 Fix Smarty 3 broken help
colemanw [Sat, 23 Sep 2023 22:37:28 +0000 (18:37 -0400)]
Merge pull request #27607 from braders/dead-code-checkSQLConstraint
Remove dead code - checkSQLConstraint functions
Eileen McNaughton [Sat, 23 Sep 2023 21:45:59 +0000 (10:45 +1300)]
Stop passing unused parameter
Eileen McNaughton [Sat, 23 Sep 2023 10:06:38 +0000 (22:06 +1200)]
Swap out some tpl variables for tokens
These ones are all pretty routine / been done in other templates
Bradley Taylor [Sat, 23 Sep 2023 21:14:27 +0000 (22:14 +0100)]
Remove dead code - checkSQLConstraint functions
Eileen McNaughton [Sat, 23 Sep 2023 21:11:31 +0000 (10:11 +1300)]
Remove always-same parameter from function signature
This function is only ever called with the component event. Removing that parameter makes is clearer
what (how little) it is doing
Eileen McNaughton [Sat, 23 Sep 2023 20:52:51 +0000 (09:52 +1300)]
Flatten array
This array is being built up with an unnecessary layer
colemanw [Sat, 23 Sep 2023 20:28:12 +0000 (16:28 -0400)]
Merge pull request #27601 from eileenmcnaughton/admin
Require all fields in signature, as always passed
colemanw [Sat, 23 Sep 2023 20:17:41 +0000 (16:17 -0400)]
Merge pull request #27603 from braders/dedupemerge-null
[NFC] Proper syntax for null in DedupeMerge
colemanw [Sat, 23 Sep 2023 18:19:16 +0000 (14:19 -0400)]
Merge pull request #27585 from eileenmcnaughton/smarty_compat
dev/core##4146 Add Smarty3 Compatibility helper
colemanw [Sat, 23 Sep 2023 18:11:52 +0000 (14:11 -0400)]
Merge pull request #27588 from eileenmcnaughton/smarty_package
dev/core##4146 Remove our override of Smartyv2 fetch function
larssandergreen [Sat, 23 Sep 2023 17:49:06 +0000 (11:49 -0600)]
Pass in title htxt id instead of assigning so it works in Smarty 3
colemanw [Sat, 23 Sep 2023 17:48:07 +0000 (13:48 -0400)]
Merge pull request #27597 from eileenmcnaughton/fix_loop
Remove undeclared properties `_contributorEmail`, `_toDoNotEmail` from participant form
colemanw [Sat, 23 Sep 2023 17:33:45 +0000 (13:33 -0400)]
Merge pull request #27602 from eileenmcnaughton/text_receipts
Simplify formatting in text versions of workflow messages
Bradley Taylor [Sat, 23 Sep 2023 17:06:21 +0000 (18:06 +0100)]
[NFC] Proper syntax for null in DedupeMerge
Eileen McNaughton [Sat, 23 Sep 2023 12:34:59 +0000 (00:34 +1200)]
Simplify formatting in text versions of workflow messages
Eileen McNaughton [Sat, 23 Sep 2023 12:01:25 +0000 (00:01 +1200)]
Simplify a couple of lines of code
Eileen McNaughton [Sat, 23 Sep 2023 11:55:05 +0000 (23:55 +1200)]
Require all fields in signature, as always passed
Eileen McNaughton [Sat, 23 Sep 2023 11:44:15 +0000 (23:44 +1200)]
Add deprecated notice to unreachable code
Per code comment & my own reading of the code today this else clause seems unreachable
priceSetID is set for quickConfig AND normal prices sets...
Eileen McNaughton [Sat, 23 Sep 2023 11:34:58 +0000 (23:34 +1200)]
Merge pull request #27599 from braders/error-policy-properties
[REF][PHP8.2] Declare properties in CRM_Queue_ErrorPolicy
Bradley Taylor [Sat, 23 Sep 2023 10:38:11 +0000 (11:38 +0100)]
[REF][PHP8.2] Declare properties in CRM_Queue_ErrorPolicy
Eileen McNaughton [Sat, 23 Sep 2023 08:40:17 +0000 (20:40 +1200)]
Remove undeclared properties contributorEmai, toDoNotEmail from participant form
We can use getContactValue to look them up in a cached way as appropriate
larssandergreen [Sat, 23 Sep 2023 04:27:04 +0000 (22:27 -0600)]
Don't repeat crmButton block
Eileen McNaughton [Sat, 23 Sep 2023 04:22:59 +0000 (16:22 +1200)]
Merge pull request #27547 from larssandergreen/More-Smarty-3+-prep
dev/core##4146 [NFC] More Smarty 3+ prep, mostly quoting strings and removing backticks
larssandergreen [Sat, 23 Sep 2023 03:37:39 +0000 (21:37 -0600)]
Fix Administer Custom Field Groups in AdminUI for Smarty 3
Eileen McNaughton [Sat, 23 Sep 2023 03:26:02 +0000 (15:26 +1200)]
Merge pull request #27590 from eileenmcnaughton/template_again
Fix those pesky field notices ...again
larssandergreen [Sat, 23 Sep 2023 03:11:29 +0000 (21:11 -0600)]
Smarty backticks fixes, etc
Eileen McNaughton [Sat, 23 Sep 2023 03:00:30 +0000 (15:00 +1200)]
Merge pull request #27589 from eileenmcnaughton/help_fix
Stop accessng _tpl_vars in smarty from property
Eileen McNaughton [Sat, 23 Sep 2023 02:42:32 +0000 (14:42 +1200)]
Add dummy file in place of removed file for Joomla! installers
Eileen McNaughton [Sat, 23 Sep 2023 02:12:10 +0000 (14:12 +1200)]
Fix those pesky field notices ...again
Eileen McNaughton [Sat, 23 Sep 2023 02:02:50 +0000 (14:02 +1200)]
Stop accessng _tpl_vars in smarty from property
it's bad practice & it hard fails in smartyv3
Eileen McNaughton [Sat, 23 Sep 2023 01:50:58 +0000 (13:50 +1200)]
Remove our override of Smartyv2 fetch function
Eileen McNaughton [Sat, 23 Sep 2023 00:51:30 +0000 (12:51 +1200)]
Add Smarty3 Compatibility helper
Eileen McNaughton [Sat, 23 Sep 2023 01:30:23 +0000 (13:30 +1200)]
Add instance of smarty modifier to prevent errors when running smarty 3
Tim Otten [Sat, 23 Sep 2023 00:20:20 +0000 (17:20 -0700)]
Merge pull request #27526 from eileenmcnaughton/hook
(dev/core#4490) Queues - Add setting and hook to pause/resume background-queues
Eileen McNaughton [Fri, 22 Sep 2023 23:47:34 +0000 (11:47 +1200)]
Merge pull request #27584 from colemanw/smartyEval
dev/core#4618 - Update APIv3 explorer to not encourage php-eval in smarty
Eileen McNaughton [Fri, 22 Sep 2023 23:32:54 +0000 (11:32 +1200)]
Merge pull request #27578 from eileenmcnaughton/offline_e
Fix undefined property on fromEmails for Participant fee
colemanw [Fri, 22 Sep 2023 23:13:20 +0000 (19:13 -0400)]
dev/core#4618 - Update APIv3 explorer to not encourage php-eval in smarty
Tim Otten [Fri, 22 Sep 2023 23:07:55 +0000 (16:07 -0700)]
Merge pull request #27553 from colemanw/afformPhp
dev/core#2396 - Read afform defn from .aff.php files
Eileen McNaughton [Fri, 22 Sep 2023 21:43:36 +0000 (09:43 +1200)]
Fix undefined property on fromEmails for Participant fee
Seamus Lee [Fri, 22 Sep 2023 22:14:26 +0000 (08:14 +1000)]
Merge pull request #27580 from civicrm/5.66
5.66
Tim Otten [Fri, 22 Sep 2023 21:43:47 +0000 (14:43 -0700)]
The Battle of the Synonyms was put on-hold.
With the recent update, it fires a hook, and the hook-data describes the
queue-status as "deferred".
But the setting which drives it is called "queue_suspended".
Which word is better? On reflection... neither!
In CiviMail, there's some existing functionality where you can "pause" a
mail-blast. And it's basically the same thing: we keep the queue-data, but
we tell the workers to temporarily refrain from execution. And that's fine.
"Pausing" sounds less scary...
Eileen McNaughton [Fri, 22 Sep 2023 21:51:09 +0000 (09:51 +1200)]
Merge pull request #27574 from demeritcowboy/sixhundred
[NFC] Partial backport of
0c1d533c to avoid random test fails