Tim Otten [Thu, 18 May 2023 04:37:57 +0000 (21:37 -0700)]
(REF) civicrm_option_groups - Use key-value-tree for messy OGs
Tim Otten [Thu, 18 May 2023 04:10:16 +0000 (21:10 -0700)]
(REF) civicrm_option_groups - Small simplifications
Tim Otten [Wed, 17 May 2023 22:46:59 +0000 (15:46 -0700)]
(REF) CRM_Core_CodeGen_OptionGroup - Implement addValues($rows). More docblocks.
Tim Otten [Wed, 17 May 2023 19:42:50 +0000 (12:42 -0700)]
(REF) CRM_Core_CodeGen_OptionGroup - Rename 'addValues($header, $rows)' to 'addValueTable($header, $rows)'
Tim Otten [Wed, 17 May 2023 19:39:57 +0000 (12:39 -0700)]
Fixup ts() for bug-level consistency
Tim Otten [Wed, 17 May 2023 19:36:32 +0000 (12:36 -0700)]
Fixup ts() accept_card, preferred_communication_method
Tim Otten [Wed, 17 May 2023 11:16:10 +0000 (04:16 -0700)]
civicrm_data.tpl - Consolidate related {php} bits
Tim Otten [Wed, 17 May 2023 11:09:50 +0000 (04:09 -0700)]
Extract activity_default_assignee, entity_batch_extends, file_type
Tim Otten [Wed, 17 May 2023 11:06:09 +0000 (04:06 -0700)]
Extract contribution_recur_status, environment, pledge_status, relative_date_filters
Tim Otten [Wed, 17 May 2023 10:56:47 +0000 (03:56 -0700)]
Extract communication_style, contact_date_reminder_options, msg_mode, name_badge, wysiwyg_presets
Tim Otten [Wed, 17 May 2023 10:50:02 +0000 (03:50 -0700)]
Extract auto_renew_options, financial_account_type, financial_item_status, label_type, sms_api_type, sms_provider_name
Tim Otten [Wed, 17 May 2023 10:12:49 +0000 (03:12 -0700)]
Extract account_relationship, batch_mode, batch_status, batch_type, conference_slot, event_contacts,
Tim Otten [Wed, 17 May 2023 10:05:44 +0000 (03:05 -0700)]
Extract activity_contacts, label_format, pdf_format
Tim Otten [Wed, 17 May 2023 10:01:04 +0000 (03:01 -0700)]
Extract paper_size
Tim Otten [Wed, 17 May 2023 09:38:59 +0000 (02:38 -0700)]
Extract cg_extend_objects, engagement_index, mail_approval_status, system_extensions
Tim Otten [Wed, 17 May 2023 09:33:58 +0000 (02:33 -0700)]
Extract campaign_status, campaign_type, currencies_enabled, event_badge, note_privacy, civicrm_data.tpl
Tim Otten [Wed, 17 May 2023 09:10:02 +0000 (02:10 -0700)]
Extract addressee, contact_autocomplete_options, contact_reference_options, custom_data_type...
And also: email_greeting, mail_protocol, note_used_for, postal_greeting,
priority, redaction_rule, report_template, tag_used_for, visibility,
website_type
Tim Otten [Wed, 17 May 2023 09:00:10 +0000 (02:00 -0700)]
Extract case_status, case_type, from_email_address, mapping_type...
And also participant_listing phone_type, recur_frequency_units,
safe_file_extension, wysiwyg_editor
Tim Otten [Wed, 17 May 2023 08:47:09 +0000 (01:47 -0700)]
Extract activity_status, address_options, advanced_search_options, contact_edit_options, custom_search, group_type, user_dashboard_options
NOTE: ID change. Old insert had different orderings for OG and OV
Tim Otten [Wed, 17 May 2023 08:20:07 +0000 (01:20 -0700)]
Extract contact_smart_group_display, contact_view_options, contribution_status, event_type, participant_role, pcp_owner_notify, pcp_status,
Tim Otten [Wed, 17 May 2023 08:11:23 +0000 (01:11 -0700)]
Extract acl_role, accept_creditcard, payment_instrument
Tim Otten [Wed, 17 May 2023 08:04:30 +0000 (01:04 -0700)]
Extract individual_prefix, individual_suffix
Tim Otten [Wed, 17 May 2023 07:59:14 +0000 (00:59 -0700)]
Extract 'mobile_provider'
Tim Otten [Wed, 17 May 2023 07:56:30 +0000 (00:56 -0700)]
Extract instant_messenger_service OG
Tim Otten [Wed, 17 May 2023 07:34:12 +0000 (00:34 -0700)]
Extract gender OG
Tim Otten [Wed, 17 May 2023 06:42:25 +0000 (23:42 -0700)]
Change extension
Tim Otten [Wed, 17 May 2023 06:31:21 +0000 (23:31 -0700)]
WIP Continue splitting OG's into separate files
Tim Otten [Wed, 17 May 2023 06:27:23 +0000 (23:27 -0700)]
WIP Start splitting OG's into separate files
Tim Otten [Wed, 17 May 2023 06:09:24 +0000 (23:09 -0700)]
(WIP) sql/ - Convert OptionGroups from literal SQL to arrays/methods
Tim Otten [Wed, 17 May 2023 03:30:28 +0000 (20:30 -0700)]
(WIP) sql/ - Convert OptionGroups from literal SQL to arrays/methods
Tim Otten [Wed, 17 May 2023 10:34:44 +0000 (03:34 -0700)]
(REF) test_data_second_domain.mysql - Prepare to stop inheriting some vars
Tim Otten [Wed, 17 May 2023 10:35:42 +0000 (03:35 -0700)]
CRM_Utils_SQL - Allow escaping during pre-boot/testing
Tim Otten [Wed, 17 May 2023 02:10:59 +0000 (19:10 -0700)]
CRM_Utils_SQL - Add option `allowLiterals()` for building queries with literal SQL snippets
Tim Otten [Wed, 17 May 2023 02:04:14 +0000 (19:04 -0700)]
(REF) CRM_Utils_SQL - Extract common implementation of escapeString()
Eileen McNaughton [Wed, 17 May 2023 08:03:39 +0000 (20:03 +1200)]
Merge pull request #26241 from eileenmcnaughton/weight
Add some weights to menu link items
Eileen McNaughton [Wed, 17 May 2023 04:53:15 +0000 (16:53 +1200)]
Fix test to expect delete last
Also has some fixes to get away from undeclared property issues on
touched test & helpers
Eileen McNaughton [Wed, 17 May 2023 03:26:51 +0000 (15:26 +1200)]
Adjust weights so link order is inchanged
Eileen McNaughton [Tue, 16 May 2023 22:32:20 +0000 (10:32 +1200)]
Add some weights
Eileen McNaughton [Wed, 17 May 2023 04:58:38 +0000 (16:58 +1200)]
Merge pull request #26242 from civicrm/5.62
5.62
Seamus Lee [Wed, 17 May 2023 04:04:02 +0000 (14:04 +1000)]
Merge pull request #26193 from eileenmcnaughton/member
Fix code handling to pre-5.61 for membership block
colemanw [Wed, 17 May 2023 03:06:55 +0000 (23:06 -0400)]
Merge pull request #26240 from civicrm/5.62
5.62
Seamus Lee [Wed, 17 May 2023 01:01:26 +0000 (11:01 +1000)]
Merge pull request #26239 from totten/5.62-uninstall
setup - Fix uninstall on MySQL 8.0
colemanw [Wed, 17 May 2023 00:24:02 +0000 (20:24 -0400)]
Merge pull request #26233 from eileenmcnaughton/weight
Add weight to links spec
Tim Otten [Tue, 16 May 2023 23:56:18 +0000 (16:56 -0700)]
setup - Fix uninstall on MySQL 8.0
Overview
--------
Fix a bug with uninstalling or reinstalling via cv (`cv core:uninstall` or `cv core:install -f`) on MySQL 8.0.
Before
------
On MySQL 8.0, it fails - because all table-names appear as null.
It's looking for a result column named `table_name` but actually receives `TABLE_NAME`.
After
-----
Doesn't matter if the column is called `table_name` or `TABLE_NAME`.
Eileen McNaughton [Tue, 16 May 2023 23:25:20 +0000 (11:25 +1200)]
Merge pull request #26238 from eileenmcnaughton/part_public
Notice fix on edit Household
Eileen McNaughton [Tue, 16 May 2023 22:33:39 +0000 (10:33 +1200)]
Notice fix on edit Household
Eileen McNaughton [Tue, 16 May 2023 06:14:39 +0000 (18:14 +1200)]
Add weight to links spec
This allows a weight to be set & for it to alter the order.
It is a bit hard to know whether to add weights to existing ones as
it would be a lot to do all of them - but I did hear a specific request
(can't recall who from) to have Delete last to reduce mis-clicks
and with the View & Edit declared in the same place
I felt I should add them with low values for some sort of consistency
This would mess with people who have implemented weight in a hook - but
probably any change is low impact & an easy-ish fix
Note that I will update docs once agreed
colemanw [Tue, 16 May 2023 16:23:15 +0000 (12:23 -0400)]
Merge pull request #26235 from ufundo/getsearchtasks-qfkey-for-page-callback
dev/core#4295 SearchKit: check controller class for qfKey when loading legacy search actions for contributions
benjamin [Tue, 16 May 2023 15:02:31 +0000 (16:02 +0100)]
check route callback for generating qfkey
colemanw [Tue, 16 May 2023 15:04:01 +0000 (11:04 -0400)]
Merge pull request #26214 from larssandergreen/Improve-slow-download-from-SearchKit-results
Speed up Download Spreadsheet from SearchKit results
larssandergreen [Tue, 16 May 2023 14:18:53 +0000 (08:18 -0600)]
Improve-slow-download-from-SearchKit-results
Eileen McNaughton [Tue, 16 May 2023 06:49:00 +0000 (18:49 +1200)]
Merge pull request #26230 from colemanw/contributionUpgrade
Upgrader - Use generic (non-api4) code in upgrader
colemanw [Tue, 16 May 2023 01:30:32 +0000 (21:30 -0400)]
Upgrader - Use generic (non-api4) code in upgrader
This was causing issues with https://github.com/civicrm/civicrm-core/pull/26208
because the Contribution API is no longer available without enabling the
civi_contribute extension, which doesn't happen until a later upgrade step.
colemanw [Tue, 16 May 2023 02:11:54 +0000 (22:11 -0400)]
Merge pull request #26068 from colemanw/arrayOperators
dev/core#1321 - SearchKit - Limit operator list for array fields
Matthew Wire [Mon, 15 May 2023 19:48:37 +0000 (20:48 +0100)]
Merge pull request #26223 from eileenmcnaughton/participant_sent
Clarify sent & not sent variables
demeritcowboy [Mon, 15 May 2023 15:42:43 +0000 (11:42 -0400)]
Merge pull request #26225 from olayiwola-compucorp/addNameToContributor
Added Olayiwola Odunsi to contributor-key.yml
olayiwola-compucorp [Mon, 15 May 2023 14:51:19 +0000 (15:51 +0100)]
Added Olayiwola Odunsi to contributor-key.yml
demeritcowboy [Mon, 15 May 2023 14:40:24 +0000 (10:40 -0400)]
Merge pull request #26196 from seamuslee001/skip_vendor_old_files_non_civi_vendor
[REF] dev/core#1777 - Skip checking vendor provided orphaned files if the vendor directory is not within the CiviCRM root
demeritcowboy [Mon, 15 May 2023 14:38:23 +0000 (10:38 -0400)]
Merge pull request #26145 from olayiwola-compucorp/changeContributionDateLabel
dev/core#1403 - CRM/Contribute - Change "Date Received" to "Contribution Date"
Eileen McNaughton [Mon, 15 May 2023 13:20:59 +0000 (01:20 +1200)]
Clarify send & not sent variables
Its silly to pass an array around just to have it finally counted...
Matthew Wire [Mon, 15 May 2023 12:37:53 +0000 (13:37 +0100)]
Merge pull request #26221 from eileenmcnaughton/part_public
Make some internal functions protected
Matthew Wire [Mon, 15 May 2023 12:35:40 +0000 (13:35 +0100)]
Merge pull request #26220 from eileenmcnaughton/crazy_test_4
Fix Participant tests to use full form flow
olayiwola-compucorp [Mon, 15 May 2023 07:31:51 +0000 (08:31 +0100)]
dev/core#1403 - CRM/Contribute - Change "Date Received" to "Contribution Date"
Yashodha Chaku [Mon, 15 May 2023 06:39:36 +0000 (12:09 +0530)]
Merge pull request #26222 from eileenmcnaughton/extract
Remove unreachable validation
Eileen McNaughton [Mon, 15 May 2023 03:53:09 +0000 (15:53 +1200)]
Add getParticipantID to avoid non-php8-friendly path check
This particular fail is due to the path being empy in the test environment - But
it's wrong to check it as it is a crufty check for whether
the search task is being used
Eileen McNaughton [Mon, 15 May 2023 04:09:45 +0000 (16:09 +1200)]
Remove unreachable validation
Some time ago we fixed it such that only Pending and Completed statuses are in
the drop box for contribution_status_id. This fragment of code handles an edge case
that is no longer reachable - ie when the value is Failed and some other confusing stuff
is true
Eileen McNaughton [Mon, 15 May 2023 00:47:19 +0000 (12:47 +1200)]
Fix Participant tests to use full form flow
This doesn't get all of them but fixes a bunch
Eileen McNaughton [Sun, 14 May 2023 23:28:31 +0000 (11:28 +1200)]
Improve fromEmail address handling
We don't need to validate the from Email address in the postProcess as the
form submit validation expects it to be a supplied value.
Fixing this makes testing easier
Eileen McNaughton [Mon, 15 May 2023 00:42:38 +0000 (12:42 +1200)]
Improve test consistency on capitalisation
Eileen McNaughton [Mon, 15 May 2023 01:28:37 +0000 (13:28 +1200)]
Merge pull request #26217 from eileenmcnaughton/crazy_test
Minor cleanup on function
Eileen McNaughton [Mon, 15 May 2023 01:14:56 +0000 (13:14 +1200)]
Make some internal functions protected
I did a universe search to be sure but these 'belong' to the form
Eileen McNaughton [Sun, 14 May 2023 23:07:16 +0000 (11:07 +1200)]
Minor cleanup on function
The primary goal here was to check that it ALWAYS returns an array. It does,
so I added a type hint.
I also confirmed that
- it is not called from universe
- it is not called with no primaryParticipantID
- it is not called with excludeCancel set for false
so I did some deprecating.
Lastly there was code to handle there being no cancelStatus -
assigning a variable cancelID of 0 as a fallback. But, it
was not being used - so I fixed it to cast-to-int.
demeritcowboy [Sat, 13 May 2023 18:41:46 +0000 (14:41 -0400)]
Merge pull request #26213 from dontub/AbstractAction-drop-throws-phpdoc
AbstractAction: Drop `@throws` from phpdoc of `__construct()` because it's not thrown
Dominic Tubach [Sat, 13 May 2023 17:18:38 +0000 (19:18 +0200)]
AbstractAction: Drop `@throws` from phpdoc of `__construct()` because it's not thrown
Eileen McNaughton [Sat, 13 May 2023 03:14:17 +0000 (15:14 +1200)]
Merge pull request #26210 from civicrm/5.62
5.62
Matthew Wire [Fri, 12 May 2023 21:49:33 +0000 (22:49 +0100)]
Merge pull request #26205 from eileenmcnaughton/event_backoffice
Further separate register task from participant form
Matthew Wire [Fri, 12 May 2023 21:49:01 +0000 (22:49 +0100)]
Merge pull request #26209 from larssandergreen/Don't-show-send-confirmation-description-if-registering-multiple
Don't show send broken confirmation description if registering multiple contacts
larssandergreen [Fri, 12 May 2023 21:08:40 +0000 (15:08 -0600)]
Don't show send confirmation description if registering multiple
Matthew Wire [Fri, 12 May 2023 18:01:54 +0000 (19:01 +0100)]
Merge pull request #26206 from eileenmcnaughton/event_mail
Extract sendEmail function
Yashodha Chaku [Fri, 12 May 2023 12:22:35 +0000 (17:52 +0530)]
Merge pull request #26172 from eileenmcnaughton/562_import
dev/core#4227 Fix import to not blank birth_date etc on update
Yashodha Chaku [Fri, 12 May 2023 12:20:00 +0000 (17:50 +0530)]
Merge pull request #26204 from eileenmcnaughton/deprecated
Add missing deprecated tag
Tim Otten [Fri, 12 May 2023 07:54:26 +0000 (00:54 -0700)]
Merge pull request #26036 from colemanw/componentExtensions
dev/core#3961 Create stub extensions for all components
Eileen McNaughton [Fri, 12 May 2023 05:02:32 +0000 (17:02 +1200)]
Extract sendEmail function
This is a straight forward extraction
There is test cover
Eileen McNaughton [Fri, 12 May 2023 04:40:22 +0000 (16:40 +1200)]
Further separate register task from participant form
Coleman Watts [Thu, 27 Apr 2023 21:01:57 +0000 (17:01 -0400)]
Component Extensions - Fix upgrade and test errors
Coleman Watts [Thu, 27 Apr 2023 00:26:49 +0000 (20:26 -0400)]
Component/Extensions - Remove unnecessary cache clearing and prevent recursion
Ensure the cached settings are updated _before_ post_change hooks are called for settings.
All the cache clears being performed by on_change hooks were redundant with what happens when
extensions are enabled/disabled so I removed it.
Also moved the extension install hook to use postInstall which should be more stable, and
added checks in onToggleComponents to prevent recursion.
Coleman Watts [Tue, 11 Apr 2023 01:31:59 +0000 (21:31 -0400)]
Add test for component-extension lifecycle
Coleman Watts [Mon, 10 Apr 2023 16:01:32 +0000 (12:01 -0400)]
Sync enable/disable status of component extensions with core components
Eileen McNaughton [Thu, 11 May 2023 23:44:08 +0000 (11:44 +1200)]
Remove missing deprecated tag
Eileen McNaughton [Thu, 11 May 2023 23:36:02 +0000 (11:36 +1200)]
Merge pull request #26203 from eileenmcnaughton/reg_vars
Remove unused constants
Eileen McNaughton [Thu, 11 May 2023 22:55:29 +0000 (10:55 +1200)]
Remove unused constant
Seamus Lee [Thu, 11 May 2023 21:33:53 +0000 (07:33 +1000)]
Merge pull request #26202 from pradpnayak/extcleanup
flexmailer remove cruft code
demeritcowboy [Thu, 11 May 2023 20:30:25 +0000 (16:30 -0400)]
Merge pull request #26201 from civicrm/5.62
5.62
Pradeep Nayak [Thu, 11 May 2023 18:11:34 +0000 (19:11 +0100)]
flexmailer remove cruft code
demeritcowboy [Thu, 11 May 2023 18:11:29 +0000 (14:11 -0400)]
Merge pull request #26199 from pradpnayak/fatalerror
Regression: Fatal error when importing membership
Pradeep Nayak [Thu, 11 May 2023 17:22:58 +0000 (18:22 +0100)]
Fixed fatal error when importing membership
Coleman Watts [Sun, 9 Apr 2023 03:09:12 +0000 (23:09 -0400)]
Add stub extensions for all components
Eileen McNaughton [Thu, 11 May 2023 06:34:34 +0000 (18:34 +1200)]
Merge pull request #26195 from totten/master-esm
dev/core#4279 - Add support for ECMAScript Modules (ESM, part 1)
Eileen McNaughton [Thu, 11 May 2023 03:56:52 +0000 (15:56 +1200)]
Fix capitalization in comments
Eileen McNaughton [Thu, 11 May 2023 02:45:15 +0000 (14:45 +1200)]
add more esms