Tim Otten [Wed, 4 Oct 2023 03:42:57 +0000 (20:42 -0700)]
SavedSearchMappingTest - Fix compat with php73
Eileen McNaughton [Tue, 3 Oct 2023 09:44:44 +0000 (22:44 +1300)]
Merge pull request #27710 from totten/5.66-links-weights
hook_civicrm_links - Add more weights
Tim Otten [Tue, 19 Sep 2023 05:59:34 +0000 (22:59 -0700)]
hook_civicrm_links - Add more weights:
- contribution.edit.action
- file.manage.delete
- financialItem.batch.row
- Payment.edit.action
colemanw [Fri, 29 Sep 2023 11:59:01 +0000 (07:59 -0400)]
Merge pull request #27671 from eileenmcnaughton/back_tick
Remove backticks around tokens
Eileen McNaughton [Fri, 29 Sep 2023 05:14:28 +0000 (18:14 +1300)]
Remove backticks around tokens
Seamus Lee [Wed, 27 Sep 2023 23:19:48 +0000 (09:19 +1000)]
Merge pull request #27615 from colemanw/afformFixJoins
Afform - ensure prefill entities are populated correctly
colemanw [Tue, 26 Sep 2023 11:26:50 +0000 (07:26 -0400)]
Merge pull request #27639 from mlutfy/core4623
dev/core#4623 Standalone: fix currentPath on AngularJS pages (ex: New Mailing)
Tim Otten [Tue, 26 Sep 2023 05:39:11 +0000 (22:39 -0700)]
Merge pull request #27626 from colemanw/mailService
Fix dev/core#4566 by ensuring groupNames are fetched
Mathieu Lu [Tue, 26 Sep 2023 01:09:21 +0000 (21:09 -0400)]
dev/core#4623 Standalone: fix currentPath on AngularJS pages (ex: New Mailing)
demeritcowboy [Mon, 25 Sep 2023 15:32:56 +0000 (11:32 -0400)]
Merge pull request #27629 from colemanw/fixSearchById
Autocomplete - Fix search-by-id for entities without a numeric id
colemanw [Mon, 25 Sep 2023 14:02:21 +0000 (10:02 -0400)]
Autocomplete - Fix search-by-id for entities without a numeric id
Fixes dev/core#4560 and the intermittent failure of AfformGetTest.testAfformAutocomplete
colemanw [Mon, 25 Sep 2023 02:17:23 +0000 (22:17 -0400)]
Fix dev/core#4566 by ensuring groupNames are fetched
The problem was that EditUnsubGroupCtrl needed CRM.crmMailing.groupNames to be fetched,
but wasn't doing anything about it. Instead it was passively waiting around for someone
else to call for them to be loaded. The only place doing this was ViewRecipCtrl, and not consistently.
It was working in core but not in Mosaico.
I solved this by moving the loader functions to a service so they could be called from both places.
colemanw [Sun, 24 Sep 2023 19:58:28 +0000 (15:58 -0400)]
Merge pull request #27591 from eileenmcnaughton/joomla
Add dummy file in place of removed file for Joomla! installers
colemanw [Sun, 24 Sep 2023 10:12:16 +0000 (06:12 -0400)]
Afform - ensure prefill entities are populated correctly
Eileen McNaughton [Sat, 23 Sep 2023 02:42:32 +0000 (14:42 +1200)]
Add dummy file in place of removed file for Joomla! installers
Eileen McNaughton [Fri, 22 Sep 2023 21:51:09 +0000 (09:51 +1200)]
Merge pull request #27574 from demeritcowboy/sixhundred
[NFC] Partial backport of
0c1d533c to avoid random test fails
Eileen McNaughton [Fri, 22 Sep 2023 21:50:37 +0000 (09:50 +1200)]
Merge pull request #27573 from alifrumin/5.66rn
[NFC] 5.66 release notes
demeritcowboy [Fri, 22 Sep 2023 17:41:41 +0000 (13:41 -0400)]
avoid random test fails
Alice Frumin [Tue, 19 Sep 2023 15:26:57 +0000 (11:26 -0400)]
[NFC] 5.66 release notes
demeritcowboy [Fri, 22 Sep 2023 12:26:03 +0000 (08:26 -0400)]
Merge pull request #27566 from eileenmcnaughton/price
Fix weight values on PriceSet page
Eileen McNaughton [Fri, 22 Sep 2023 07:34:26 +0000 (19:34 +1200)]
Fix weight values on PriceSet page
Seamus Lee [Thu, 21 Sep 2023 22:29:00 +0000 (08:29 +1000)]
Merge pull request #27550 from seamuslee001/ca_config_update
Update CAConfig to use 23.07 version
Seamus Lee [Thu, 21 Sep 2023 22:03:14 +0000 (08:03 +1000)]
Update CAConfig to use 23.07 version
demeritcowboy [Thu, 21 Sep 2023 12:55:20 +0000 (08:55 -0400)]
Merge pull request #27446 from demeritcowboy/upgrade-multi-default-566
Add missing upgrade script for multilingual defaults
demeritcowboy [Thu, 21 Sep 2023 12:53:57 +0000 (08:53 -0400)]
Merge pull request #27544 from eileenmcnaughton/badge56
Add weights on badge layout links
Eileen McNaughton [Thu, 21 Sep 2023 09:49:25 +0000 (21:49 +1200)]
Add weights on badge layout links
Eileen McNaughton [Wed, 20 Sep 2023 22:15:31 +0000 (10:15 +1200)]
Merge pull request #27409 from seamuslee001/5.66
[REF] Fix bug caused by recent ACL changes where combination of edit …
Eileen McNaughton [Wed, 20 Sep 2023 04:46:00 +0000 (16:46 +1200)]
Merge pull request #27528 from demeritcowboy/weight-again
Fix weights again on contribution page settings dropdown
demeritcowboy [Wed, 20 Sep 2023 03:13:21 +0000 (23:13 -0400)]
fix weights again
colemanw [Tue, 19 Sep 2023 15:37:28 +0000 (11:37 -0400)]
Merge pull request #27518 from demeritcowboy/bread
dev/core#4605 - Add yet another guard against failed upgrades
demeritcowboy [Tue, 19 Sep 2023 13:00:11 +0000 (09:00 -0400)]
guard during upgrades
Tim Otten [Tue, 19 Sep 2023 00:30:28 +0000 (17:30 -0700)]
Merge pull request #27475 from totten/5.66-comp-status
Status Check - Ensure that components are enabled
Eileen McNaughton [Tue, 19 Sep 2023 00:23:47 +0000 (12:23 +1200)]
Merge pull request #27494 from agh1/5.66.0-releasenotes-initial
5.66.0 release notes initial run
Eileen McNaughton [Tue, 19 Sep 2023 00:06:37 +0000 (12:06 +1200)]
Merge pull request #27501 from eileenmcnaughton/weight
Add a couple more weights - legacy searches
Eileen McNaughton [Mon, 18 Sep 2023 23:30:12 +0000 (11:30 +1200)]
Add a couple more weights - legacy searches
Eileen McNaughton [Mon, 18 Sep 2023 23:09:45 +0000 (11:09 +1200)]
Merge pull request #27492 from pradpnayak/entitybatch
make grouptree protected so that it can be accessed via hook
colemanw [Mon, 18 Sep 2023 22:35:22 +0000 (18:35 -0400)]
Merge pull request #27481 from totten/5.66-upg-comp-timing
(dev/core#4521) Upgrader - Enable component-extensions before system-flush
Pradeep Nayak [Mon, 18 Sep 2023 15:05:48 +0000 (16:05 +0100)]
make grouptree protected so that it can be accessed via hook
colemanw [Mon, 18 Sep 2023 19:55:19 +0000 (15:55 -0400)]
Merge pull request #27480 from eileenmcnaughton/templates
Add some missing weights
John Kingsnorth [Mon, 18 Sep 2023 14:55:49 +0000 (15:55 +0100)]
Exclude inactive groups on recipient lists
Andie Hunt [Mon, 18 Sep 2023 19:12:20 +0000 (15:12 -0400)]
5.66.0 release notes: added boilerplate
Andie Hunt [Mon, 18 Sep 2023 19:08:53 +0000 (15:08 -0400)]
5.66.0 release notes: raw from script
Eileen McNaughton [Mon, 18 Sep 2023 05:06:22 +0000 (17:06 +1200)]
Add some missing weights
Tim Otten [Mon, 18 Sep 2023 04:13:41 +0000 (21:13 -0700)]
Upgrader - 5.63 upgrade should use simple extension installation
Tim Otten [Mon, 18 Sep 2023 04:13:20 +0000 (21:13 -0700)]
Upgrader - Multiple fixes for new enableSimpleExtension()
Tim Otten [Mon, 18 Sep 2023 01:41:31 +0000 (18:41 -0700)]
Upgrader - Implement addSimpleExtensionTask(). Update docblocks.
colemanw [Fri, 8 Sep 2023 12:59:14 +0000 (08:59 -0400)]
Add enableSimpleExtension upgrade function
Tim Otten [Sun, 17 Sep 2023 23:42:03 +0000 (16:42 -0700)]
Status Check - Ensure that components are enabled
demeritcowboy [Sun, 17 Sep 2023 18:12:55 +0000 (14:12 -0400)]
Merge pull request #27464 from demeritcowboy/oh-snap
Upgrade - don't crash on earlier versions of mariadb
demeritcowboy [Sun, 17 Sep 2023 17:55:03 +0000 (13:55 -0400)]
add comments
demeritcowboy [Sun, 17 Sep 2023 17:27:00 +0000 (13:27 -0400)]
don't crash on earlier versions
demeritcowboy [Fri, 15 Sep 2023 12:39:17 +0000 (08:39 -0400)]
fix task description
demeritcowboy [Fri, 15 Sep 2023 12:38:56 +0000 (08:38 -0400)]
upgrade script for required multilingual fields
colemanw [Sat, 16 Sep 2023 01:23:26 +0000 (21:23 -0400)]
Merge pull request #27453 from colemanw/extComponentCheck
Add system check for missing component extensions
colemanw [Fri, 15 Sep 2023 22:17:33 +0000 (18:17 -0400)]
Add system check for missing component extensions
demeritcowboy [Fri, 15 Sep 2023 23:07:31 +0000 (19:07 -0400)]
Merge pull request #27452 from eileenmcnaughton/weight
Add weights on profile fields page (notices
demeritcowboy [Fri, 15 Sep 2023 23:06:52 +0000 (19:06 -0400)]
Merge pull request #27451 from eileenmcnaughton/email_comments
Add code comments re the cleanup I didn't do
demeritcowboy [Fri, 15 Sep 2023 22:41:54 +0000 (18:41 -0400)]
Merge pull request #27450 from demeritcowboy/weight566
backport of 27448
Eileen McNaughton [Fri, 15 Sep 2023 22:14:44 +0000 (10:14 +1200)]
Add weights on profile fields page
ie https://dmaster.localhost:32353/civicrm/admin/uf/group/field?reset=1&action=browse&gid=1
Eileen McNaughton [Fri, 15 Sep 2023 22:07:33 +0000 (10:07 +1200)]
Add code comments re the cleanup I didn't do
I want the code to be stable in 5.66 for a few releases, absent any bugs so
commenting the further cleanup for 'one day'
demeritcowboy [Fri, 15 Sep 2023 13:39:17 +0000 (09:39 -0400)]
fix order
colemanw [Fri, 15 Sep 2023 12:09:31 +0000 (08:09 -0400)]
Merge pull request #27443 from eileenmcnaughton/part_
Fix variable leakage in online event receipt
demeritcowboy [Fri, 15 Sep 2023 11:49:07 +0000 (07:49 -0400)]
Merge pull request #27428 from eileenmcnaughton/custom_weight
Fix missing weights on Custom data screen (notices)
Eileen McNaughton [Fri, 15 Sep 2023 05:07:42 +0000 (17:07 +1200)]
Fix variable leakage in online event receipt
Eileen McNaughton [Wed, 6 Sep 2023 20:40:31 +0000 (08:40 +1200)]
Move scenario set up to trait
colemanw [Fri, 15 Sep 2023 02:46:05 +0000 (22:46 -0400)]
Merge pull request #27432 from eileenmcnaughton/profile_weight
Add weights on profile links (remove notices)
Eileen McNaughton [Fri, 15 Sep 2023 01:56:13 +0000 (13:56 +1200)]
Add weights on profile links (remove notices)
Eileen McNaughton [Thu, 14 Sep 2023 23:54:44 +0000 (11:54 +1200)]
Fix missing weights on Custom data screen (notices)
Eileen McNaughton [Wed, 13 Sep 2023 03:18:57 +0000 (15:18 +1200)]
Merge pull request #27408 from eileenmcnaughton/type_bounce
Fix mistake in just-merged email processor code
Eileen McNaughton [Wed, 13 Sep 2023 00:22:07 +0000 (12:22 +1200)]
Fix mistake in just-merged email processor code
BounceString was compiled in order to be used.... but it got rebased out
Seamus Lee [Wed, 13 Sep 2023 00:20:56 +0000 (10:20 +1000)]
[REF] Fix bug caused by recent ACL changes where combination of edit all contacts and a specific acl on a group broke the edit all contacts rule and add unit test
colemanw [Tue, 12 Sep 2023 22:32:18 +0000 (18:32 -0400)]
Merge pull request #27404 from totten/5.66-snapshot-mariadb
Upgrader - Skip snapshots on some MariaDB env's (roughly: 10.6.0-10.6.5)
Tim Otten [Tue, 12 Sep 2023 07:43:31 +0000 (00:43 -0700)]
Upgrader - Skip snapshots on some MariaDB env's (roughly: 10.6.0-10.6.5)
Eileen McNaughton [Tue, 12 Sep 2023 03:15:37 +0000 (15:15 +1200)]
Merge pull request #27399 from colemanw/fixContactJoin
APIv4: Implicit joins for email_primary, etc cause error
colemanw [Tue, 12 Sep 2023 02:32:06 +0000 (22:32 -0400)]
Fix dev/core#4562 - APIv4: Implicit joins for email_primary, etc cause error
Eileen McNaughton [Tue, 12 Sep 2023 02:14:53 +0000 (14:14 +1200)]
Merge pull request #27395 from eileenmcnaughton/weight
Fix weight notices on ActivityType (option values) pages
Eileen McNaughton [Tue, 12 Sep 2023 02:12:40 +0000 (14:12 +1200)]
Merge pull request #27394 from eileenmcnaughton/zet
Revert "[REF] Update Zetacomponents/mail to be 1.9.5 to fix email validation handling"
Eileen McNaughton [Tue, 12 Sep 2023 01:45:35 +0000 (13:45 +1200)]
Fix weight notices on ActivityType (option values) pages
colemanw [Tue, 12 Sep 2023 01:16:37 +0000 (21:16 -0400)]
Merge pull request #27356 from eileenmcnaughton/body
dev/core#2800 Fix bounce processing to handle verp emails
Eileen McNaughton [Tue, 12 Sep 2023 01:10:28 +0000 (13:10 +1200)]
Revert "[REF] Update Zetacomponents/mail to be 1.9.5 to fix email validation handling"
This reverts commit
020a1178ac869e64691c4e5fd49ee09f01d8f194.
Eileen McNaughton [Mon, 11 Sep 2023 22:13:10 +0000 (10:13 +1200)]
Add detail about bounce to activity
Note adding fetch_activities to the test exposed a mysql error so I had
to add handling there
Eileen McNaughton [Mon, 11 Sep 2023 20:33:33 +0000 (08:33 +1200)]
Use bounce activity type, if exists
We can look at adding in upgrade script in later version after bedding in
Eileen McNaughton [Thu, 7 Sep 2023 08:47:59 +0000 (20:47 +1200)]
Move handling of empty from obscure function to main email handler class
I wondered if the zeta components update would make this fix obsolete but adding
a test says not...
So this locks in the fix on
https://issues.civicrm.org/jira/browse/CRM-19215
Eileen McNaughton [Thu, 7 Sep 2023 02:17:05 +0000 (14:17 +1200)]
Move from handling to processor, test
Eileen McNaughton [Thu, 7 Sep 2023 08:08:17 +0000 (20:08 +1200)]
dev/core#2800 Fix bounce processing to handle verp emails
This fixes 2 issues when combining bounce processing with verp emails
1) the emails being processed are being matched to email they come from -
ie the verp email. Hence the created activities are not linked to the
actual contact and instead create endless variants of the sender.
This happens with both the job.process_activities job and with
job.fetch_bounces with is_create_activities = TRUE.
This fix adapts the handling to identify verp emails (using existing regex)
and look up the contact ID from the mailing_event_queue. This is
used as the source (I didn't add a target or assignee at this stage cos
I wasn't sure if that was just data-cruft or useful stuff - but it would
be retrieved from the mailing)
2) this second one is a doozy & probably only showed up in tests because the
tests mostly cover obscure email formats. The create activities code does
a call to get the body and attachments using a function that looks like it
came from a tutorial on how to best use ezcmail. It seems to parse
all the email variants and attachments and, importantly, moves those attachments
to the civicrm files as part of creating the activity.
The code used to getBody() for bounces looks like it was ... written by us.
It does a subset of the processing in earlier call to get body and in
many of our test cases falls back on a blunt generateBody(). This call parses the
email, including the attachments, which are no longer there cos they got moved....
so it fatals.
I dug into the 2 functions and I feel pretty sure the bounce one doesn't add any
additional value but DOES have less capability than the other. So I removed that code,
Unfortunately the person received weird email from Exchange 2003 did not log
the headers https://issues.civicrm.org/jira/browse/CRM-9361 - but even if the
preferred version of the function doesn't parse that there is default text so
it won't fail & it seems like the risk of having a bit less info about an (untested)
obscure email bounce body is not that probematic
Seamus Lee [Sun, 10 Sep 2023 20:54:40 +0000 (06:54 +1000)]
Merge pull request #27384 from eileenmcnaughton/566test
Add email helper to new form test helper
colemanw [Sun, 10 Sep 2023 15:04:38 +0000 (11:04 -0400)]
Merge pull request #27383 from larssandergreen/Fix-SearchDisplay-totals
dev/core#4559 Don't include test, template, deleted entities in SearchDisplay totals
colemanw [Sun, 10 Sep 2023 14:55:19 +0000 (10:55 -0400)]
Merge pull request #27381 from sebalis/dev_core_4542_sebalis
dev/core#4542 Fix priority handling in ACLs when dealing with objects…
Eileen McNaughton [Sat, 9 Sep 2023 23:39:16 +0000 (11:39 +1200)]
Add email helper to new form test helper
larssandergreen [Sun, 10 Sep 2023 00:48:39 +0000 (18:48 -0600)]
Don't include test, template, deleted entities in searchdisplay totals
sebalis [Sat, 9 Sep 2023 01:19:13 +0000 (03:19 +0200)]
add change to ACLPermissionTest.php from original pull request
Co-authored-by: Seamus Lee <seamuslee001@gmail.com>
sebalis [Sat, 9 Sep 2023 00:56:50 +0000 (02:56 +0200)]
dev/core#4542 Fix priority handling in ACLs when dealing with objects other than contacts, and remove code duplication
Co-authored-by: Seamus Lee <seamuslee001@gmail.com>
Eileen McNaughton [Fri, 8 Sep 2023 04:02:59 +0000 (16:02 +1200)]
Merge pull request #27372 from larssandergreen/Expose_fee_label_for_event_tokens
Expose fee_label for event tokens
larssandergreen [Fri, 8 Sep 2023 03:26:50 +0000 (21:26 -0600)]
Expose fee_lable for event tokens
colemanw [Fri, 8 Sep 2023 01:09:54 +0000 (21:09 -0400)]
Merge pull request #27367 from eileenmcnaughton/566
Fix notice on unpaid event
Seamus Lee [Thu, 7 Sep 2023 23:20:39 +0000 (09:20 +1000)]
Merge pull request #27368 from seamuslee001/5.66
[REF] Ensure that any NULL values in the title field are fixed prior …
Eileen McNaughton [Thu, 7 Sep 2023 21:50:57 +0000 (09:50 +1200)]
Fix notice on unpaid event
Seamus Lee [Thu, 7 Sep 2023 22:32:07 +0000 (08:32 +1000)]
[REF] Ensure that any NULL values in the title field are fixed prior to changing the column
colemanw [Thu, 7 Sep 2023 21:57:18 +0000 (17:57 -0400)]
Merge pull request #27128 from christianwach/lang
Support retention of locale on links
Seamus Lee [Thu, 7 Sep 2023 21:35:08 +0000 (07:35 +1000)]
Merge pull request #27364 from seamuslee001/5.66
FiveSixtyFour: disable i18n rewrite on cancel_URL