civicrm-core.git
3 years agoSwitch membership BAO to use non-deprecated cached functions to get membershipType...
Matthew Wire [Mon, 7 Sep 2020 15:30:31 +0000 (16:30 +0100)]
Switch membership BAO to use non-deprecated cached functions to get membershipType details

3 years agoMerge pull request #18427 from mattwire/membershipbackendcached
Matthew Wire [Fri, 18 Sep 2020 13:51:56 +0000 (14:51 +0100)]
Merge pull request #18427 from mattwire/membershipbackendcached

Switch backend membership form to use non-deprecated/cached functions to get membership types

3 years agoMerge pull request #18485 from eileenmcnaughton/ref2
colemanw [Fri, 18 Sep 2020 11:50:30 +0000 (07:50 -0400)]
Merge pull request #18485 from eileenmcnaughton/ref2

dev/core#2043 remove pass-by-reference

3 years agoMerge pull request #18505 from seamuslee001/afform_container_fix
Eileen McNaughton [Fri, 18 Sep 2020 08:45:15 +0000 (20:45 +1200)]
Merge pull request #18505 from seamuslee001/afform_container_fix

[REF] Fix visibility of afform_scanner container service for Symfony …

3 years agoSeparate export into separate classe to allow unravelling of component handling
eileen [Fri, 18 Sep 2020 03:51:38 +0000 (15:51 +1200)]
Separate export into separate classe to allow unravelling of component handling

3 years agoMerge pull request #18511 from totten/master-aff-test
Seamus Lee [Fri, 18 Sep 2020 05:11:46 +0000 (15:11 +1000)]
Merge pull request #18511 from totten/master-aff-test

Afform Tests - Fix extension tests when run via `civi-test-run`

3 years ago[REF] Extract the code to determine the DAO name into a functions
eileen [Fri, 18 Sep 2020 04:11:50 +0000 (16:11 +1200)]
[REF] Extract the code to determine the DAO name into a functions

Note per https://github.com/civicrm/civicrm-core/pull/18512 my intent is actually to land on class inheritance
rather than these switches but by starting to functionise them it becomes easier to start to determine what the functions
should be

3 years ago[REF] Fix visibility of afform_scanner container service for Symfony 3 and 4
Seamus Lee [Thu, 17 Sep 2020 23:49:54 +0000 (09:49 +1000)]
[REF] Fix visibility of afform_scanner container service for Symfony 3 and 4

3 years agoMerge pull request #18506 from totten/master-bundle-array
Seamus Lee [Fri, 18 Sep 2020 02:36:07 +0000 (12:36 +1000)]
Merge pull request #18506 from totten/master-bundle-array

CRM_Core_Resources::addBundle() - Fix handling of array inputs

3 years agoMerge pull request #18507 from eileenmcnaughton/test_fix
Seamus Lee [Fri, 18 Sep 2020 02:32:20 +0000 (12:32 +1000)]
Merge pull request #18507 from eileenmcnaughton/test_fix

Test fix - use valid membership type

3 years agoafform_clear() - Fix error when running on non-cached container
Tim Otten [Fri, 18 Sep 2020 02:14:06 +0000 (19:14 -0700)]
afform_clear() - Fix error when running on non-cached container

After switching the tests from an effective policy of `CIVICRM_CONTAINER_CACHE=auto`
to an effective policy of `CIVICRM_CONTAINER_CACHE=never`, this started to fail:

```
1) api_v4_AfformTest::testGetUpdateRevert with data set #0 ('mockPage', array('', '', 'civicrm/mock-page', 'access Foobar'))
Symfony\Component\DependencyInjection\Exception\BadMethodCallException: Setting service "angular" for an unknown or non-synthetic service definition on a compiled container is not allowed.

/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/vendor/symfony/dependency-injection/ContainerBuilder.php:532
/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/ext/afform/core/afform.php:520
/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/ext/afform/core/Civi/Api4/Afform.php:99
/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/BasicBatchAction.php:88
/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/BasicBatchAction.php:68
/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Provider/ActionObjectProvider.php:68
/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php:150
/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php:238
/home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/ext/afform/mock/tests/phpunit/api/v4/AfformTest.php:53
/home/me/bknix/extern/phpunit6/phpunit6.phar:570
```

3 years agoContainer - Disable caching in as many unit-tests as we can
Tim Otten [Fri, 18 Sep 2020 02:11:19 +0000 (19:11 -0700)]
Container - Disable caching in as many unit-tests as we can

3 years agoMerge pull request #18503 from colemanw/removeHookCiviCRMTabs
Eileen McNaughton [Fri, 18 Sep 2020 01:16:53 +0000 (13:16 +1200)]
Merge pull request #18503 from colemanw/removeHookCiviCRMTabs

Remove long-deprecated hook_civicrm_tabs

3 years agoMerge pull request #18488 from eileenmcnaughton/loc_block
colemanw [Fri, 18 Sep 2020 00:58:54 +0000 (20:58 -0400)]
Merge pull request #18488 from eileenmcnaughton/loc_block

dev/core#1973 Fix Email & Phone storage issues in event location

3 years agoTest fix - use valid membership type
eileen [Fri, 18 Sep 2020 00:29:06 +0000 (12:29 +1200)]
Test fix - use valid membership type

Addresses cause of https://github.com/civicrm/civicrm-core/pull/18427 fail

3 years agoCRM_Core_Resources::addBundle() - Fix handling of array inputs
Tim Otten [Fri, 18 Sep 2020 00:26:38 +0000 (17:26 -0700)]
CRM_Core_Resources::addBundle() - Fix handling of array inputs

(This fixes a small bug in a new function added during this release -- part of #18247.)

The signature of `addBundle()` optionally accepts an array/iterable -- if
given, then it should add all the items from the array. For example:

```php
Civi::resources()->addBundle(['foo', 'bar']);
```

Before
------

It adds `foo` but then bails out on `bar`.

After
-----

It adds both `foo` and `bar`.

3 years agoMerge pull request #18501 from eileenmcnaughton/acltest
Seamus Lee [Thu, 17 Sep 2020 21:38:55 +0000 (07:38 +1000)]
Merge pull request #18501 from eileenmcnaughton/acltest

dev/core#2039 Fix test to use set up method with more data integrity

3 years agodev/core#1973 Fix Email & Phone storage issues in event location
eileen [Wed, 16 Sep 2020 03:45:47 +0000 (15:45 +1200)]
dev/core#1973 Fix Email & Phone storage issues in event location

3 years agoMerge pull request #18492 from colemanw/moveDaoFunctionsToBaseClass
Eileen McNaughton [Thu, 17 Sep 2020 20:26:30 +0000 (08:26 +1200)]
Merge pull request #18492 from colemanw/moveDaoFunctionsToBaseClass

Ensure DAO base class contains functions to be removed from generated files

3 years agoMerge pull request #18490 from eileenmcnaughton/emailadd
colemanw [Thu, 17 Sep 2020 20:21:39 +0000 (16:21 -0400)]
Merge pull request #18490 from eileenmcnaughton/emailadd

Remove deprecated code lines

3 years agoRemove deprecated hook_civicrm_tabs
Coleman Watts [Thu, 17 Sep 2020 18:40:38 +0000 (14:40 -0400)]
Remove deprecated hook_civicrm_tabs

This hook has been deprecated for 5 years. Time to remove it.

3 years agonames shouldn't be squished together in activity details field
demeritcowboy [Thu, 17 Sep 2020 19:09:42 +0000 (15:09 -0400)]
names shouldn't be squished together in activity details field

3 years agoMerge pull request #18498 from eileenmcnaughton/opennp
colemanw [Thu, 17 Sep 2020 11:27:45 +0000 (07:27 -0400)]
Merge pull request #18498 from eileenmcnaughton/opennp

dev/core#2039 Fix OpenID::add to ensure is_primary is set

3 years agodev/core#2039 Fix test to use set up method with more data integrity
eileen [Thu, 17 Sep 2020 04:22:20 +0000 (16:22 +1200)]
dev/core#2039 Fix test to use set up method with more data integrity

Using the api rather than CRM_Core_DAO::createTestObject to create the phone ensures it is created with is_primary.

We might need to fix CRM_Core_DAO::createTestObject but for this case simply using the api suffices

3 years ago[REF] Minor code extraction
eileen [Thu, 17 Sep 2020 03:01:21 +0000 (15:01 +1200)]
[REF] Minor code extraction

This extracts code to the MergeHandler class for deduping locations. We have a LOT of
test cover here with all the scenarios in jobTest::testBatchMergesAddresses & other functions
using that same data provider.

The goal is to refactor the code onto the MergeHandler class, with a view to
doing less variable passing & more property-using to help clean it up -
in this case it's already visible that 2 variables can be derived in the mergeHandler:

3 years agodev/core#2039 Fix OpenID::add to ensure is_primary is set
eileen [Thu, 17 Sep 2020 00:41:59 +0000 (12:41 +1200)]
dev/core#2039 Fix OpenID::add to ensure is_primary is set

In my efforts to determine the the non-performant line of code that makes sure IM is set is
not required I edited tests to track down when is_primary is not correct & determined it
is missing from the add function - same as https://github.com/civicrm/civicrm-core/pull/18489 for IM

3 years agoMerge pull request #18489 from eileenmcnaughton/im
Seamus Lee [Thu, 17 Sep 2020 03:42:07 +0000 (13:42 +1000)]
Merge pull request #18489 from eileenmcnaughton/im

dev/core#2039 Add check to ensure all have a primary address, fix identified but in IM.add

3 years agocomposer.lock - Update composer-compile-plugin
Tim Otten [Mon, 14 Sep 2020 10:38:06 +0000 (03:38 -0700)]
composer.lock - Update composer-compile-plugin

3 years agocomposer.json - Move greenwich-specific rules into the greenwich folder
Tim Otten [Mon, 14 Sep 2020 10:37:05 +0000 (03:37 -0700)]
composer.json - Move greenwich-specific rules into the greenwich folder

3 years agocomposer.json - Update composer-compile-plugin
Tim Otten [Mon, 14 Sep 2020 10:36:12 +0000 (03:36 -0700)]
composer.json - Update composer-compile-plugin

3 years agogreenwich - Add to civicrm_generated.mysql
Tim Otten [Mon, 14 Sep 2020 07:40:44 +0000 (00:40 -0700)]
greenwich - Add to civicrm_generated.mysql

3 years agogreenwich - Activate during upgrade
Tim Otten [Mon, 14 Sep 2020 07:34:35 +0000 (00:34 -0700)]
greenwich - Activate during upgrade

3 years agogreenwich - Activate on new builds
Tim Otten [Mon, 14 Sep 2020 07:31:41 +0000 (00:31 -0700)]
greenwich - Activate on new builds

3 years agocomposer.lock - Update for Greenwich/SCSS libraries and compilation task
Tim Otten [Mon, 14 Sep 2020 07:27:41 +0000 (00:27 -0700)]
composer.lock - Update for Greenwich/SCSS libraries and compilation task

3 years agogreenwich - Make a more useful readme
Tim Otten [Mon, 14 Sep 2020 07:24:43 +0000 (00:24 -0700)]
greenwich - Make a more useful readme

3 years agogreenwich - Quick/weak stab at slightly-less glaringly-mismatched but…
Tim Otten [Mon, 14 Sep 2020 07:23:11 +0000 (00:23 -0700)]
greenwich - Quick/weak stab at slightly-less glaringly-mismatched but…

3 years agogreenwich - Declare theme. Use the new bootstrap3.css
Tim Otten [Mon, 14 Sep 2020 07:21:38 +0000 (00:21 -0700)]
greenwich - Declare theme. Use the new bootstrap3.css

3 years agogreenwich - Define compilation task
Tim Otten [Mon, 14 Sep 2020 07:17:55 +0000 (00:17 -0700)]
greenwich - Define compilation task

3 years agocomposer.json - Add scssphp, php-autoprefixer, and compile-plugin
Tim Otten [Mon, 14 Sep 2020 07:14:58 +0000 (00:14 -0700)]
composer.json - Add scssphp, php-autoprefixer, and compile-plugin

3 years agogreenwich - Download bootstrap-sass
Tim Otten [Fri, 11 Sep 2020 21:51:02 +0000 (14:51 -0700)]
greenwich - Download bootstrap-sass

3 years agogreenwich - Remove unnecessary hook stubs
Tim Otten [Wed, 22 Jul 2020 08:22:58 +0000 (01:22 -0700)]
greenwich - Remove unnecessary hook stubs

3 years agoImport skeletal "greenwich"
Tim Otten [Wed, 22 Jul 2020 01:21:07 +0000 (18:21 -0700)]
Import skeletal "greenwich"

3 years agoMerge pull request #18497 from eileenmcnaughton/open_primary
Seamus Lee [Thu, 17 Sep 2020 01:43:04 +0000 (11:43 +1000)]
Merge pull request #18497 from eileenmcnaughton/open_primary

dev/core#2039 [NFC] Code cleanup in test class

3 years agoMerge pull request #18496 from eileenmcnaughton/nfc
Eileen McNaughton [Thu, 17 Sep 2020 01:29:30 +0000 (13:29 +1200)]
Merge pull request #18496 from eileenmcnaughton/nfc

dev/core#2039 [NFC] Minor cleanup in tests

3 years agoMerge pull request #18495 from eileenmcnaughton/email_add
Eileen McNaughton [Thu, 17 Sep 2020 01:15:59 +0000 (13:15 +1200)]
Merge pull request #18495 from eileenmcnaughton/email_add

dev/core#2046 Rationalise add vs create on email BAO

3 years ago[NFC] Code cleanup in test class
eileen [Thu, 17 Sep 2020 00:28:52 +0000 (12:28 +1200)]
[NFC] Code cleanup in test class

3 years agoMerge pull request #18494 from eileenmcnaughton/test_clean
Seamus Lee [Thu, 17 Sep 2020 00:08:45 +0000 (10:08 +1000)]
Merge pull request #18494 from eileenmcnaughton/test_clean

dev/core#2039 [NFC] Test cleanup to stop calling Email::add action

3 years ago[NFC] Minor cleanup in tests
eileen [Wed, 16 Sep 2020 23:54:48 +0000 (11:54 +1200)]
[NFC] Minor cleanup in tests

3 years agoMerge pull request #18484 from eileenmcnaughton/ref
colemanw [Wed, 16 Sep 2020 23:54:06 +0000 (19:54 -0400)]
Merge pull request #18484 from eileenmcnaughton/ref

dev/core#2043 remove pass-by-ref

3 years agoMerge pull request #18491 from totten/master-ref-gendata
Eileen McNaughton [Wed, 16 Sep 2020 22:40:24 +0000 (10:40 +1200)]
Merge pull request #18491 from totten/master-ref-gendata

(REF) GenerateData - Make it possible to call this via PHP

3 years agodev/core#2046 Rationalise add vs create on email BAO
eileen [Wed, 16 Sep 2020 20:51:17 +0000 (08:51 +1200)]
dev/core#2046 Rationalise add vs create on email BAO

This folds the 2 functions into one, deprecating add

3 years ago[NFC] Test cleanup to stop calling Email::add action which does not handle primary
eileen [Wed, 16 Sep 2020 20:36:34 +0000 (08:36 +1200)]
[NFC] Test cleanup to stop calling Email::add action which does not handle primary

Note I feel like we should further
1) move the contents of email add into create
2) make add a deprecated wrapper for create

Whatever the vision of different add vs create functions it didn't turn out in practice and seems to
only generate confusion. We recommend apiv4 as the preferred create methodology

3 years agoEnsure DAO base class contains functions to be removed from generated DAO files.
Coleman Watts [Wed, 16 Sep 2020 14:57:26 +0000 (10:57 -0400)]
Ensure DAO base class contains functions to be removed from generated DAO files.

The functions fieldKeys(), getLog(), and getTableName() are redundant in the generated DAO files,
we don't need 50 copies of each function.

This preliminary commit ensures they are present in the parent class, and in the future we can
regenerate the DAOs without them.

3 years agodev/core#2043 remove pass-by-ref
eileen [Wed, 16 Sep 2020 02:44:40 +0000 (14:44 +1200)]
dev/core#2043 remove pass-by-ref

Also shortening of if clause

3 years agoMerge pull request #18470 from JKingsnorth/dev/core#2027-2
Eileen McNaughton [Wed, 16 Sep 2020 19:19:03 +0000 (07:19 +1200)]
Merge pull request #18470 from JKingsnorth/dev/core#2027-2

dev/core#2027 Add/update to UK county list

3 years agoMerge pull request #18423 from eileenmcnaughton/afform
colemanw [Wed, 16 Sep 2020 14:44:23 +0000 (10:44 -0400)]
Merge pull request #18423 from eileenmcnaughton/afform

dev/core#2000 Move afform into core extensions

3 years agodev/core#2027 Add/update to UK county list
John Kingsnorth [Wed, 16 Sep 2020 11:11:06 +0000 (12:11 +0100)]
dev/core#2027 Add/update to UK county list

3 years ago(REF) GenerateData - Allow external control randomness
Tim Otten [Wed, 16 Sep 2020 09:58:36 +0000 (02:58 -0700)]
(REF) GenerateData - Allow external control randomness

3 years ago(REF) GenerateData - Use overrideable 'echo'. Use exceptions.
Tim Otten [Wed, 16 Sep 2020 08:08:03 +0000 (01:08 -0700)]
(REF) GenerateData - Use overrideable 'echo'. Use exceptions.

This removes elements of GenerateData which perform direct output to the user. there
are basically two cases:

1. Outputting advisory/status info (e.g. "echo"). This now goes through a method, which
   can be overriden/replaced.

2. Displaying errors from DAO-calls. Now-a-days, DAO-calls can raise their own exceptions,
   so we don't need to sprinkle it without error-outputs.

3 years ago(REF) GenerateData - Extract method 'generateAll()'
Tim Otten [Wed, 16 Sep 2020 07:39:14 +0000 (00:39 -0700)]
(REF) GenerateData - Extract method 'generateAll()'

3 years agoGenerateData - Make the generated sample data more stable (wrt shuffle+array_rand)
Tim Otten [Wed, 16 Sep 2020 09:28:11 +0000 (02:28 -0700)]
GenerateData - Make the generated sample data more stable (wrt shuffle+array_rand)

3 years agoGenerateData - Make the generated sample data more stable (wrt time)
Tim Otten [Wed, 16 Sep 2020 09:27:15 +0000 (02:27 -0700)]
GenerateData - Make the generated sample data more stable (wrt time)

3 years agoGenerateData - Make the generated sample data more stable (wrt mt_rand)
Tim Otten [Wed, 16 Sep 2020 07:30:56 +0000 (00:30 -0700)]
GenerateData - Make the generated sample data more stable (wrt mt_rand)

3 years ago(REF) GenerateData - Extract method 'randomInt()'
Tim Otten [Wed, 16 Sep 2020 07:25:18 +0000 (00:25 -0700)]
(REF) GenerateData - Extract method 'randomInt()'

This it easier to have one random number generator used for all 'randomFoo()' functions.

3 years ago(REF) Extract `CRM_Core_CodeGen_GenerateData` - Fix path reference
Tim Otten [Wed, 16 Sep 2020 07:58:19 +0000 (00:58 -0700)]
(REF) Extract `CRM_Core_CodeGen_GenerateData` - Fix path reference

When this class moved to a new folder, the relative paths changed.

3 years agoRemove deprecated code lines
eileen [Wed, 16 Sep 2020 10:31:05 +0000 (22:31 +1200)]
Remove deprecated code lines

3 years agoAdd check to ensure all have a primary address, fix identified but in IM.add
eileen [Tue, 15 Sep 2020 23:48:49 +0000 (11:48 +1200)]
Add check to ensure all have a primary address, fix identified but in IM.add

3 years agoMerge pull request #18486 from eileenmcnaughton/part
Monish Deb [Wed, 16 Sep 2020 07:29:11 +0000 (12:59 +0530)]
Merge pull request #18486 from eileenmcnaughton/part

dev/event#42 [Ref] Separate url path calculation into the relevant classes

3 years ago(REF) Extract `CRM_Core_CodeGen_GenerateData`
Tim Otten [Wed, 16 Sep 2020 07:00:50 +0000 (00:00 -0700)]
(REF) Extract `CRM_Core_CodeGen_GenerateData`

This moves the class from `sql/GenerateData.php` to `CRM/Core/CodeGen/GenerateData.php`, which makes
it easier to reference in other workflows.

3 years agoMerge pull request #18480 from eileenmcnaughton/dom_org
Seamus Lee [Wed, 16 Sep 2020 05:57:44 +0000 (15:57 +1000)]
Merge pull request #18480 from eileenmcnaughton/dom_org

dev/core#2039 Set is_primary to 1 on email, address for domain contacts

3 years agoMerge pull request #18487 from civicrm/5.30
Seamus Lee [Wed, 16 Sep 2020 05:51:04 +0000 (15:51 +1000)]
Merge pull request #18487 from civicrm/5.30

5.30

3 years ago[Ref] Separate url path calculation into the relevant classes
eileen [Wed, 16 Sep 2020 03:53:39 +0000 (15:53 +1200)]
[Ref] Separate url path calculation into the relevant classes

3 years agoMerge pull request #18482 from seamuslee001/5.30
Eileen McNaughton [Wed, 16 Sep 2020 04:17:47 +0000 (16:17 +1200)]
Merge pull request #18482 from seamuslee001/5.30

release-notes/5.29.1.md

3 years agoMerge pull request #18478 from seamuslee001/api_v4_fin_acl_test
Eileen McNaughton [Wed, 16 Sep 2020 04:17:04 +0000 (16:17 +1200)]
Merge pull request #18478 from seamuslee001/api_v4_fin_acl_test

[NFC] Enable APIv4 testing on the Fin ACL Extension Line Item test

3 years agoMerge pull request #18464 from eileenmcnaughton/urlparamms
Monish Deb [Wed, 16 Sep 2020 03:41:41 +0000 (09:11 +0530)]
Merge pull request #18464 from eileenmcnaughton/urlparamms

[REF] Start the process of separating the search action from the participant form

3 years agoMerge pull request #18463 from eileenmcnaughton/searchhhook
Monish Deb [Wed, 16 Sep 2020 03:11:10 +0000 (08:41 +0530)]
Merge pull request #18463 from eileenmcnaughton/searchhhook

dev/core#2017 remove unused SearchTaskHookSample.php

3 years agoRegenerate sql
eileen [Wed, 16 Sep 2020 02:03:04 +0000 (14:03 +1200)]
Regenerate sql

3 years agodev/core#2039 Set is_primary to 1 on email, address for domain contacts
eileen [Wed, 16 Sep 2020 00:52:52 +0000 (12:52 +1200)]
dev/core#2039 Set is_primary to 1 on email, address for domain contacts

I'm digging into the places where the code handles is_primary due to duplicate handling/ queries
- see https://lab.civicrm.org/dev/core/-/issues/2039

One distraction is that the domain contact's address & email are not marked is_primary. This
doesn't make sense to me as they ARE a contact in the DB

3 years agodev/core#2043 remove pass-by-reference
eileen [Wed, 16 Sep 2020 02:50:09 +0000 (14:50 +1200)]
dev/core#2043 remove pass-by-reference

Technical details in https://lab.civicrm.org/dev/core/-/issues/2043

3 years agoPhpcs fix
eileen [Thu, 10 Sep 2020 20:34:50 +0000 (08:34 +1200)]
Phpcs fix

3 years agoRemove commented out line
eileen [Thu, 10 Sep 2020 03:47:37 +0000 (15:47 +1200)]
Remove commented out line

3 years agoRemove more commented out code that is upsetting CI
eileen [Thu, 10 Sep 2020 03:41:36 +0000 (15:41 +1200)]
Remove more commented out code that is upsetting CI

3 years agoRemove more commented out function
eileen [Thu, 10 Sep 2020 03:09:37 +0000 (15:09 +1200)]
Remove more commented out function

3 years agoStyle fixes
eileen [Thu, 10 Sep 2020 01:18:00 +0000 (13:18 +1200)]
Style fixes

I removed the commented out functions rather than figuring out how to style them right

3 years agoMisc style fix
eileen [Wed, 9 Sep 2020 21:31:53 +0000 (09:31 +1200)]
Misc style fix

3 years agoRe-run civix upgrader
eileen [Wed, 9 Sep 2020 21:31:41 +0000 (09:31 +1200)]
Re-run civix upgrader

3 years agoRe-run civix
eileen [Wed, 9 Sep 2020 21:17:02 +0000 (09:17 +1200)]
Re-run civix

3 years agoUpdate API factory functions with checkPermissions
Coleman Watts [Fri, 17 Jul 2020 14:07:09 +0000 (10:07 -0400)]
Update API factory functions with checkPermissions

3 years agoUse standard api for getFields
Coleman Watts [Wed, 12 Feb 2020 16:21:16 +0000 (11:21 -0500)]
Use standard api for getFields

3 years agoUpdate API docblock.
Coleman Watts [Sat, 1 Feb 2020 16:44:44 +0000 (11:44 -0500)]
Update API docblock.

3 years agoUse built-in php function to do what we were trying to do with str_replace
Coleman Watts [Fri, 31 Jan 2020 16:40:26 +0000 (11:40 -0500)]
Use built-in php function to do what we were trying to do with str_replace

3 years agoCode comment
Coleman Watts [Fri, 31 Jan 2020 16:39:40 +0000 (11:39 -0500)]
Code comment

3 years agoRevert "Reinstate parsing of data from the form"
Coleman Watts [Fri, 17 Jan 2020 00:49:47 +0000 (19:49 -0500)]
Revert "Reinstate parsing of data from the form"

This reverts commit d31206f9e08703ae4f11b7e34673d7ece92b1630.

3 years agoSupport is_primary fields and boolean options.
Coleman Watts [Thu, 16 Jan 2020 15:53:24 +0000 (10:53 -0500)]
Support is_primary fields and boolean options.

Civi 5.23 changes boolean options to be real true and false instead of '1' and '0'
so added version bump to keep in step.

3 years agoMore efficient select options handling
Coleman Watts [Fri, 10 Jan 2020 17:59:49 +0000 (12:59 -0500)]
More efficient select options handling

The afField.getOptions function was causing infinite recursion by recreating the boolean options array every time.
Passing this variable by refernce solves the problem, and adding "track by" to the ng-repeat follows best-practices for efficiency.

3 years agoReinstate parsing of data from the form
eileen [Fri, 10 Jan 2020 01:09:34 +0000 (14:09 +1300)]
Reinstate parsing of data from the form

This means that data can be set in an embedded form e.g

 <af-entity data='{name_a : options.name_a,  name_b : options.name_b, is_name_b_nickname: options.is_name_b_nickname, is_name_b_inferior: options.is_name_b_inferior}' .... />

In this case the options.name_as comes from the directive that instantiates this afform

3 years agoIncrement suggested version to reflect info.xml
eileen [Fri, 10 Jan 2020 01:05:28 +0000 (14:05 +1300)]
Increment suggested version to reflect info.xml

Arguably afform still works on older versions but breaking changes have happened & if people
use it on older you want a buyer-beware type feeling

3 years agoRelease v0.4
Coleman Watts [Thu, 9 Jan 2020 20:11:15 +0000 (15:11 -0500)]
Release v0.4

3 years agoLoosen restrictions on file names - allow underscores
Coleman Watts [Wed, 8 Jan 2020 13:23:03 +0000 (08:23 -0500)]
Loosen restrictions on file names - allow underscores

3 years agoUse api to get directive/module names
Coleman Watts [Wed, 8 Jan 2020 13:20:54 +0000 (08:20 -0500)]
Use api to get directive/module names