civicrm-core.git
9 years agotest-fixes, stop using non-existent return values & remove broken function
Eileen McNaughton [Mon, 12 Jan 2015 03:23:57 +0000 (16:23 +1300)]
test-fixes, stop using non-existent return values & remove broken function
I feel I can reasonably assume the tests would fail if this function were ever called

9 years agofix spelling, minor function fix to reflect lack of return value
Eileen McNaughton [Mon, 12 Jan 2015 03:10:57 +0000 (16:10 +1300)]
fix spelling, minor function fix to reflect lack of return value

9 years agoRemove php test class, since it requires files that have been invalid
Eileen McNaughton [Mon, 12 Jan 2015 02:58:47 +0000 (15:58 +1300)]
Remove php test class, since it requires files that have been invalid
for some time we can assume it is not used

9 years agoMerge pull request #4901 from colemanw/INFRA-132
colemanw [Mon, 12 Jan 2015 02:02:21 +0000 (21:02 -0500)]
Merge pull request #4901 from colemanw/INFRA-132

INFRA-132 - Docblock formatting fixes

9 years agoINFRA-132 - Standardize integer to int
Coleman Watts [Mon, 12 Jan 2015 01:40:52 +0000 (20:40 -0500)]
INFRA-132 - Standardize integer to int

9 years agoINFRA-132 - Standardize @inheritDoc tag use
Coleman Watts [Mon, 12 Jan 2015 01:07:35 +0000 (20:07 -0500)]
INFRA-132 - Standardize @inheritDoc tag use

9 years agoINFRA-132 - Fix comment formatting
Coleman Watts [Mon, 12 Jan 2015 00:49:32 +0000 (19:49 -0500)]
INFRA-132 - Fix comment formatting

9 years agoINFRA-132 - Move stray comments into docblocks
Coleman Watts [Mon, 12 Jan 2015 00:18:14 +0000 (19:18 -0500)]
INFRA-132 - Move stray comments into docblocks

9 years agoINFRA-132 - Docblock formatting fixes
Coleman Watts [Sun, 11 Jan 2015 18:25:12 +0000 (13:25 -0500)]
INFRA-132 - Docblock formatting fixes

9 years agoMerge pull request #4875 from civicrm/minor-fix
Monish Deb [Sun, 11 Jan 2015 10:48:20 +0000 (16:18 +0530)]
Merge pull request #4875 from civicrm/minor-fix

fix errors thrown when group is added

9 years agoMerge pull request #4899 from colemanw/INFRA-132
colemanw [Sun, 11 Jan 2015 02:46:52 +0000 (21:46 -0500)]
Merge pull request #4899 from colemanw/INFRA-132

INFRA-132 - Docblock @param and @return tag fixes

9 years agoINFRA-132 - Docblock @param and @return tag fixes
Coleman Watts [Sat, 10 Jan 2015 19:27:30 +0000 (14:27 -0500)]
INFRA-132 - Docblock @param and @return tag fixes

9 years agoMerge pull request #4896 from totten/master-movedep
Tim Otten [Sat, 10 Jan 2015 05:58:12 +0000 (21:58 -0800)]
Merge pull request #4896 from totten/master-movedep

CA_Config, qunit, d3.js - Move various dependencies to bower.json/composer.json

9 years agoMerge pull request #4897 from totten/master-cleanup2
Tim Otten [Sat, 10 Jan 2015 05:57:54 +0000 (21:57 -0800)]
Merge pull request #4897 from totten/master-cleanup2

INFRA-132 - More changes from the Arm & Hammer bald dude

9 years agoINFRA-132 - Drupal.Files.EndFileNewline.TooMany
Tim Otten [Sat, 10 Jan 2015 04:57:51 +0000 (20:57 -0800)]
INFRA-132 - Drupal.Files.EndFileNewline.TooMany

9 years agoINFRA-132 - CRM/ - PHPStorm cleanup
Tim Otten [Sat, 10 Jan 2015 04:15:06 +0000 (20:15 -0800)]
INFRA-132 - CRM/ - PHPStorm cleanup

9 years agoINFRA-132 - Civi - PHPStorm cleanup
Tim Otten [Sat, 10 Jan 2015 03:51:41 +0000 (19:51 -0800)]
INFRA-132 - Civi - PHPStorm cleanup

9 years agoINFRA-132 - bin, extern, install, settings, xml - PHPStorm cleanup
Tim Otten [Sat, 10 Jan 2015 03:51:01 +0000 (19:51 -0800)]
INFRA-132 - bin, extern, install, settings, xml - PHPStorm cleanup

9 years agoINFRA-132 - tests/ - PHPStorm cleanup
Tim Otten [Sat, 10 Jan 2015 03:44:02 +0000 (19:44 -0800)]
INFRA-132 - tests/ - PHPStorm cleanup

9 years agoINFRA-132 - FunctionDeclarationArgumentSpacing.SpaceBeforeEquals
Tim Otten [Fri, 9 Jan 2015 23:09:24 +0000 (15:09 -0800)]
INFRA-132 - FunctionDeclarationArgumentSpacing.SpaceBeforeEquals

9 years agoINFRA-132 - SpacingAfterBeak
Tim Otten [Fri, 9 Jan 2015 23:00:50 +0000 (15:00 -0800)]
INFRA-132 - SpacingAfterBeak

9 years agoINFRA-132 - BraceOnNewLine. ContentAfterBrace. FirstIndexNoNewline.
Tim Otten [Fri, 9 Jan 2015 22:48:38 +0000 (14:48 -0800)]
INFRA-132 - BraceOnNewLine. ContentAfterBrace. FirstIndexNoNewline.

9 years agoMerge pull request #4895 from colemanw/INFRA-132
colemanw [Sat, 10 Jan 2015 03:05:52 +0000 (22:05 -0500)]
Merge pull request #4895 from colemanw/INFRA-132

INFRA-132 - Whitespace fixes in docbloks

9 years agoINFRA-132 - Whitespace fixes in docbloks
Coleman Watts [Sat, 10 Jan 2015 03:03:14 +0000 (22:03 -0500)]
INFRA-132 - Whitespace fixes in docbloks

9 years agod3.min.js - Move to bower.json
Tim Otten [Sat, 10 Jan 2015 03:03:07 +0000 (19:03 -0800)]
d3.min.js - Move to bower.json

The version 3.4.11 is selected to match the existing code -- I don't know
that it's better or worse than any other version.

9 years agoMerge branch 4.5 into master
Coleman Watts [Sat, 10 Jan 2015 02:47:51 +0000 (21:47 -0500)]
Merge branch 4.5 into master

Conflicts:
CRM/Report/Form.php
CRM/Report/Form/Activity.php
CRM/Utils/File.php

9 years agoangularsanitize.js - Remove redundant, unreferenced file
Tim Otten [Sat, 10 Jan 2015 02:47:14 +0000 (18:47 -0800)]
angularsanitize.js - Remove redundant, unreferenced file

9 years agoqunit - Move from packages.git to bower.json
Tim Otten [Sat, 10 Jan 2015 02:45:27 +0000 (18:45 -0800)]
qunit - Move from packages.git to bower.json

9 years agoMerge pull request #4894 from colemanw/CRM-15805
colemanw [Sat, 10 Jan 2015 01:55:56 +0000 (20:55 -0500)]
Merge pull request #4894 from colemanw/CRM-15805

CRM-15805 - Add missing permission declaration for option group/value apis

9 years agoCA_Config - Move from packages.git to composer.json
Tim Otten [Sat, 10 Jan 2015 00:22:53 +0000 (16:22 -0800)]
CA_Config - Move from packages.git to composer.json

9 years agoCRM-15805 - Add missing permission declaration for option group/value apis
Coleman Watts [Sat, 10 Jan 2015 00:55:55 +0000 (19:55 -0500)]
CRM-15805 - Add missing permission declaration for option group/value apis

9 years agoMerge pull request #4893 from colemanw/INFRA-132
colemanw [Fri, 9 Jan 2015 20:22:35 +0000 (15:22 -0500)]
Merge pull request #4893 from colemanw/INFRA-132

INFRA-132 - Fix spacing of @return tag in comments

9 years agoINFRA-132 - Remove extra newlines from the bottom of docblocks
Coleman Watts [Fri, 9 Jan 2015 20:19:07 +0000 (15:19 -0500)]
INFRA-132 - Remove extra newlines from the bottom of docblocks

9 years agoINFRA-132 - Fix spacing of @return tag in comments
Coleman Watts [Fri, 9 Jan 2015 19:54:55 +0000 (14:54 -0500)]
INFRA-132 - Fix spacing of @return tag in comments

9 years agoMerge pull request #4892 from colemanw/INFRA-132
colemanw [Fri, 9 Jan 2015 19:45:32 +0000 (14:45 -0500)]
Merge pull request #4892 from colemanw/INFRA-132

INFRA-132 - Code comment cleanup

9 years agoINFRA-132 - Comment grammar cleanup
Coleman Watts [Fri, 9 Jan 2015 19:37:01 +0000 (14:37 -0500)]
INFRA-132 - Comment grammar cleanup

9 years agoINFRA-132 - Comment whitespace cleanup
Coleman Watts [Fri, 9 Jan 2015 18:58:54 +0000 (13:58 -0500)]
INFRA-132 - Comment whitespace cleanup

9 years agoINFRA-132 - Fix missing newlines in comments
Coleman Watts [Fri, 9 Jan 2015 18:50:04 +0000 (13:50 -0500)]
INFRA-132 - Fix missing newlines in comments

9 years agoINFRA-132 - Fix comment spacing
Coleman Watts [Fri, 9 Jan 2015 18:43:03 +0000 (13:43 -0500)]
INFRA-132 - Fix comment spacing

9 years agoMerge pull request #4890 from colemanw/CRM-15803
colemanw [Fri, 9 Jan 2015 16:42:37 +0000 (11:42 -0500)]
Merge pull request #4890 from colemanw/CRM-15803

CRM-15803 - Validate EntityRef values before rendering

9 years agoMerge pull request #4891 from colemanw/INFRA-132
colemanw [Fri, 9 Jan 2015 16:34:36 +0000 (11:34 -0500)]
Merge pull request #4891 from colemanw/INFRA-132

INFRA-132 - Fix misplaced @param types in docblocks

9 years agoINFRA-132 - @param type fixes
Coleman Watts [Fri, 9 Jan 2015 16:00:52 +0000 (11:00 -0500)]
INFRA-132 - @param type fixes

9 years agoCRM-15803 - Validate EntityRef values before rendering
Coleman Watts [Fri, 9 Jan 2015 15:07:24 +0000 (10:07 -0500)]
CRM-15803 - Validate EntityRef values before rendering

9 years agoMerge pull request #4886 from rohankatkar/webtest4.6
Monish Deb [Fri, 9 Jan 2015 15:06:41 +0000 (20:36 +0530)]
Merge pull request #4886 from rohankatkar/webtest4.6

Webtests Fixes

9 years agoMerge pull request #4888 from colemanw/master
colemanw [Fri, 9 Jan 2015 14:30:04 +0000 (09:30 -0500)]
Merge pull request #4888 from colemanw/master

INFRA-132 - Docblock cleanup

9 years agoINFRA-132 - Docblock cleanup
Coleman Watts [Fri, 9 Jan 2015 14:25:24 +0000 (09:25 -0500)]
INFRA-132 - Docblock cleanup

9 years agoMerge pull request #4882 from colemanw/CRM-15789
colemanw [Fri, 9 Jan 2015 13:56:06 +0000 (08:56 -0500)]
Merge pull request #4882 from colemanw/CRM-15789

CRM-15789 - Additional button/icon cleanup

9 years agoWebtests Fixes
Web Access [Fri, 9 Jan 2015 13:09:34 +0000 (18:39 +0530)]
Webtests Fixes

9 years agoMerge pull request #4865 from eileenmcnaughton/my-first-factory
Eileen McNaughton [Fri, 9 Jan 2015 06:50:23 +0000 (19:50 +1300)]
Merge pull request #4865 from eileenmcnaughton/my-first-factory

CRM-15771 - CRM_Core_Payment - Replace singletons with manager class

9 years agoMerge pull request #4883 from totten/master-cs4
Tim Otten [Fri, 9 Jan 2015 06:08:07 +0000 (22:08 -0800)]
Merge pull request #4883 from totten/master-cs4

INFRA-132 - Misc cleanup

9 years agoINFRA-132 - Fix misc oddball syntax
Tim Otten [Fri, 9 Jan 2015 03:53:23 +0000 (19:53 -0800)]
INFRA-132 - Fix misc oddball syntax

9 years agoINFRA-132 - CRM/ - Fix misc oddball syntax
Tim Otten [Fri, 9 Jan 2015 03:53:01 +0000 (19:53 -0800)]
INFRA-132 - CRM/ - Fix misc oddball syntax

9 years agoINFRA-132 - Fix misc oddball syntax
Tim Otten [Fri, 9 Jan 2015 02:54:52 +0000 (18:54 -0800)]
INFRA-132 - Fix misc oddball syntax

9 years agoINFRA-132 - tests/- Fix misc oddball syntax
Tim Otten [Fri, 9 Jan 2015 02:31:57 +0000 (18:31 -0800)]
INFRA-132 - tests/- Fix misc oddball syntax

9 years agoINFRA-132 - api/v3 - Fix misc oddball syntax
Tim Otten [Fri, 9 Jan 2015 02:31:56 +0000 (18:31 -0800)]
INFRA-132 - api/v3 - Fix misc oddball syntax

9 years agoINFRA-132 - CRM/ - Fix misc oddball syntax
Tim Otten [Fri, 9 Jan 2015 02:31:55 +0000 (18:31 -0800)]
INFRA-132 - CRM/ - Fix misc oddball syntax

9 years agoCRM-15789 - Additional button/icon cleanup
Coleman Watts [Fri, 9 Jan 2015 02:58:20 +0000 (21:58 -0500)]
CRM-15789 - Additional button/icon cleanup

9 years agoINFRA-132 - CRM/Core/BAO/RecurringEntity.php - Fix EOL
Tim Otten [Fri, 9 Jan 2015 02:22:45 +0000 (18:22 -0800)]
INFRA-132 - CRM/Core/BAO/RecurringEntity.php - Fix EOL

9 years agoINFRA-132 - s/false/FALSE/
Tim Otten [Fri, 9 Jan 2015 02:09:06 +0000 (18:09 -0800)]
INFRA-132 - s/false/FALSE/

9 years agoINFRA-132 - s/true/TRUE/
Tim Otten [Fri, 9 Jan 2015 02:06:41 +0000 (18:06 -0800)]
INFRA-132 - s/true/TRUE/

9 years agoINFRA-132 - s/null/NULL/
Tim Otten [Fri, 9 Jan 2015 02:03:18 +0000 (18:03 -0800)]
INFRA-132 - s/null/NULL/

9 years agoMerge pull request #4880 from totten/master-cs3
Tim Otten [Fri, 9 Jan 2015 01:31:32 +0000 (17:31 -0800)]
Merge pull request #4880 from totten/master-cs3

INFRA-132 - Misc cleanup

9 years agoMerge pull request #4879 from OnkelTem/opendir_fixes
Tim Otten [Fri, 9 Jan 2015 00:51:16 +0000 (16:51 -0800)]
Merge pull request #4879 from OnkelTem/opendir_fixes

CRM-15799 - CRM_Utils_File - Improve error handling

9 years agoINFRA-132 - CRM_Utils_GlobalStackTest
Tim Otten [Fri, 9 Jan 2015 00:28:29 +0000 (16:28 -0800)]
INFRA-132 - CRM_Utils_GlobalStackTest

9 years agoINFRA-132 - CRM/Admin/Form/Setting/Component.php - Remove unused global
Tim Otten [Fri, 9 Jan 2015 00:26:09 +0000 (16:26 -0800)]
INFRA-132 - CRM/Admin/Form/Setting/Component.php - Remove unused global

9 years agoINFRA-132 - Trailing commas for multiline arrays
Tim Otten [Fri, 9 Jan 2015 00:06:46 +0000 (16:06 -0800)]
INFRA-132 - Trailing commas for multiline arrays

9 years agoINFRA-132 - api/ - Misc
Tim Otten [Fri, 9 Jan 2015 00:02:10 +0000 (16:02 -0800)]
INFRA-132 - api/ - Misc

9 years agoINFRA-132 - tests/phpunit/WebTest/Contact/SearchbyDateFilterTest.php
Tim Otten [Thu, 8 Jan 2015 23:39:24 +0000 (15:39 -0800)]
INFRA-132 - tests/phpunit/WebTest/Contact/SearchbyDateFilterTest.php

9 years agoINFRA-132 - CRM/Utils/Hook.php
Tim Otten [Thu, 8 Jan 2015 23:39:24 +0000 (15:39 -0800)]
INFRA-132 - CRM/Utils/Hook.php

9 years agoINFRA-132 - CRM/Contact/BAO/Relationship.php
Tim Otten [Thu, 8 Jan 2015 23:39:24 +0000 (15:39 -0800)]
INFRA-132 - CRM/Contact/BAO/Relationship.php

9 years agoMerge pull request #4871 from eileenmcnaughton/CRM-15795
Eileen McNaughton [Thu, 8 Jan 2015 23:37:13 +0000 (12:37 +1300)]
Merge pull request #4871 from eileenmcnaughton/CRM-15795

 CRM-15795 prevent silent failure with rollback on participants

9 years agoINFRA-132 - s/(else|try){/(else|try) {/
Tim Otten [Thu, 8 Jan 2015 23:01:43 +0000 (15:01 -0800)]
INFRA-132 - s/(else|try){/(else|try) {/

9 years agoINFRA-132 - Remove extra spaces around '.'
Tim Otten [Thu, 8 Jan 2015 22:57:35 +0000 (14:57 -0800)]
INFRA-132 - Remove extra spaces around '.'

9 years agoINFRA-132 - s/array (/array(/
Tim Otten [Thu, 8 Jan 2015 22:50:52 +0000 (14:50 -0800)]
INFRA-132 - s/array (/array(/

9 years agoCRM-15799 - System crash on attempt to upgrade from 4.5.4 to 4.5.5
aneganov [Thu, 8 Jan 2015 22:31:03 +0000 (01:31 +0300)]
CRM-15799 - System crash on attempt to upgrade from 4.5.4 to 4.5.5

----------------------------------------
* CRM-15799: System crash on attempt to upgrade from 4.5.4 to 4.5.5
  https://issues.civicrm.org/jira/browse/CRM-15799

9 years agoCRM-15773 - Revert incorrect column header label change
Coleman Watts [Thu, 8 Jan 2015 19:54:54 +0000 (14:54 -0500)]
CRM-15773 - Revert incorrect column header label change

9 years agoFix scope error
Coleman Watts [Thu, 8 Jan 2015 19:47:49 +0000 (14:47 -0500)]
Fix scope error

9 years agoMerge pull request #4861 from colemanw/CRM-15789
colemanw [Thu, 8 Jan 2015 19:40:57 +0000 (14:40 -0500)]
Merge pull request #4861 from colemanw/CRM-15789

CRM-15789 - Add icons to submit buttons

9 years agoCRM-15789 - Remove ascii art from button text
Coleman Watts [Thu, 8 Jan 2015 18:40:51 +0000 (13:40 -0500)]
CRM-15789 - Remove ascii art from button text

9 years agoCRM-15789 - Fix button display in popups
Coleman Watts [Thu, 8 Jan 2015 18:37:58 +0000 (13:37 -0500)]
CRM-15789 - Fix button display in popups

9 years agoRemove unused tpl
Coleman Watts [Thu, 8 Jan 2015 16:55:44 +0000 (11:55 -0500)]
Remove unused tpl

9 years agoCRM-15789 - More consistent button classes and icons
Coleman Watts [Thu, 8 Jan 2015 15:35:49 +0000 (10:35 -0500)]
CRM-15789 - More consistent button classes and icons

9 years agoCRM-15789 - Cleanup submit button styles
Coleman Watts [Wed, 7 Jan 2015 18:19:08 +0000 (13:19 -0500)]
CRM-15789 - Cleanup submit button styles

9 years agoCRM-15789 - Cleanup editable icons/styles
Coleman Watts [Wed, 7 Jan 2015 16:42:10 +0000 (11:42 -0500)]
CRM-15789 - Cleanup editable icons/styles

9 years agoCRM-15789 - Remove civicrm.css styles redundant with jQuery UI
Coleman Watts [Tue, 6 Jan 2015 19:37:22 +0000 (14:37 -0500)]
CRM-15789 - Remove civicrm.css styles redundant with jQuery UI

9 years agoCRM-15789 - Add icons to submit buttons
Coleman Watts [Tue, 6 Jan 2015 18:31:44 +0000 (13:31 -0500)]
CRM-15789 - Add icons to submit buttons

9 years agoMerge pull request #4878 from pratikshad/broken-webtest
Monish Deb [Thu, 8 Jan 2015 18:20:51 +0000 (23:50 +0530)]
Merge pull request #4878 from pratikshad/broken-webtest

Fixed webtest of export and testAdvanceSearch of Contact_AdavanceSearchT...

9 years agoMerge pull request #4877 from rohankatkar/webtest4.6
Monish Deb [Thu, 8 Jan 2015 18:20:34 +0000 (23:50 +0530)]
Merge pull request #4877 from rohankatkar/webtest4.6

Webtests fixes

9 years agoFixed webtest of export and testAdvanceSearch of Contact_AdavanceSearchTest
pratikshad [Thu, 8 Jan 2015 13:52:33 +0000 (19:22 +0530)]
Fixed webtest of export and testAdvanceSearch of Contact_AdavanceSearchTest

9 years agoWebtests fixes
Web Access [Thu, 8 Jan 2015 13:18:58 +0000 (18:48 +0530)]
Webtests fixes

9 years agofix errors thrown when group is added
yashodha [Thu, 8 Jan 2015 10:20:57 +0000 (15:50 +0530)]
fix errors thrown when group is added

9 years agoMerge pull request #4872 from totten/master-civimail-defaults
Tim Otten [Thu, 8 Jan 2015 06:21:01 +0000 (22:21 -0800)]
Merge pull request #4872 from totten/master-civimail-defaults

CRM-15578 - CiviMail UI - Multiple fixes

9 years agoCRM-15578 - crmMailingAB/report - Grammatical consistency. More intuitive order.
Tim Otten [Thu, 8 Jan 2015 02:18:52 +0000 (18:18 -0800)]
CRM-15578 - crmMailingAB/report - Grammatical consistency. More intuitive order.

9 years agoCRM-15578 - Fix display of dates on past newsletters
Tim Otten [Thu, 8 Jan 2015 02:18:15 +0000 (18:18 -0800)]
CRM-15578 - Fix display of dates on past newsletters

9 years agoCRM-15578 - edit-unified.html - Change layout
Tim Otten [Thu, 8 Jan 2015 01:02:42 +0000 (17:02 -0800)]
CRM-15578 - edit-unified.html - Change layout

9 years agocrmMailing - Cleanup per jshint
Tim Otten [Thu, 8 Jan 2015 00:37:56 +0000 (16:37 -0800)]
crmMailing - Cleanup per jshint

9 years agoCRM-15578 - crmMailing - Start out with an empty mailing
Tim Otten [Thu, 8 Jan 2015 00:36:44 +0000 (16:36 -0800)]
CRM-15578 - crmMailing - Start out with an empty mailing

9 years agobower.json - Fix angular-jquery-dialog-service
Tim Otten [Thu, 8 Jan 2015 00:33:34 +0000 (16:33 -0800)]
bower.json - Fix angular-jquery-dialog-service

When we moved bower.json from civicrm-packages.git to civicrm-core.git, we
transferred old (stale) information about angular-jquery-dialog-service.
Restore it.

9 years agoMerge pull request #4860 from totten/master-ext-cache
Tim Otten [Thu, 8 Jan 2015 00:19:04 +0000 (16:19 -0800)]
Merge pull request #4860 from totten/master-ext-cache

CRM-15788 - CRM_Extension_System - Fix for shared DB with multiple sites

9 years agoMerge pull request #4851 from totten/master-createtest-bao
Tim Otten [Thu, 8 Jan 2015 00:16:48 +0000 (16:16 -0800)]
Merge pull request #4851 from totten/master-createtest-bao

CRM_Core_DAO::createTestObject() - Prefer BAO's