Jon Goldberg [Mon, 12 Jul 2021 19:20:36 +0000 (15:20 -0400)]
fixes core#2687: regression on group rebuild scheduled job
demeritcowboy [Tue, 6 Jul 2021 19:32:26 +0000 (15:32 -0400)]
Merge pull request #20781 from colemanw/tplFixes
Fix undefined indexes in tpls
colemanw [Tue, 6 Jul 2021 15:22:39 +0000 (11:22 -0400)]
Merge pull request #20778 from eileenmcnaughton/batch
[REF] Tidy up param transforms
colemanw [Tue, 6 Jul 2021 15:19:28 +0000 (11:19 -0400)]
Merge pull request #20728 from demeritcowboy/missing-end-date
Error when sorting case roles table by end date
colemanw [Tue, 6 Jul 2021 14:55:51 +0000 (10:55 -0400)]
Merge pull request #20738 from eileenmcnaughton/tpl2
Enotice fix Remove references to savedFieldMapping in page 2 of the import
Coleman Watts [Tue, 6 Jul 2021 14:07:16 +0000 (10:07 -0400)]
Fix undefined indexes in tpls
Monish Deb [Tue, 6 Jul 2021 11:19:56 +0000 (16:49 +0530)]
Merge pull request #20672 from eileenmcnaughton/mem_num_terms
dev/membership#29 Add civicrm_line_item.membership_num_terms
Eileen McNaughton [Mon, 5 Jul 2021 23:55:20 +0000 (11:55 +1200)]
[REF] Tidy up param transforms
This just moves the transforms to their own function & comments them. I have previously
added test cover which should cover this well.
The parameters used for profiles are not the 'real' parameters so this does the transform
Seamus Lee [Mon, 5 Jul 2021 22:58:54 +0000 (08:58 +1000)]
Merge pull request #20774 from civicrm/5.39
5.39
Eileen McNaughton [Sat, 19 Jun 2021 06:57:12 +0000 (18:57 +1200)]
dev/membership#29 Add civicrm_line_item.membership_num_terms
Specify table in query (no change in query meaning)
Eileen McNaughton [Mon, 5 Jul 2021 22:21:29 +0000 (10:21 +1200)]
Merge pull request #20727 from colemanw/deprecateApi4EntityLinks
APIv4 - Deprecate Entity::getLinks action
Seamus Lee [Mon, 5 Jul 2021 21:18:03 +0000 (07:18 +1000)]
Merge pull request #20773 from alifrumin/rn5.39
[NFC] First Stab at 5.39 Release Notes
colemanw [Mon, 5 Jul 2021 19:18:52 +0000 (15:18 -0400)]
Merge pull request #20770 from demeritcowboy/smartydash
smarty notice - case dashboard when no upcoming/recent cases
Alice Frumin [Thu, 17 Jun 2021 18:25:54 +0000 (14:25 -0400)]
release notes 5.39 - first pass
colemanw [Mon, 5 Jul 2021 16:52:04 +0000 (12:52 -0400)]
Merge pull request #20769 from eileenmcnaughton/acl_test
dev/core#2115 Move financial acl code out of v3 Contribution create
Monish Deb [Mon, 5 Jul 2021 16:06:07 +0000 (21:36 +0530)]
Merge pull request #20771 from demeritcowboy/smartyrep2
smarty notice - title is only set for a list of existing report instances
Monish Deb [Mon, 5 Jul 2021 16:05:25 +0000 (21:35 +0530)]
Merge pull request #20772 from demeritcowboy/smartyrep
smarty notice - confirm_message is usually irrelevant in report listings
demeritcowboy [Mon, 5 Jul 2021 13:10:10 +0000 (09:10 -0400)]
title is only set for a list of existing instances
demeritcowboy [Mon, 5 Jul 2021 13:07:57 +0000 (09:07 -0400)]
sometimes it's legitimately missing
demeritcowboy [Mon, 5 Jul 2021 13:02:38 +0000 (09:02 -0400)]
ensure var exists
colemanw [Mon, 5 Jul 2021 11:38:45 +0000 (07:38 -0400)]
Merge pull request #20733 from seamuslee001/is_deleted_unit_test
[NFC] Add in unit test to lock in the fix for the is_deleted in where…
Monish Deb [Mon, 5 Jul 2021 10:55:41 +0000 (16:25 +0530)]
Merge pull request #20321 from mattwire/loggedincontactid
Deprecate duplicate getLoggedInContactID() function
Seamus Lee [Mon, 5 Jul 2021 08:31:27 +0000 (18:31 +1000)]
Merge pull request #20751 from artfulrobot/artfulrobot-fix-email-hold-reset
Fix invalid defaults for Mailing.update_email_resetdate API
Monish Deb [Mon, 5 Jul 2021 07:48:36 +0000 (13:18 +0530)]
Merge pull request #20681 from eileenmcnaughton/order_easy
Make Order api easier to use for default price set
Monish Deb [Mon, 5 Jul 2021 07:29:07 +0000 (12:59 +0530)]
Merge pull request #20656 from eileenmcnaughton/cont_mode
[REF] Follow up clean up - remove contribution_mode
Rich Lott / Artful Robot [Fri, 2 Jul 2021 15:47:59 +0000 (16:47 +0100)]
Fix invalid defaults for Mailing.update_email_resetdate API
temp
Eileen McNaughton [Mon, 5 Jul 2021 02:35:57 +0000 (14:35 +1200)]
dev/core#2115 Move financial acl code out of v3 Contribution create
Seamus Lee [Wed, 30 Jun 2021 21:54:05 +0000 (07:54 +1000)]
[NFC] Add in unit test to lock in the fix for the is_deleted in where clause issue
Move Unit test into its own class and use normal apiv4 wrapper rather than internal class as per Coleman
Eileen McNaughton [Mon, 5 Jul 2021 01:49:42 +0000 (13:49 +1200)]
Merge pull request #20763 from colemanw/joinIdField
SearchKit - use primary_key info instead of assuming 'id'
Eileen McNaughton [Mon, 5 Jul 2021 01:21:58 +0000 (13:21 +1200)]
Merge pull request #20761 from eileenmcnaughton/mem_type
dev/core#2115 Add test cover for membership type page
Seamus Lee [Mon, 5 Jul 2021 00:16:33 +0000 (10:16 +1000)]
Merge pull request #20755 from colemanw/afformTweaks
Afform - cosmetic fixes in palette panel
Eileen McNaughton [Sun, 4 Jul 2021 03:33:46 +0000 (15:33 +1200)]
Add test cover for membership type page
Coleman Watts [Sun, 4 Jul 2021 02:05:12 +0000 (22:05 -0400)]
APIv4 - Remove unused backreferences from SchemaMap
Coleman Watts [Wed, 30 Jun 2021 14:36:02 +0000 (10:36 -0400)]
APIv4 - Deprecate Entity::getLinks action
The action returns a bunch of deprecated information which is no longer needed.
The APIv4 Explorer had been using a small portion of it which was actually redundant
with existing info from getFields.
Coleman Watts [Sun, 4 Jul 2021 15:18:07 +0000 (11:18 -0400)]
SearchKit - use primary_key info instead of assuming 'id'
colemanw [Sun, 4 Jul 2021 15:00:09 +0000 (11:00 -0400)]
Merge pull request #20762 from eileenmcnaughton/mem2
dev/core#2115 prep - Remove silly if, silly rename
demeritcowboy [Sun, 4 Jul 2021 14:09:28 +0000 (10:09 -0400)]
Merge pull request #20760 from eileenmcnaughton/dep
Remove deprecated function
Seamus Lee [Sun, 4 Jul 2021 05:52:11 +0000 (15:52 +1000)]
Merge pull request #20749 from colemanw/apiPrimaryKey
APIv4 - Rename id_field to primary_key and make it an array
Eileen McNaughton [Sun, 4 Jul 2021 04:09:44 +0000 (16:09 +1200)]
Merge pull request #20757 from eileenmcnaughton/phone_strip
dev/core#27 Move check for phone function to a check
Eileen McNaughton [Sun, 4 Jul 2021 04:04:45 +0000 (16:04 +1200)]
Remove silly if, silly rename
This removes an if which would only be true if civicrm_membership_type table had the
field is_reserved and it was set to true. Given condition 1 is not met, 2
cannot be met.
Also - we rename max_related to maxRelated for no-good-reason
Eileen McNaughton [Sun, 4 Jul 2021 03:08:00 +0000 (15:08 +1200)]
Remove deprecated function
colemanw [Sun, 4 Jul 2021 02:53:48 +0000 (22:53 -0400)]
Merge pull request #20743 from eileenmcnaughton/option_type
Improve api consistency on custom field creation
Coleman Watts [Fri, 2 Jul 2021 02:34:01 +0000 (22:34 -0400)]
Add primaryKey info to daos
Coleman Watts [Fri, 2 Jul 2021 02:10:52 +0000 (22:10 -0400)]
APIv4 - Rename `id_field` to `primary_key` and make it an array
Some entities have a combination of primary keys instead of a single field.
This is allowed in the schema so the API needs to be able to handle it too.
Renaming it for consistency with the schema.
colemanw [Sun, 4 Jul 2021 02:09:46 +0000 (22:09 -0400)]
Merge pull request #20748 from seamuslee001/npm_package_updates
[NFC] Update various npm depdencies used only in unit testing
Eileen McNaughton [Sat, 3 Jul 2021 02:17:27 +0000 (14:17 +1200)]
dev/core#27 Move check for phone function to a check
Fixes dev/core#27
colemanw [Sun, 4 Jul 2021 01:24:06 +0000 (21:24 -0400)]
Merge pull request #20759 from eileenmcnaughton/entry4
dev/core#2634 [REF] Move membership date calc from v3 api to BAO
Eileen McNaughton [Thu, 1 Jul 2021 05:50:57 +0000 (17:50 +1200)]
Improve api consistency on custom field creation
Api supports a key 'option_values' by always setting the 'magic' param
option_type to 1. v4 doesn't - but creating option values when creating
a custom field is desirable. This fixes so that the form still
'opts out' if it passes in '2' but otherwise we create the option values
if passed in.
Just a teensy bit less magic in the api layer & bao
Eileen McNaughton [Mon, 24 May 2021 08:29:08 +0000 (20:29 +1200)]
[REF] Move membership date calc from v3 api to BAO
This moves code to calculate membership dates for new memberships from the
v3 api Membership.create and the batch entry membership form to the membership bao.
I think more cleanup could follow this - in the api most obviously and
the BAO is a bit insane still
This has test cover in the v3 api membership test and in
CRM_Batch_Form_EntryTest
Eileen McNaughton [Sat, 3 Jul 2021 02:41:04 +0000 (14:41 +1200)]
Merge pull request #20729 from demeritcowboy/assign-cleanup
[REF] Remove unnecessary variable wrangling in case roles section
Eileen McNaughton [Sat, 3 Jul 2021 01:43:50 +0000 (13:43 +1200)]
Merge pull request #20754 from colemanw/fixContactSummarySmartyUndefinedVars
Fix undefined tpl vars on contact summary page
Coleman Watts [Sat, 3 Jul 2021 00:43:03 +0000 (20:43 -0400)]
Afform - minor fixes
Coleman Watts [Fri, 2 Jul 2021 23:29:24 +0000 (19:29 -0400)]
Fix undefined tpl vars on contact summary page
Matthew Wire [Fri, 2 Jul 2021 19:29:05 +0000 (20:29 +0100)]
Merge pull request #20750 from mattwire/viewrecur
Add missing "View Recurring Contribution" link to contribution view
Matthew Wire [Fri, 2 Jul 2021 11:22:36 +0000 (12:22 +0100)]
View recurring contribution button when displaying lineitems
Seamus Lee [Fri, 2 Jul 2021 01:47:31 +0000 (11:47 +1000)]
Merge pull request #20747 from seamuslee001/part_guard
[REF] Add in template guard for not being always set as per html format
Seamus Lee [Fri, 2 Jul 2021 01:37:53 +0000 (11:37 +1000)]
Merge pull request #20586 from colemanw/is_current
APIv4 - add is_current as a pseudo (calculated) field
Seamus Lee [Fri, 2 Jul 2021 01:00:07 +0000 (01:00 +0000)]
[NFC] Update various npm depdencies used only in unit testing
Seamus Lee [Fri, 2 Jul 2021 00:09:23 +0000 (00:09 +0000)]
[REF] Add in template guard for not being always set as per html format
Regen SQL
Coleman Watts [Sun, 13 Jun 2021 01:36:39 +0000 (21:36 -0400)]
APIv4 - add is_current as a pseudo (calculated) field
This adds the first calculated field to APIv4. It works by injecting a SQL function and aliasing it
with the name of the fake field. This approach allows it to work as part of the WHERE clause
as well as the SELECT clause, even across joins.
Marking the old "is_current" api param deprecated because the field works better.
colemanw [Thu, 1 Jul 2021 22:32:13 +0000 (18:32 -0400)]
Merge pull request #20648 from eileenmcnaughton/ret1
[NFC] Improve use of return parameters in ContributionPage test class
demeritcowboy [Thu, 1 Jul 2021 22:15:52 +0000 (18:15 -0400)]
Merge pull request #20745 from demeritcowboy/test-20602
[NFC] Unit test for 20602
demeritcowboy [Thu, 1 Jul 2021 20:01:11 +0000 (16:01 -0400)]
test for 20602
demeritcowboy [Thu, 1 Jul 2021 19:22:23 +0000 (15:22 -0400)]
Merge pull request #20602 from ixiam/dev#PreserveActivityTabFilter
Fix activity_date_time_relative filter when `preserve_activity_tab_fi…
Monish Deb [Thu, 1 Jul 2021 17:22:25 +0000 (22:52 +0530)]
Merge pull request #20627 from demeritcowboy/currency-fixation
dev/financial#175 - Unable to remove a currency once added
Monish Deb [Thu, 1 Jul 2021 17:07:25 +0000 (22:37 +0530)]
Merge pull request #20744 from
deb1990/RSESPRT-64-fix-profile-submit-api
Support saving more than 25 records in Profile.submit api
Luciano Spiegel [Mon, 14 Jun 2021 17:07:12 +0000 (19:07 +0200)]
fix activity_date_time_relative filter when `preserve_activity_tab_filter` setting is on
Monish Deb [Thu, 1 Jul 2021 16:44:21 +0000 (22:14 +0530)]
Merge pull request #20396 from eileenmcnaughton/entry3
[REF] Remove isPayLater from membership batch screen
Monish Deb [Thu, 1 Jul 2021 16:34:16 +0000 (22:04 +0530)]
Merge pull request #20394 from eileenmcnaughton/entry
[REF] Extend testing on membership batch entry & minor cleanup
colemanw [Thu, 1 Jul 2021 14:51:15 +0000 (10:51 -0400)]
Merge pull request #20676 from eileenmcnaughton/recur
Fix test to use valid financials
colemanw [Thu, 1 Jul 2021 14:49:41 +0000 (10:49 -0400)]
Merge pull request #20742 from eileenmcnaughton/throw
Throw exception rather than fatal
colemanw [Thu, 1 Jul 2021 13:04:53 +0000 (09:04 -0400)]
Merge pull request #20734 from seamuslee001/fix_patch_php8
[REF] Fix trying to access array offset from boolean value
Seamus Lee [Thu, 1 Jul 2021 09:55:40 +0000 (19:55 +1000)]
Merge pull request #20731 from colemanw/apiExplorerWriteJoins
APIv4 Explorer: show joins for write actions
Debarshi Bhaumik [Wed, 30 Jun 2021 10:42:57 +0000 (16:12 +0530)]
RSESPRT-64: Support saving more than 25 records in Profile.submit api
Seamus Lee [Thu, 1 Jul 2021 04:36:03 +0000 (14:36 +1000)]
Merge pull request #20741 from civicrm/5.39
5.39
Seamus Lee [Thu, 1 Jul 2021 02:44:50 +0000 (12:44 +1000)]
Merge pull request #20737 from colemanw/fixUndefinedGroupTree
Fix possibly undefined custom groupTree tpl variable
Seamus Lee [Thu, 1 Jul 2021 02:21:45 +0000 (12:21 +1000)]
Merge pull request #20735 from eileenmcnaughton/tpl
Tpl enotice fix
Seamus Lee [Thu, 1 Jul 2021 02:18:34 +0000 (12:18 +1000)]
Merge pull request #20740 from seamuslee001/5.39
Add release-notes/5.38.1.md
Eileen McNaughton [Thu, 1 Jul 2021 02:17:31 +0000 (14:17 +1200)]
Throw exception rather than fatal
This makes it easier to debug if the entityName is not
resolved - in general this is a dev site issue as it is
to do with load order
Tim Otten [Thu, 1 Jul 2021 01:29:17 +0000 (18:29 -0700)]
Add release-notes/5.38.1.md
demeritcowboy [Thu, 1 Jul 2021 01:28:58 +0000 (21:28 -0400)]
Merge pull request #20717 from seamuslee001/use_civi_event_dispatcher_setup
[REF] Alter new Setup process to use CiviCRM's Event Dispatcher
Eileen McNaughton [Thu, 1 Jul 2021 01:20:30 +0000 (13:20 +1200)]
Remove references to savedFieldMapping in page 2 of the import
I do not believe this is ever assigned and I also don't think it makes sense
if assigned - the first page 'DataSource.tpl' is the one that displays the
option to load a field mapping. This code applies to the second page and
conditionally displays help text which seems to have stopped being true long ago
Coleman Watts [Thu, 1 Jul 2021 01:11:03 +0000 (21:11 -0400)]
Fix possibly undefined custom groupTree tpl variable
Eileen McNaughton [Thu, 1 Jul 2021 00:30:36 +0000 (12:30 +1200)]
Tpl enotice fix
I searched for hideStepNumbers & believe it is never assigned
Seamus Lee [Wed, 30 Jun 2021 22:02:53 +0000 (22:02 +0000)]
[REF] Fix trying to access array offset from boolean value
Seamus Lee [Sun, 27 Jun 2021 23:23:52 +0000 (09:23 +1000)]
[REF] Alter new Setup process to use CiviCRM's Event Dispatcher
Apply patch from Tim to limit what events are dispatched
Coleman Watts [Wed, 30 Jun 2021 20:50:45 +0000 (16:50 -0400)]
Ensure APIv3 EntityRef fields always return the value of the `id_field`.
Usually it's safe to assume the `id_field` === "id", which is automatically returned
by APIv3. However in the case of looking up records by name, etc. we must ensure that value
gets returned.
Coleman Watts [Wed, 30 Jun 2021 20:49:05 +0000 (16:49 -0400)]
APIv4 Explorer - Show joins for write actions
It recently became possible in APIv4 to use joins during write operations;
now that feature is advertised in the Explorer.
Coleman Watts [Wed, 30 Jun 2021 20:48:40 +0000 (16:48 -0400)]
APIv4 explorer - move metadata into .ang.php file
demeritcowboy [Wed, 30 Jun 2021 15:45:28 +0000 (11:45 -0400)]
unnecessary wrangling
demeritcowboy [Wed, 30 Jun 2021 15:15:49 +0000 (11:15 -0400)]
error when sorting table by end date
demeritcowboy [Wed, 30 Jun 2021 15:02:50 +0000 (11:02 -0400)]
Merge pull request #19737 from sunilpawar/show_inactive_active_case_role
dev/core#542 dev/core#1947 - Show inactive active case role for closed cases
colemanw [Wed, 30 Jun 2021 14:45:13 +0000 (10:45 -0400)]
Merge pull request #20724 from colemanw/apiFieldPermissions
APIv4 - Silently ignore non-permissioned fields instead of throwing exceptions
demeritcowboy [Wed, 30 Jun 2021 14:25:13 +0000 (10:25 -0400)]
Merge pull request #20662 from colemanw/contactSummaryImageRegion
Add contact-summary-image region
Matthew Wire [Wed, 30 Jun 2021 13:42:15 +0000 (14:42 +0100)]
Merge pull request #20450 from jaapjansma/dev_financials_6_reports
dev/financial#6 Do not include template contributions in reports
Jaap Jansma [Wed, 30 Jun 2021 11:30:43 +0000 (13:30 +0200)]
dev/financial#6 do not include template contributions in reports
Coleman Watts [Tue, 29 Jun 2021 03:14:32 +0000 (23:14 -0400)]
APIv4 - Silently ignore non-permissioned fields instead of throwing exceptions
Previously the api would throw an exception when the user did not have permission to use a field
in the WHERE or HAVING clause.
Monish Deb [Wed, 30 Jun 2021 06:57:57 +0000 (12:27 +0530)]
Merge pull request #20715 from colemanw/fixFkJoins
APIv4 - Fix same-table joins and remove unused code
Monish Deb [Wed, 30 Jun 2021 06:07:09 +0000 (11:37 +0530)]
Merge pull request #20654 from eileenmcnaughton/part_fix
Fix bug where only one participant registration is completed
Seamus Lee [Wed, 30 Jun 2021 00:05:48 +0000 (10:05 +1000)]
Merge pull request #20726 from colemanw/fixUndefinedTplVars
Fix undefined tpl vars on custom field page