Monish Deb [Mon, 17 Sep 2018 06:01:50 +0000 (11:31 +0530)]
remove upgrade code
deb.monish [Mon, 13 Aug 2018 07:40:47 +0000 (13:10 +0530)]
dev/core#321: Prevent duplicate entries in civicrm_entity_file
Monish Deb [Sat, 11 Aug 2018 14:00:55 +0000 (19:30 +0530)]
Merge pull request #12576 from colemanw/userPerm
Fix CRM_ACL_API::whereClause to respect $contactId param
Eileen McNaughton [Sat, 11 Aug 2018 02:12:00 +0000 (14:12 +1200)]
Merge pull request #12644 from civicrm/5.5
5.5 to master
Eileen McNaughton [Sat, 11 Aug 2018 02:11:32 +0000 (14:11 +1200)]
Merge pull request #12640 from xurizaemon/GL316-cache_key_no_whitespace
(dev/core#316) Fix crash on Memcache systems when session key involves whitespace
Tim Otten [Fri, 10 Aug 2018 22:52:42 +0000 (15:52 -0700)]
dev/core#316 - Update long string cache key test results
This is replaces
95b65673b6259be3a02ed6510e7562939d35b6c8. The intent is to
have a delimiter every ten chars so that it's easy to read/confirm the
length of the string.
The delimiter was space, but this became a longer encoded char (`-20`)
and threw off the numbers. Switching to dash just gives a different encoded char.
To get the counts right, it needs ot be a pass-through char... like underscore.
Seamus Lee [Fri, 10 Aug 2018 22:11:50 +0000 (08:11 +1000)]
Merge pull request #12631 from JMAConsulting/dev-access-10-1
dev/accessibility#10 : Moved datepicker widget to a separate file
Tim Otten [Fri, 10 Aug 2018 19:43:02 +0000 (12:43 -0700)]
(NFC) CRM_Utils_Cache::create - Update docblock for 'name' param
deb.monish [Tue, 7 Aug 2018 13:25:32 +0000 (18:55 +0530)]
Move datepicker widget to a separate file
Chris Burgess [Fri, 10 Aug 2018 11:55:14 +0000 (23:55 +1200)]
Issue #316: Update long string cache key test results
Chris Burgess [Fri, 10 Aug 2018 11:44:34 +0000 (23:44 +1200)]
Issue #316: Ensure Container caches have safe prefixes
Chris Burgess [Fri, 10 Aug 2018 10:11:54 +0000 (22:11 +1200)]
Issue #316: Expand cache key test coverage with emoji
Chris Burgess [Fri, 10 Aug 2018 10:05:55 +0000 (22:05 +1200)]
Issue #316: Update tests for whitespace escaping
Chris Burgess [Thu, 9 Aug 2018 21:23:04 +0000 (09:23 +1200)]
Avoid calling Cache::cleanKey() twice in quick succession
Since this method is performance related and called frequently,
no need to recalculate results from preg_replace_callback() with
the same inputs.
Chris Burgess [Thu, 9 Aug 2018 21:21:59 +0000 (09:21 +1200)]
Issue #316: Exclude spaces from cache keys for Memcache compatibility
- https://lab.civicrm.org/dev/core/issues/316
- https://github.com/memcached/memcached/blob/master/doc/protocol.txt
Eileen McNaughton [Thu, 9 Aug 2018 09:54:06 +0000 (21:54 +1200)]
Merge pull request #12603 from jitendrapurohit/core-295
dev/core#295 - Allow default 'from' email to be set in New email form
Eileen McNaughton [Thu, 9 Aug 2018 03:34:21 +0000 (15:34 +1200)]
Merge pull request #12594 from eileenmcnaughton/sales_tax_trait
Minor refactor, use sales tax trait to simplify sales tax functions
Eileen McNaughton [Wed, 8 Aug 2018 21:46:22 +0000 (09:46 +1200)]
Merge pull request #12633 from seamuslee001/symfony_upgrade
Upgrade symfony in lockfile to be 2.8 which is supported version of 2…
colemanw [Wed, 8 Aug 2018 02:27:49 +0000 (22:27 -0400)]
Merge pull request #12619 from mattwire/caseview_contactlink
Make contact name into a link on Manage Case for single client
Seamus Lee [Wed, 8 Aug 2018 01:06:37 +0000 (11:06 +1000)]
Update Unit test to ensure it locks in 2.8 and include polyfil
Seamus Lee [Tue, 7 Aug 2018 22:38:01 +0000 (08:38 +1000)]
Upgrade symfony in lockfile to be 2.8 which is supported version of 2.x series
Matthew Wire (MJW Consulting) [Fri, 3 Aug 2018 16:26:41 +0000 (17:26 +0100)]
Make contact name into a link on Manage Case for single client
Eileen McNaughton [Tue, 7 Aug 2018 07:47:49 +0000 (19:47 +1200)]
Merge pull request #12630 from eileenmcnaughton/comment_bool
[NFC] comment fixes relating to doc blocks, spelling
Eileen McNaughton [Tue, 7 Aug 2018 04:41:08 +0000 (16:41 +1200)]
Merge pull request #12629 from KarinG/FinancialAuditAddTests
Follow up on #12611 - adding in three data-integrity assertions.
eileen [Tue, 7 Aug 2018 04:25:54 +0000 (16:25 +1200)]
[NFC] comment fixes relating to doc blocks, spelling
Seamus Lee [Tue, 7 Aug 2018 04:08:15 +0000 (14:08 +1000)]
Merge pull request #12627 from eileenmcnaughton/caching_pp
Use cached version of payment processor.
Seamus Lee [Tue, 7 Aug 2018 04:07:48 +0000 (14:07 +1000)]
Merge pull request #12559 from eileenmcnaughton/activity_part_2
Activity display, switch to more performance getActivities function (from deprecatedGetActivities)
KarinG [Tue, 7 Aug 2018 01:40:36 +0000 (19:40 -0600)]
Follow up on #12611 - adding in three data-integrity assertions.
Eileen McNaughton [Mon, 6 Aug 2018 20:49:17 +0000 (08:49 +1200)]
Merge pull request #12444 from mattwire/fixduplicatecaseactivities
dev/core#245 Fix duplicate activities showing on case activities tab when they have multiple target/assignee contacts
Eileen McNaughton [Mon, 6 Aug 2018 19:48:02 +0000 (07:48 +1200)]
Merge pull request #12625 from colemanw/recVer
Bump recommended php version to 7.1 and min recommended to 7.0
eileen [Mon, 6 Aug 2018 06:40:32 +0000 (18:40 +1200)]
Use cached version of payment processor.
I am hitting a slightly obscure bug in Redis that is solved by this change.
Per https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/55
we have an issue whereby Omnipay adds the gateway to a variable on class when processing payments.
In some cases this gateway will not serialize into a key under Redis causing a fatal.
However, we don't really need it to - the payment processor that we are aiming to cache is
'as loaded' not 'as used'. The caching of the processors appears to have been removed in
the past because of issues around domains -however, I think we can get
past that by changing the cache key.
Jitendra Purohit [Tue, 31 Jul 2018 11:25:05 +0000 (16:55 +0530)]
dev/core#295 - Allow default 'from' email to be set in New email form
colemanw [Mon, 6 Aug 2018 01:50:14 +0000 (21:50 -0400)]
Merge pull request #12620 from mattwire/fileoncase_activityparams
Don't duplicate activity when filing on case
Seamus Lee [Sun, 5 Aug 2018 22:18:36 +0000 (08:18 +1000)]
Merge pull request #12609 from mattwire/joomla_cron_timezone
Make sure Joomla timezone is set for cron jobs
Eileen McNaughton [Sun, 5 Aug 2018 21:15:38 +0000 (09:15 +1200)]
Merge pull request #12611 from KarinG/FinancialAudit
[PHPUnit test only] Adding in assertions re: Line Item and Contribution data-integrity.
Coleman Watts [Sat, 4 Aug 2018 22:30:38 +0000 (18:30 -0400)]
Bump recommended php version to 7.1 and min recommended to 7.0
KarinG [Sat, 4 Aug 2018 15:19:59 +0000 (09:19 -0600)]
Add comments
colemanw [Sat, 4 Aug 2018 13:02:13 +0000 (09:02 -0400)]
Merge pull request #12612 from eileenmcnaughton/more_lower
Further removal of instance of using LOWER() rather than relying on mysql non-case-sensitivity.
colemanw [Sat, 4 Aug 2018 01:35:20 +0000 (21:35 -0400)]
Merge pull request #12621 from JKingsnorth/remove-unused-vars-process-parti
Remove unused variables from process_participants job
colemanw [Sat, 4 Aug 2018 00:28:16 +0000 (20:28 -0400)]
Merge pull request #12608 from eileenmcnaughton/export_sigs
Stop passing imProviders & phoneTypes - use CRM_Core_PseudoConstant:getLabel
Eileen McNaughton [Fri, 3 Aug 2018 23:09:28 +0000 (11:09 +1200)]
Merge pull request #12026 from michaelmcandrew/pass-mailingJobId-to-hookTokenValues
pass mailingJobId to hook_tokenValues
JKingsnorth [Fri, 3 Aug 2018 22:25:23 +0000 (23:25 +0100)]
Remove unused variables
Matthew Wire (MJW Consulting) [Fri, 3 Aug 2018 16:31:17 +0000 (17:31 +0100)]
Set activity params correctly when filing an activity on case
eileen [Thu, 2 Aug 2018 02:02:06 +0000 (14:02 +1200)]
Further removal of instance of using LOWER() rather than relying on mysql non-case-sensitivity.
Note I could not find any way to call this so I added deprecation notices
Per #12494 the use of LOWER
hurts performance
fails to return results on some char sets
messes with REGEX
This is part of a continued (we removed from contribution search fields last year)
staggered approach to removing this old mechanism
Eileen McNaughton [Fri, 3 Aug 2018 08:33:52 +0000 (20:33 +1200)]
Merge pull request #12618 from colemanw/teenly
Fix teeny typo
Coleman Watts [Fri, 3 Aug 2018 04:28:34 +0000 (00:28 -0400)]
Fix teeny typo
Eileen McNaughton [Fri, 3 Aug 2018 03:36:53 +0000 (15:36 +1200)]
Merge pull request #12617 from civicrm/5.5
5.5
Seamus Lee [Fri, 3 Aug 2018 03:28:23 +0000 (13:28 +1000)]
Merge pull request #12616 from eileenmcnaughton/report_date
Test fix, update activity report adds a this.month filter by default, accomodate
eileen [Thu, 2 Aug 2018 23:33:44 +0000 (11:33 +1200)]
Test fix, update activity report adds a this.month fiter by default so make dates movable.
I also put time at the end of the day to avoid bounciness on status being overdue
colemanw [Thu, 2 Aug 2018 09:08:16 +0000 (05:08 -0400)]
Merge pull request #12595 from eileenmcnaughton/payment_processor_domain
API : Set current domain as a sensible default for payment processor
Tim Otten [Thu, 2 Aug 2018 01:26:48 +0000 (18:26 -0700)]
Merge remote-tracking branch 'origin/5.5'
Tim Otten [Wed, 1 Aug 2018 21:03:16 +0000 (14:03 -0700)]
5.4.0.md - Tweak cache notes
Andrew Hunt [Wed, 1 Aug 2018 03:38:58 +0000 (23:38 -0400)]
5.4.0 release notes (#12605)
* 5.4.0 release notes: raw from script
* 5.4.0 release notes: added boilerplate
* 5.4.0 release notes: finished documenting changes
* 5.4.0 release notes: updated contributors
CiviCRM [Thu, 2 Aug 2018 01:18:07 +0000 (01:18 +0000)]
Set version to 5.6.alpha1
CiviCRM [Thu, 2 Aug 2018 01:06:54 +0000 (01:06 +0000)]
Set version to 5.5.beta1
Eileen McNaughton [Wed, 1 Aug 2018 21:16:31 +0000 (09:16 +1200)]
Merge pull request #12607 from colemanw/caseDetails
dev/core#289 - Fix links on case dashboard
Eileen McNaughton [Wed, 1 Aug 2018 21:15:03 +0000 (09:15 +1200)]
Merge pull request #12610 from mattwire/recurtab_sort_desc
dev/core/issues/277 Sort recurring contributions by newest first
colemanw [Wed, 1 Aug 2018 16:36:39 +0000 (12:36 -0400)]
Merge pull request #12606 from JMAConsulting/custom-value-update
Customvalue ID is ignored
KarinG [Wed, 1 Aug 2018 16:11:17 +0000 (10:11 -0600)]
for Jenkins.
KarinG [Wed, 1 Aug 2018 14:34:07 +0000 (08:34 -0600)]
remove Initials.
KarinG [Wed, 1 Aug 2018 14:22:22 +0000 (08:22 -0600)]
Adding in assertions re: lineItem and Contribution data-integrity.
Matthew Wire [Sun, 8 Jul 2018 17:20:30 +0000 (18:20 +0100)]
Fix duplicate activities showing on case activities tab when they have multiple target/assignee contacts
Matthew Wire (MJW Consulting) [Wed, 1 Aug 2018 09:58:56 +0000 (10:58 +0100)]
Sort recurring contributions by newest first
Matthew Wire (MJW Consulting) [Wed, 1 Aug 2018 09:39:18 +0000 (10:39 +0100)]
Make sure Joomla timezone is set for cron jobs
Eileen McNaughton [Wed, 1 Aug 2018 07:43:39 +0000 (19:43 +1200)]
Merge pull request #12558 from totten/master-prevnext-misc
(dev/core#217) PrevNext - Allow swapping getPositions (etal) for contact-search
eileen [Wed, 1 Aug 2018 04:48:14 +0000 (16:48 +1200)]
Stop passing imProviders & phoneTypes - use CRM_Core_PseudoConstant::getLabel(
Note this function is called once per export - not per row
colemanw [Wed, 1 Aug 2018 04:25:23 +0000 (00:25 -0400)]
Merge pull request #12587 from eileenmcnaughton/header_test
Export - add tests out header output, move phone_type_id to metadata
colemanw [Wed, 1 Aug 2018 04:17:26 +0000 (00:17 -0400)]
Merge pull request #12585 from eileenmcnaughton/param_passing
Stdise references to BAO_Query->_fields [nfc]
Coleman Watts [Wed, 1 Aug 2018 04:12:17 +0000 (00:12 -0400)]
Fix activity edit link
Coleman Watts [Wed, 1 Aug 2018 02:37:16 +0000 (22:37 -0400)]
dev/core#289 - Fix caseId url param
Eileen McNaughton [Tue, 31 Jul 2018 22:11:56 +0000 (10:11 +1200)]
Merge pull request #12553 from pradpnayak/77
dev/core/issues/277, Fixed count to include only live recurring contr…
Eileen McNaughton [Tue, 31 Jul 2018 21:56:04 +0000 (09:56 +1200)]
Merge pull request #12602 from colemanw/checkIfFieldExists
NFC - Deprecate duplicate function
colemanw [Tue, 31 Jul 2018 20:01:05 +0000 (16:01 -0400)]
Merge pull request #12604 from tschuettler/296-custom-value-return-field
api - CustomValue::get - add handling for comma separated return fields
deb.monish [Tue, 31 Jul 2018 19:47:10 +0000 (01:17 +0530)]
Customvalue ID is ignored
Thomas [Tue, 31 Jul 2018 14:13:01 +0000 (16:13 +0200)]
Explode return values if it is not already an array.
Thomas [Tue, 31 Jul 2018 14:10:51 +0000 (16:10 +0200)]
Add unit tests for CustomValueGet return fields
eileen [Mon, 30 Jul 2018 10:46:59 +0000 (22:46 +1200)]
Stop passing relationQuery object now it is not required
eileen [Sat, 28 Jul 2018 04:29:16 +0000 (16:29 +1200)]
Stdise references to BAO_Query->_fields [nfc]
Eileen McNaughton [Mon, 30 Jul 2018 20:14:48 +0000 (08:14 +1200)]
Merge pull request #12596 from eileenmcnaughton/export_ref
[NFC] Export - don't pass arrays as reference when they are not changed
Eileen McNaughton [Mon, 30 Jul 2018 20:03:00 +0000 (08:03 +1200)]
Merge pull request #12591 from eileenmcnaughton/membership_type
Towards using EntityForm.tpl for Membership type & enabling custom data
Eileen McNaughton [Mon, 30 Jul 2018 19:55:26 +0000 (07:55 +1200)]
Merge pull request #12600 from tschuettler/293-geocoding
Skip check for format method when there is no valid geocoding provider
eileen [Mon, 30 Jul 2018 00:47:29 +0000 (12:47 +1200)]
Minor refactor, use sales tax trait to simplify sales tax functions
Coleman Watts [Mon, 30 Jul 2018 15:58:03 +0000 (11:58 -0400)]
Stricter validation for checkIfFieldExists
Coleman Watts [Mon, 30 Jul 2018 15:52:05 +0000 (11:52 -0400)]
NFC - Deprecate duplicate function
Thomas [Mon, 30 Jul 2018 14:52:14 +0000 (16:52 +0200)]
Skip check for format method when there is no valid geocoding provider
eileen [Mon, 30 Jul 2018 11:11:48 +0000 (23:11 +1200)]
Export - don't pass arrays as reference when they are not changed
eileen [Sat, 28 Jul 2018 05:35:42 +0000 (17:35 +1200)]
Move definition of phone_type_id to the xml.
This has the side effect of making it such that it only gets 16 char rather than 255. I thnk this is 'ok' here but there is a separate issue open to increase the varchar for all fields on export
eileen [Sat, 28 Jul 2018 05:00:42 +0000 (17:00 +1200)]
Add tests for header output
Seamus Lee [Mon, 30 Jul 2018 10:15:04 +0000 (20:15 +1000)]
Merge pull request #12535 from eileenmcnaughton/export_participant_test
Export Add unit test + minor refactor covering specifiable payment output fields for participant export.
eileen [Mon, 30 Jul 2018 05:51:40 +0000 (17:51 +1200)]
Set current domain as a sensible default for payment processor domain
Eileen McNaughton [Sun, 29 Jul 2018 22:17:17 +0000 (10:17 +1200)]
Merge pull request #12592 from civicrm/5.4
5.4 to master
Eileen McNaughton [Sun, 29 Jul 2018 22:16:23 +0000 (10:16 +1200)]
Merge pull request #12590 from totten/5.4-flushcache
(dev/core#284) System::flushCache - Reproduce legacy cache behavior. Improve test performance.
eileen [Sun, 29 Jul 2018 04:30:52 +0000 (16:30 +1200)]
Remove some fields from the form to rely on EntityTrait
eileen [Sun, 29 Jul 2018 04:25:36 +0000 (16:25 +1200)]
Convert 'name' & 'description' to use the entity Fields format.
Note that doing a partial conversion in the template is just a stepping stone to using the
EntityField template, when lots of fields need conversion / review it allows us to break it up
Simplify converstion of fields, convert 2 more
eileen [Sun, 29 Jul 2018 04:12:42 +0000 (16:12 +1200)]
Define entity data for membership type form
Eileen McNaughton [Sun, 29 Jul 2018 02:43:20 +0000 (14:43 +1200)]
Merge pull request #12589 from seamuslee001/password_size
dev/core#291 Allow for field size to be set for password fields
Tim Otten [Sat, 28 Jul 2018 22:31:20 +0000 (15:31 -0700)]
Overview
----------------------------------------
`CRM_Utils_System::flushCache()` calls `CRM_Utils_Cache::singleton()->flush()`.
In `5.3`, this triggered a cascading effect; in development of `5.4.alpha`,
some of the cascades were overzealous and we revised to get tighter control
over cascading.
With an aim to being conservative and reproducing old behavior, I previously
patched `5.4.alpha` to add several extra flushes and simulate the old cascades.
However, it wasn't really as conservative as hoped -- because the "old
behavior" depended on the environment. This patch brings us closer the "old
behavior".
See also: https://lab.civicrm.org/dev/core/issues/284
Before (Behavior in version <=`5.3`)
----------------------------------------
On systems with memory-backed caches, `flushCache()` had an aggressive
cascading side-effect where several named caches (`settings`, etc) were also
flushed.
On systems with a default configuration (SQL+ArrayCache), `flushCache()` had a
very limited cascading effect -- it *only cleared the in-process ArrayCache*.
The bulk of the cache content was preserved in SQL.
Before (Behavior in version ~= `5.4.alpha`)
----------------------------------------
To simulate the cascading effect, `flushCache()` explicitly flushes a
half-dozen individual caches. (These half-dozen are chosen to match the old
cascade list and exclude some new things which would problematic.)
On systems with memory-backed caches, this reproduces the aggressive cascading
effect.
On systems with a default configuration (SQL+ArrayCache), this amplifies the
flushing -- because it also destroys the underlying SQL caches.
This has the side-effect of significantly degrading performance of the test
suite.
After (Behavior with patch)
----------------------------------------
`CRM_Utils_System::flushCache` calls `CRM_Utils_Cache::singleton()->flush()`.
To simulate the cascading effect, `flushCache()` explicitly flushes a
half-dozen individual caches... *but only on memory-backed* systems.
On systems with memory-backed caches, this reproduces the aggressive cascading
effect.
On systems with a default configuration (SQL+ArrayCache), this is closer to the
old behavior. The bulk of the cache remains available in SQL.
Based on local spot-checking, this restores performance of the test suite.
Comments
----------------------------------------
Deep down, I don't really believe the cascading effect is a good thing. At
some point, I'd rather just remove these bits. But in absence of a crystal
ball to predict the side-effects of that, I think it's good to find a better
approximation of the old behavior.
Eileen McNaughton [Sat, 28 Jul 2018 23:05:41 +0000 (11:05 +1200)]
Merge pull request #12588 from mattwire/5.4_backportcasefixes
Backport "Fix regression on case export" to 5.4
Seamus Lee [Sat, 28 Jul 2018 22:22:52 +0000 (08:22 +1000)]
dev/core#291 Allow for field size to be set for password fields
eileen [Thu, 19 Jul 2018 22:47:44 +0000 (10:47 +1200)]
Fix regression on case export from recent export fix
https://github.com/civicrm/civicrm-core/commit/
3b4adc92793dccfa446cf66f0740edb543f110d7 changed the way componentmode is defined
It now seems inconsistent