civicrm-core.git
2 years agoMake activity_type_id available to links, test
Eileen McNaughton [Tue, 14 Feb 2023 02:35:19 +0000 (15:35 +1300)]
Make activity_type_id available to links, test

2 years agoMerge pull request #25564 from eileenmcnaughton/activity_links
demeritcowboy [Tue, 14 Feb 2023 03:19:57 +0000 (22:19 -0500)]
Merge pull request #25564 from eileenmcnaughton/activity_links

Preliminary cleanup, comments, type hints

2 years agoPreliminary cleanup, comments, type hints
Eileen McNaughton [Tue, 14 Feb 2023 02:00:48 +0000 (15:00 +1300)]
Preliminary cleanup, comments, type hints

2 years agoMerge pull request #25329 from herbdool/core-4076
demeritcowboy [Mon, 13 Feb 2023 21:33:16 +0000 (16:33 -0500)]
Merge pull request #25329 from herbdool/core-4076

dev/core#4076 split up the theme method

2 years agoMerge pull request #25554 from demeritcowboy/upgrade-crash
Eileen McNaughton [Mon, 13 Feb 2023 20:25:46 +0000 (09:25 +1300)]
Merge pull request #25554 from demeritcowboy/upgrade-crash

Fix fatal error on upgrade success screen

2 years agodev/core#4076 split up the theme method
Herb v/d Dool [Wed, 11 Jan 2023 21:55:20 +0000 (16:55 -0500)]
dev/core#4076 split up the theme method

2 years agoMerge pull request #25560 from mlutfy/mailingSummaryPseudo
Yashodha Chaku [Mon, 13 Feb 2023 12:17:42 +0000 (17:47 +0530)]
Merge pull request #25560 from mlutfy/mailingSummaryPseudo

Mailing Summary Report: support pseudofields

2 years agoMerge pull request #25562 from braders/properties-emailtest
Seamus Lee [Sun, 12 Feb 2023 23:43:46 +0000 (10:43 +1100)]
Merge pull request #25562 from braders/properties-emailtest

[REF][PHP8.2] Remove use of dynamic properties in CRM_Contact_Form_Task_EmailTest

2 years ago[REF][PHP8.2] Remove use of dynamic properties in CRM_Contact_Form_Task_EmailTest
Bradley Taylor [Sun, 12 Feb 2023 13:32:53 +0000 (13:32 +0000)]
[REF][PHP8.2] Remove use of dynamic properties in CRM_Contact_Form_Task_EmailTest

2 years agoMerge pull request #25561 from braders/dynamic-properties-authorize-net-test
demeritcowboy [Sat, 11 Feb 2023 23:10:21 +0000 (18:10 -0500)]
Merge pull request #25561 from braders/dynamic-properties-authorize-net-test

[REF][PHP8.2] Get rid of dynamic properties in CRM_Core_Payment_AuthorizeNetTest

2 years ago[REF][PHP8.2] Get rid of dynamic properties in CRM_Core_Payment_AuthorizeNetTest
Bradley Taylor [Sat, 11 Feb 2023 19:14:18 +0000 (19:14 +0000)]
[REF][PHP8.2] Get rid of dynamic properties in CRM_Core_Payment_AuthorizeNetTest

2 years agoMailing Summary Report: support pseudofields
Mathieu Lutfy [Sat, 11 Feb 2023 17:52:09 +0000 (12:52 -0500)]
Mailing Summary Report: support pseudofields

2 years agoMerge pull request #25559 from braders/dynamic-property-additionalpaymenttest
demeritcowboy [Sat, 11 Feb 2023 17:06:12 +0000 (12:06 -0500)]
Merge pull request #25559 from braders/dynamic-property-additionalpaymenttest

[REF][PHP8.2] Stop use of dynamic property in AdditionalPaymentTest

2 years agoMerge pull request #25558 from braders/dynmaic-property-ajaxtest
demeritcowboy [Sat, 11 Feb 2023 17:05:40 +0000 (12:05 -0500)]
Merge pull request #25558 from braders/dynmaic-property-ajaxtest

[REF][PHP8.2] Use variable instead of dynmaic property (CRM_Group_Page_AjaxTest)

2 years agoMerge pull request #25557 from braders/pledge-block-test-property
demeritcowboy [Sat, 11 Feb 2023 17:05:28 +0000 (12:05 -0500)]
Merge pull request #25557 from braders/pledge-block-test-property

[REF][PHP8.2] Declare property in CRM_Pledge_BAO_PledgeBlockTest

2 years agoMerge pull request #25556 from braders/fake-object-php8.2
demeritcowboy [Sat, 11 Feb 2023 17:05:18 +0000 (12:05 -0500)]
Merge pull request #25556 from braders/fake-object-php8.2

[REF][PHP8.2] Declare property in CRM_Utils_FakeObject

2 years ago[REF][PHP8.2] Stop use of dynamic property in AdditionalPaymentTest
Bradley Taylor [Sat, 11 Feb 2023 15:43:09 +0000 (15:43 +0000)]
[REF][PHP8.2] Stop use of dynamic property in AdditionalPaymentTest

2 years ago[REF][PHP8.2] Use variable instead of dynmaic property (CRM_Group_Page_AjaxTest)
Bradley Taylor [Sat, 11 Feb 2023 15:36:00 +0000 (15:36 +0000)]
[REF][PHP8.2] Use variable instead of dynmaic property (CRM_Group_Page_AjaxTest)

2 years ago[REF][PHP8.2] Declare property in CRM_Pledge_BAO_PledgeBlockTest
Bradley Taylor [Sat, 11 Feb 2023 15:26:04 +0000 (15:26 +0000)]
[REF][PHP8.2] Declare property in CRM_Pledge_BAO_PledgeBlockTest

2 years agoMerge pull request #25514 from eileenmcnaughton/smarty-search
demeritcowboy [Sat, 11 Feb 2023 13:53:42 +0000 (08:53 -0500)]
Merge pull request #25514 from eileenmcnaughton/smarty-search

A couple of minor smarty notice fixes

2 years ago[REF][PHP8.2] Declare property in CRM_Utils_FakeObject
Bradley Taylor [Sat, 11 Feb 2023 13:36:22 +0000 (13:36 +0000)]
[REF][PHP8.2] Declare property in CRM_Utils_FakeObject

2 years agoMerge pull request #25551 from eileenmcnaughton/tokens
demeritcowboy [Sat, 11 Feb 2023 04:52:07 +0000 (23:52 -0500)]
Merge pull request #25551 from eileenmcnaughton/tokens

Upgrade test to use more recent methodology for testing forms

2 years agofix fatal error
demeritcowboy [Sat, 11 Feb 2023 04:45:10 +0000 (23:45 -0500)]
fix fatal error

2 years agoMerge pull request #25544 from eileenmcnaughton/smarty_tpl
Tim Otten [Sat, 11 Feb 2023 01:19:36 +0000 (17:19 -0800)]
Merge pull request #25544 from eileenmcnaughton/smarty_tpl

Smarty notice fix

2 years agoUpgrade test to use more recent methodology for testing forms
Eileen McNaughton [Fri, 10 Feb 2023 21:57:48 +0000 (10:57 +1300)]
Upgrade test to use more recent methodology for testing forms

The tested class had been hacked to accept parameters to postProcess,
but we can now avoid that & it will likely be rejected in a later php
version / muddy the waters

2 years agoA couple of minor smarty notice fixes
Eileen McNaughton [Mon, 6 Feb 2023 21:33:13 +0000 (10:33 +1300)]
A couple of minor smarty notice fixes

2 years agoMerge pull request #25519 from eileenmcnaughton/gettree2
Yashodha Chaku [Fri, 10 Feb 2023 03:07:52 +0000 (08:37 +0530)]
Merge pull request #25519 from eileenmcnaughton/gettree2

Remove always-NULL `$singleRecord` variable

2 years agoMerge pull request #25546 from eileenmcnaughton/smarty_pledge
Eileen McNaughton [Fri, 10 Feb 2023 02:51:07 +0000 (15:51 +1300)]
Merge pull request #25546 from eileenmcnaughton/smarty_pledge

Enotice fix, pledge block on UserDashboard

2 years agoEnotice fix, pledge block on UserDashboard
Eileen McNaughton [Fri, 10 Feb 2023 00:17:51 +0000 (13:17 +1300)]
Enotice fix, pledge block on UserDashboard

2 years agoMerge pull request #25521 from colemanw/actionsMenu
Eileen McNaughton [Thu, 9 Feb 2023 23:59:12 +0000 (12:59 +1300)]
Merge pull request #25521 from colemanw/actionsMenu

SearchKit - Configurable action menu tasks per-search-display

2 years agoSmarty notice fix
Eileen McNaughton [Thu, 9 Feb 2023 23:24:32 +0000 (12:24 +1300)]
Smarty notice fix

2 years agoMerge pull request #25541 from eileenmcnaughton/null_obj
Yashodha Chaku [Thu, 9 Feb 2023 11:16:53 +0000 (16:46 +0530)]
Merge pull request #25541 from eileenmcnaughton/null_obj

Do not use reference for Object parameter, death to `_NULLObject`

2 years agoFix notice, do not pass values that match defaults
Eileen McNaughton [Thu, 9 Feb 2023 07:22:13 +0000 (20:22 +1300)]
Fix notice, do not pass values that match defaults

2 years agoMerge pull request #25540 from eileenmcnaughton/world
Eileen McNaughton [Thu, 9 Feb 2023 05:53:48 +0000 (18:53 +1300)]
Merge pull request #25540 from eileenmcnaughton/world

Remove invalid  'world_region' => 'India' from test

2 years agoDo not use reference for Object parameter, deathto _NULlObject
Eileen McNaughton [Thu, 9 Feb 2023 05:02:14 +0000 (18:02 +1300)]
Do not use reference for Object parameter, deathto _NULlObject

2 years agoRemove invalid 'world_region' => 'India' from test
Eileen McNaughton [Thu, 9 Feb 2023 04:51:37 +0000 (17:51 +1300)]
Remove invalid  'world_region' => 'India' from test

2 years agoSearchKit - Configurable action menu tasks per-search-display
Coleman Watts [Tue, 7 Feb 2023 23:24:57 +0000 (18:24 -0500)]
SearchKit - Configurable action menu tasks per-search-display

2 years agoMerge pull request #25537 from eileenmcnaughton/database
Seamus Lee [Thu, 9 Feb 2023 01:49:10 +0000 (12:49 +1100)]
Merge pull request #25537 from eileenmcnaughton/database

Fix a couple more places to use mysql DATABASE() function

2 years agoMerge pull request #25538 from civicrm/5.59
Seamus Lee [Thu, 9 Feb 2023 01:48:48 +0000 (12:48 +1100)]
Merge pull request #25538 from civicrm/5.59

5.59

2 years agoMerge pull request #25539 from demeritcowboy/query
colemanw [Thu, 9 Feb 2023 01:19:21 +0000 (20:19 -0500)]
Merge pull request #25539 from demeritcowboy/query

Typo executequery => executeQuery

2 years agotypo
demeritcowboy [Thu, 9 Feb 2023 00:44:16 +0000 (19:44 -0500)]
typo

2 years agoMerge pull request #25534 from totten/5.59-test-tz
demeritcowboy [Thu, 9 Feb 2023 00:41:35 +0000 (19:41 -0500)]
Merge pull request #25534 from totten/5.59-test-tz

CiviTestListener - Headless tests should initialize timezone

2 years agoMerge pull request #25524 from eileenmcnaughton/finder_test
demeritcowboy [Thu, 9 Feb 2023 00:37:59 +0000 (19:37 -0500)]
Merge pull request #25524 from eileenmcnaughton/finder_test

NFC cleanup in test class

2 years agoFix a couple more places to use mysql DATABASE() function
Eileen McNaughton [Wed, 8 Feb 2023 22:59:12 +0000 (11:59 +1300)]
Fix a couple more places to use mysql DATABASE() function

2 years agoCiviTestListener - Headless tests should have initialized timezone
Tim Otten [Wed, 8 Feb 2023 22:47:51 +0000 (14:47 -0800)]
CiviTestListener - Headless tests should have initialized timezone

Before
------

* `CiviUnitTestCase` calls `setMySQLTimeZone()`
* Headless tests (which are initialized via `CiviTestListener`) do not call `setMySQLTimeZone()`
* If you have a test like 5.57's flavor of `QueueTest`, then the tests pass or fail depending on happenstance of server timezone configuration.

After
-----

* `CiviUnitTestCase` and `CiviTestListener` both call `setMySQLTimeZone()`
* If you have a test like 5.57's flavor of `QueueTest`, then the tests pass more consistently.

Comments
--------

This branch should work cleanly as PR for `5.59` (rc) or `master`.  I'd
rather like to use this in `5.57-esr` (so that tests run more cleanly).
So maybe `5.59` is the better target (but it doesn't strictly have to be).

2 years agoMerge pull request #25530 from eileenmcnaughton/database
Seamus Lee [Wed, 8 Feb 2023 22:47:03 +0000 (09:47 +1100)]
Merge pull request #25530 from eileenmcnaughton/database

Use mysql DATABASE() function instead of php code

2 years agoNFC cleanup in test class
Eileen McNaughton [Wed, 8 Feb 2023 02:16:36 +0000 (15:16 +1300)]
NFC cleanup in test class

2 years agoMerge pull request #25531 from civicrm/5.59
Eileen McNaughton [Wed, 8 Feb 2023 22:12:05 +0000 (11:12 +1300)]
Merge pull request #25531 from civicrm/5.59

5.59

2 years agoUse mysql DATABASE() function instead of php code
Eileen McNaughton [Wed, 8 Feb 2023 20:01:10 +0000 (09:01 +1300)]
Use mysql DATABASE() function instead of php code

2 years agoMerge pull request #25528 from eileenmcnaughton/database
Yashodha Chaku [Wed, 8 Feb 2023 13:48:13 +0000 (19:18 +0530)]
Merge pull request #25528 from eileenmcnaughton/database

Use `DATABASE()` function rather than lossa code

2 years agoMerge pull request #25525 from seamuslee001/group_filter_acl
Yashodha Chaku [Wed, 8 Feb 2023 11:13:40 +0000 (16:43 +0530)]
Merge pull request #25525 from seamuslee001/group_filter_acl

dev/core#4068 Prevent adding in addSelectWhereClause for civicrm_group when filtering by a group as unneded for reports

2 years agodev/core#4068 Expand test coverage to include the contact summary report which is...
Seamus Lee [Wed, 8 Feb 2023 03:26:56 +0000 (14:26 +1100)]
dev/core#4068 Expand test coverage to include the contact summary report which is a non optimised report template

2 years agodev/core#4068 Prevent adding in addSelectWhereClause for civicrm_group when filtering...
Seamus Lee [Wed, 8 Feb 2023 02:40:19 +0000 (13:40 +1100)]
dev/core#4068 Prevent adding in addSelectWhereClause for civicrm_group when filtering by a group as unneded for reports

Add in failing test to demonstrate issue with Group add SelectWhereClause on reports

2 years agoMerge pull request #24861 from eileenmcnaughton/dash
Yashodha Chaku [Wed, 8 Feb 2023 05:48:18 +0000 (11:18 +0530)]
Merge pull request #24861 from eileenmcnaughton/dash

Enotice fix on userDashboard with contributions, replace deprecated functions with api4v calls

2 years agoUse DATABASE function rather than lossa code
Eileen McNaughton [Wed, 8 Feb 2023 05:00:38 +0000 (18:00 +1300)]
Use DATABASE function rather than lossa code

2 years agoMerge pull request #25526 from civicrm/5.59
Seamus Lee [Wed, 8 Feb 2023 04:45:25 +0000 (15:45 +1100)]
Merge pull request #25526 from civicrm/5.59

5.59

2 years agoMerge pull request #25523 from demeritcowboy/dompdf-559
demeritcowboy [Wed, 8 Feb 2023 03:33:48 +0000 (22:33 -0500)]
Merge pull request #25523 from demeritcowboy/dompdf-559

Backport 25520

2 years agoBump dompdf/dompdf from 2.0.2 to 2.0.3
dependabot[bot] [Tue, 7 Feb 2023 23:51:27 +0000 (23:51 +0000)]
Bump dompdf/dompdf from 2.0.2 to 2.0.3

Dependabot couldn't find the original pull request head commit, 889dfb1c9efc4cba2f79ab4088c30fe6774c0835.

2 years agoMerge pull request #25520 from civicrm/dependabot/composer/dompdf/dompdf-2.0.3
Eileen McNaughton [Wed, 8 Feb 2023 01:38:04 +0000 (14:38 +1300)]
Merge pull request #25520 from civicrm/dependabot/composer/dompdf/dompdf-2.0.3

Bump dompdf/dompdf from 2.0.2 to 2.0.3

2 years agoMerge pull request #25510 from eileenmcnaughton/dep_token5
demeritcowboy [Wed, 8 Feb 2023 00:09:57 +0000 (19:09 -0500)]
Merge pull request #25510 from eileenmcnaughton/dep_token5

Add noisy deprecation to `replaceHookTokens`

2 years agoBump dompdf/dompdf from 2.0.2 to 2.0.3
dependabot[bot] [Tue, 7 Feb 2023 23:51:27 +0000 (23:51 +0000)]
Bump dompdf/dompdf from 2.0.2 to 2.0.3

Dependabot couldn't find the original pull request head commit, 889dfb1c9efc4cba2f79ab4088c30fe6774c0835.

2 years agoMerge pull request #25516 from eileenmcnaughton/expires
colemanw [Tue, 7 Feb 2023 23:16:08 +0000 (18:16 -0500)]
Merge pull request #25516 from eileenmcnaughton/expires

dev/core#4117 Add is_current to UserJob, Search

2 years agoCleanup notices on contribution.userDashboard, switch to apiv4
Eileen McNaughton [Sun, 30 Oct 2022 23:00:39 +0000 (12:00 +1300)]
Cleanup notices on contribution.userDashboard, switch to apiv4

Escape option-possible values

Adjust test for change in order

2 years agodev/core#4076 split up the theme method
Herb v/d Dool [Wed, 11 Jan 2023 21:55:20 +0000 (16:55 -0500)]
dev/core#4076 split up the theme method

2 years agoMerge pull request #25518 from eileenmcnaughton/gettree1
Yashodha Chaku [Tue, 7 Feb 2023 05:36:20 +0000 (11:06 +0530)]
Merge pull request #25518 from eileenmcnaughton/gettree1

Remove never-true IF

2 years agoRemove always-NULL singleRecord
Eileen McNaughton [Tue, 7 Feb 2023 01:46:54 +0000 (14:46 +1300)]
Remove always-NULL singleRecord

2 years agoRemove never-true IF
Eileen McNaughton [Tue, 7 Feb 2023 01:42:35 +0000 (14:42 +1300)]
Remove never-true IF

Per https://github.com/civicrm/civicrm-core/pull/25517  is
always FALSE so this IF is never true

2 years agoMerge pull request #25395 from eileenmcnaughton/cust_process
colemanw [Tue, 7 Feb 2023 01:12:14 +0000 (20:12 -0500)]
Merge pull request #25395 from eileenmcnaughton/cust_process

Remove interaction with complex legacy `getTree` function

2 years agoMerge pull request #25515 from jmcclelland/limit-dedupe-rules-on-import
Eileen McNaughton [Tue, 7 Feb 2023 00:20:24 +0000 (13:20 +1300)]
Merge pull request #25515 from jmcclelland/limit-dedupe-rules-on-import

only load dedupe rules for the chosen entity

2 years agodev/core#4117 Add is_current to UserJob, Search
Eileen McNaughton [Tue, 7 Feb 2023 00:08:32 +0000 (13:08 +1300)]
dev/core#4117 Add is_current to UserJob, Search

2 years agoMerge pull request #25195 from eileenmcnaughton/build_divide_event
colemanw [Tue, 7 Feb 2023 00:08:48 +0000 (19:08 -0500)]
Merge pull request #25195 from eileenmcnaughton/build_divide_event

Post divide code tidy up

2 years agoonly load dedupe rules for the chosen entity
Jamie McClelland [Mon, 6 Feb 2023 22:02:25 +0000 (17:02 -0500)]
only load dedupe rules for the chosen entity

I'm not sure how long this has been broken??

CRM_Dedupe_BAO_DedupeRuleGroup::getByType() clearly takes a string
and will never get one without this change.

2 years agoRemove interaction with complex legacy getTree function
Eileen McNaughton [Fri, 20 Jan 2023 01:16:14 +0000 (14:16 +1300)]
Remove interaction with complex legacy getTree function

2 years agoMerge pull request #25328 from herbdool/core-4028
Eileen McNaughton [Mon, 6 Feb 2023 20:11:09 +0000 (09:11 +1300)]
Merge pull request #25328 from herbdool/core-4028

(dev/core#4028) make CRM_Admin_Form_Setting_UF more CMS agnostic

2 years agoMerge pull request #25507 from eileenmcnaughton/token_dep3
Seamus Lee [Mon, 6 Feb 2023 20:01:41 +0000 (07:01 +1100)]
Merge pull request #25507 from eileenmcnaughton/token_dep3

Fully deprecate `CRM_Utils_Token::getMembershipTokenDetails`, `CRM_Utils_Token::replaceEntityTokens`

2 years agoMerge pull request #25512 from colemanw/ppAjax
Matthew Wire [Mon, 6 Feb 2023 19:14:08 +0000 (19:14 +0000)]
Merge pull request #25512 from colemanw/ppAjax

PaymentProcessor - Use ajax refresh

2 years agodev/core#4028 make CRM_Admin_Form_Setting_UF more CMS agnostic
Herb v/d Dool [Wed, 11 Jan 2023 20:09:35 +0000 (15:09 -0500)]
dev/core#4028 make CRM_Admin_Form_Setting_UF more CMS agnostic

2 years agoPaymentProcessor - Use ajax refresh
Coleman Watts [Mon, 6 Feb 2023 17:02:09 +0000 (12:02 -0500)]
PaymentProcessor - Use ajax refresh

2 years agoMerge pull request #25509 from eileenmcnaughton/token_dep4
Yashodha Chaku [Mon, 6 Feb 2023 10:18:52 +0000 (15:48 +0530)]
Merge pull request #25509 from eileenmcnaughton/token_dep4

Fully deprecate `CRM_Core_SelectValues::eventTokens()`

2 years agoFully deprecate getMembershipTokenDetails
Eileen McNaughton [Mon, 6 Feb 2023 07:08:30 +0000 (20:08 +1300)]
Fully deprecate getMembershipTokenDetails

2 years agoMerge pull request #25503 from eileenmcnaughton/basic_test
Eileen McNaughton [Mon, 6 Feb 2023 09:50:33 +0000 (22:50 +1300)]
Merge pull request #25503 from eileenmcnaughton/basic_test

Add extra test, comment how it could be used to fix bug

2 years agoMerge pull request #25508 from eileenmcnaughton/token_unused
Eileen McNaughton [Mon, 6 Feb 2023 09:01:09 +0000 (22:01 +1300)]
Merge pull request #25508 from eileenmcnaughton/token_unused

Remove unused variable

2 years agoMerge pull request #25506 from eileenmcnaughton/token_dep2
Eileen McNaughton [Mon, 6 Feb 2023 08:54:14 +0000 (21:54 +1300)]
Merge pull request #25506 from eileenmcnaughton/token_dep2

Fully deprecate `CRM_Core_SelectValues::membershipTokens()`

2 years agoMerge pull request #25505 from eileenmcnaughton/token_dep
Eileen McNaughton [Mon, 6 Feb 2023 08:33:03 +0000 (21:33 +1300)]
Merge pull request #25505 from eileenmcnaughton/token_dep

Fully deprecate legacy contributionTokens

2 years agoMerge pull request #24971 from lemniscus/abstractsaveaction-match-on-null
Eileen McNaughton [Mon, 6 Feb 2023 08:22:48 +0000 (21:22 +1300)]
Merge pull request #24971 from lemniscus/abstractsaveaction-match-on-null

API4: Allow save() to match on null values

2 years agoAdd extra test, comment how it could be used to fix bug
Eileen McNaughton [Mon, 6 Feb 2023 03:49:26 +0000 (16:49 +1300)]
Add extra test, comment how it could be used to fix bug

I was working on fixing the ongoing log noise in the tested scenario - but
the first PR https://github.com/civicrm/civicrm-core/pull/25392 is still
pending so I decided just to put up the test with the sign posts
so at least that part is done for the next time someone tries
(I know that people have tried in the past)

2 years agoAdd noisy deprecation to ReplaceHookTokens
Eileen McNaughton [Mon, 6 Feb 2023 07:52:00 +0000 (20:52 +1300)]
Add noisy deprecation to ReplaceHookTokens

This was code-comment deprecated around 15 months ago and
some extensions have updated to stop calling it so
it seems OK to make the deprecation a bit noisier now since
the TokenProcessor has been settled & stable for some time now

2 years agoFully deprecate CRM_Core_SelectValues::eventTokens()
Eileen McNaughton [Mon, 6 Feb 2023 07:17:14 +0000 (20:17 +1300)]
Fully deprecate CRM_Core_SelectValues::eventTokens()

2 years agoRemove unused variable
Eileen McNaughton [Mon, 6 Feb 2023 07:14:34 +0000 (20:14 +1300)]
Remove unused variable

2 years agoFully deprecate CRM_Core_SelectValues::membershipTokens()
Eileen McNaughton [Mon, 6 Feb 2023 07:05:48 +0000 (20:05 +1300)]
Fully deprecate CRM_Core_SelectValues::membershipTokens()

2 years agoFully deprecate legacy contributionTokens
Eileen McNaughton [Mon, 6 Feb 2023 06:50:15 +0000 (19:50 +1300)]
Fully deprecate legacy contributionTokens

2 years agoMerge pull request #25052 from eileenmcnaughton/fix_list
Eileen McNaughton [Mon, 6 Feb 2023 06:47:19 +0000 (19:47 +1300)]
Merge pull request #25052 from eileenmcnaughton/fix_list

Fix Scheduled reminders form to use tokenProcessor to get token list

2 years agoMerge pull request #25063 from eileenmcnaughton/local
Seamus Lee [Mon, 6 Feb 2023 04:14:05 +0000 (15:14 +1100)]
Merge pull request #25063 from eileenmcnaughton/local

Default to supporting partial locales

2 years agoPost divide code tidy up
Eileen McNaughton [Fri, 16 Dec 2022 23:23:57 +0000 (12:23 +1300)]
Post divide code tidy up

Per https://github.com/civicrm/civicrm-core/pull/25194
But the other function split out from

https://github.com/civicrm/civicrm-core/pull/25184

2 years agoDisable partial_locales in tests that are testing the legacy setting
Eileen McNaughton [Wed, 30 Nov 2022 01:10:24 +0000 (14:10 +1300)]
Disable partial_locales in tests that are testing the legacy setting

2 years agoDefault to supporting partial locales
Eileen McNaughton [Sun, 27 Nov 2022 20:37:48 +0000 (09:37 +1300)]
Default to supporting partial locales

2 years agoFix Scheduled reminders form to use tokenProcessor to get token list
Eileen McNaughton [Fri, 25 Nov 2022 04:20:47 +0000 (17:20 +1300)]
Fix Scheduled reminders form to use tokenProcessor to get token list

This is the last place outside of tests that calls some of these
functions so I will check in on them

2 years agoMerge pull request #25487 from yashodha/help_class
Eileen McNaughton [Mon, 6 Feb 2023 02:03:26 +0000 (15:03 +1300)]
Merge pull request #25487 from yashodha/help_class

fix the id help instead use class help

2 years agoMerge pull request #25501 from braders/event-form-searchtest-properties
Eileen McNaughton [Mon, 6 Feb 2023 01:40:55 +0000 (14:40 +1300)]
Merge pull request #25501 from braders/event-form-searchtest-properties

[REF][PHP8.2] Refactor properties on CRM_Event_Form_SearchTest

2 years agoMerge pull request #25502 from braders/sms-tests-dynamic-property
Eileen McNaughton [Sun, 5 Feb 2023 23:01:36 +0000 (12:01 +1300)]
Merge pull request #25502 from braders/sms-tests-dynamic-property

[REF][PHP8.2] Declare dynamic property in two SMS tests