Seamus Lee [Wed, 1 Jul 2020 23:10:41 +0000 (09:10 +1000)]
Ensure that the unexpected version check doesn't show if the version matches
Seamus Lee [Wed, 1 Jul 2020 22:51:28 +0000 (08:51 +1000)]
Fix logical errors and fix ENV file as well
Coleman Watts [Wed, 1 Jul 2020 14:31:29 +0000 (10:31 -0400)]
Fix version check for custom field serialize col
eileen [Wed, 1 Jul 2020 05:31:36 +0000 (17:31 +1200)]
Hacks to avoid failure on upgrade due to new field not yet being in the DB
On attempting to upgrade I found I couldn't get to the upgrade screen add the new serialize field as
I got fatal errors in these 2 places (maybe more to come).
The new field is civicrm_custom_field.serialize
Eileen McNaughton [Sun, 21 Jun 2020 21:13:13 +0000 (09:13 +1200)]
Merge pull request #17668 from seamuslee001/intl_check
dev/translation#48 Add check for PHP-Intl Extension
Seamus Lee [Sat, 20 Jun 2020 03:30:29 +0000 (13:30 +1000)]
dev/translation#48 Add check for PHP-Intl Extension
Seamus Lee [Thu, 18 Jun 2020 22:25:42 +0000 (08:25 +1000)]
Merge pull request #17653 from MegaphoneJon/dynamicreference-fix-527
handle less common dynamic reference cases
Jon Goldberg [Tue, 16 Jun 2020 17:43:49 +0000 (13:43 -0400)]
handle less common dynamic reference cases
Seamus Lee [Tue, 16 Jun 2020 10:00:57 +0000 (20:00 +1000)]
Merge pull request #17635 from seamuslee001/5262_notes
5.26.2 Release Notes
Tim Otten [Tue, 16 Jun 2020 08:25:08 +0000 (01:25 -0700)]
Update 5.26.2.md
Tim Otten [Tue, 16 Jun 2020 05:49:04 +0000 (22:49 -0700)]
Update 5.26.2.md
Seamus Lee [Tue, 16 Jun 2020 00:27:55 +0000 (10:27 +1000)]
5.26.2 Release Notes
Seamus Lee [Tue, 16 Jun 2020 08:13:00 +0000 (18:13 +1000)]
Merge pull request #17632 from seamuslee001/dev_core_1806
dev/core#1806 - Fix import of "Radio"-style custom fields using option "label"
Seamus Lee [Tue, 16 Jun 2020 04:57:41 +0000 (14:57 +1000)]
dev/core#1806 Fix issue with importing radio custom data field using the option label
Tim Otten [Tue, 16 Jun 2020 04:14:39 +0000 (21:14 -0700)]
Merge pull request #17628 from colemanw/customOptionsFallback
dev/core#1816 - Legacy support for matching custom field options by label
Coleman Watts [Tue, 16 Jun 2020 00:15:02 +0000 (20:15 -0400)]
dev/core#1816 - Legacy support for matching custom field options by label
Seamus Lee [Tue, 16 Jun 2020 00:58:31 +0000 (10:58 +1000)]
Merge pull request #17625 from demeritcowboy/missing-activitytype-5.27
dev/core#1822 - Fix missing newly created activity types from the dropdown on the new activity form
Seamus Lee [Tue, 16 Jun 2020 00:07:14 +0000 (10:07 +1000)]
Merge pull request #17622 from seamuslee001/smart_group_error
Fix issue with building smart groups when is empty
demeritcowboy [Mon, 15 Jun 2020 23:32:47 +0000 (19:32 -0400)]
fix missing newly created activity types
Seamus Lee [Mon, 15 Jun 2020 23:33:02 +0000 (09:33 +1000)]
Merge pull request #17619 from seamuslee001/dev_core_1823_alt
dev/core#1823 Fix building the Price Field visibility options
Seamus Lee [Mon, 15 Jun 2020 23:01:59 +0000 (09:01 +1000)]
Fix issue with building smart groups when is empty
Seamus Lee [Mon, 15 Jun 2020 22:00:54 +0000 (08:00 +1000)]
dev/core#1823 Fix building the Price Field visibility options
Matthew Wire [Sun, 14 Jun 2020 20:32:57 +0000 (21:32 +0100)]
Merge pull request #17607 from eileenmcnaughton/pi
Fix payment instrument bug by using correct payment instrument
eileen [Sun, 14 Jun 2020 02:36:46 +0000 (14:36 +1200)]
Fix payment instrument bug by using correct payment instrument
Per https://github.com/civicrm/civicrm-core/pull/17589 it is necessary that we do NOT pass the wrong payment_instrument_id
to the payment processor. BUT we have to provide accurate defaults for manual payments. This is a narrower fix than
- back office membership form
- back office participant form
- back office contribution form
and in all cases the Manual processor still loaded correctly. I don't feel I can say this is the last fix in this
area but it stands alone as a sensible fix to do and also one that should address the immediate issue.
Note there is some weirdness in a second function in EventFees - that function should GO IMHO - but I have not yet reached it in
UI testing to confirm if other changes need to be made.
Seamus Lee [Fri, 12 Jun 2020 05:08:53 +0000 (15:08 +1000)]
Merge pull request #17586 from seamuslee001/wip_56_test_fixes
[REF] Fix unit test failures on MySQL 5.6 due to Custom Field table being created without Dynamic Row Format
Seamus Lee [Fri, 12 Jun 2020 03:17:48 +0000 (13:17 +1000)]
Fix unit test failures on MySQL 5.6 due to Custom Field table being created without Dynamic Row Format
Seamus Lee [Thu, 11 Jun 2020 22:45:03 +0000 (08:45 +1000)]
Merge pull request #17577 from seamuslee001/deprecated_checks_money_value_format
Add in deprecation notice and status check for a money value format co…
Seamus Lee [Thu, 11 Jun 2020 22:06:43 +0000 (08:06 +1000)]
Merge pull request #17567 from eileenmcnaughton/dupe_speed
Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact table
Seamus Lee [Thu, 11 Jun 2020 02:59:31 +0000 (12:59 +1000)]
Add in depreation notice and status check for a money value format configuration other than the default
Update to include issue link
Update to use CRM_Core_Error::deprecated function and mention deprecation notice on settings page
eileen [Wed, 10 Jun 2020 02:30:36 +0000 (14:30 +1200)]
Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact tablge
Seamus Lee [Sun, 7 Jun 2020 06:12:20 +0000 (16:12 +1000)]
Merge pull request #17532 from totten/5.27-queue-test
QueueTest - Be more forgiving about slow execution
Tim Otten [Sun, 7 Jun 2020 04:29:17 +0000 (21:29 -0700)]
QueueTest - Be more forgiving about slow execution
The `CRM_Queue_QueueTest` is producing failures with the
[TIME_FUNC](https://github.com/civicrm/civicrm-core/pull/17414) option of
`linear:500` (the value currently used in PR test runs) -- which is to say,
it fails when the system runs very slowly (with some 500ms stalling during
execution).
This gets it working under some very slow scenarios:
```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
export TIME_FUNC;
echo;
echo "TIME_FUNC=$TIME_FUNC" ;
env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Queue/QueueTest.php ;
done
```
Seamus Lee [Sun, 7 Jun 2020 02:01:55 +0000 (12:01 +1000)]
Merge pull request #17360 from totten/master-wp-var
WP - Change definitions of `cms.root`, `civicrm.root`
Seamus Lee [Sun, 7 Jun 2020 01:01:04 +0000 (11:01 +1000)]
Merge pull request #17529 from totten/5.27-comm-msg
CommunityMessages - Define more consistent behavior in the face of slow execution
Tim Otten [Sat, 6 Jun 2020 22:21:01 +0000 (15:21 -0700)]
CommunityMessages - Define more consistent behavior in the face of slow execution
This passes under some brutally slow scenarios:
```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
export TIME_FUNC;
echo;
echo "TIME_FUNC=$TIME_FUNC" ;
env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Core/CommunityMessagesTest.php ;
done
```
CiviCRM [Sat, 6 Jun 2020 07:40:15 +0000 (07:40 +0000)]
Set version to 5.27.beta1
Tim Otten [Sat, 6 Jun 2020 07:39:32 +0000 (00:39 -0700)]
Merge pull request #17521 from seamuslee001/master
Add release-notes/5.26.1.md
Tim Otten [Sat, 6 Jun 2020 07:04:55 +0000 (00:04 -0700)]
Update release-notes.md
Tim Otten [Sat, 6 Jun 2020 00:54:38 +0000 (17:54 -0700)]
Add release-notes/5.26.1.md
Seamus Lee [Sat, 6 Jun 2020 04:03:31 +0000 (14:03 +1000)]
Merge pull request #17518 from totten/master-mysql-notice
dev/core#1681 - Copy-edits on MySQL version notices
Tim Otten [Sat, 6 Jun 2020 02:01:22 +0000 (19:01 -0700)]
dev/core#1681 - Copy-edits on MySQL version notices
* The titles for PHP+MySQL notices should use the same
capitalization/hyphenation ("Out-of-Date" vs "Out of date").
* Extract some more "%n" variables. Fix one errant variable.
* Reduce floweriness of the "version" / "at least" / "or later" text.
* Make it possible to add/remove the "+" notation without changing
the ts() message.
Tim Otten [Sat, 6 Jun 2020 00:22:55 +0000 (17:22 -0700)]
Merge pull request #17452 from eileenmcnaughton/dummy_bag
[REF] Start to convert Dummy processor to use PropertyBag
Seamus Lee [Fri, 5 Jun 2020 10:51:12 +0000 (20:51 +1000)]
Merge pull request #17505 from mattwire/propertybagfixsetamount
Payment PropertyBag - Fix setAmount
Matthew Wire [Fri, 5 Jun 2020 09:19:44 +0000 (10:19 +0100)]
Fix setAmount to set the right amount on payment propertybag
Seamus Lee [Fri, 5 Jun 2020 09:05:34 +0000 (19:05 +1000)]
Merge pull request #17496 from seamuslee001/mysql_upgrade_notice
dev/core#1681 Add in notice about 5.28 Dropping MySQL 5.5 Support
Seamus Lee [Fri, 5 Jun 2020 05:22:10 +0000 (15:22 +1000)]
Merge pull request #17489 from eileenmcnaughton/mod
[REF] Remove always NULL param modified_id
Seamus Lee [Thu, 4 Jun 2020 23:19:01 +0000 (09:19 +1000)]
dev/core#1681 Add in notice about 5.28 Dropping MySQL 5.5 Support
Eileen McNaughton [Fri, 5 Jun 2020 04:58:51 +0000 (16:58 +1200)]
Merge pull request #17497 from seamuslee001/dev_core_1797
dev/core#1797 Fix jquery Credit card validation on front end contribu…
Eileen McNaughton [Thu, 4 Jun 2020 23:55:50 +0000 (11:55 +1200)]
Merge pull request #17448 from mattwire/api4membershiptype
Add MembershipType to Api4
Seamus Lee [Thu, 4 Jun 2020 23:46:18 +0000 (09:46 +1000)]
Merge pull request #17473 from eileenmcnaughton/anet
Convert remaining Authorize.net test to use guzzle
Seamus Lee [Thu, 4 Jun 2020 23:41:10 +0000 (09:41 +1000)]
dev/core#1797 Fix jquery Credit card validation on front end contribution forms
Seamus Lee [Thu, 4 Jun 2020 23:23:24 +0000 (09:23 +1000)]
Merge pull request #17494 from pradpnayak/reminderSetdefault
set boolean fields to false if not set.
Seamus Lee [Thu, 4 Jun 2020 22:52:11 +0000 (08:52 +1000)]
Merge pull request #17490 from eileenmcnaughton/pending
[Ref] remove calls to, and deprecate, pending function
Eileen McNaughton [Thu, 4 Jun 2020 21:46:45 +0000 (09:46 +1200)]
Merge pull request #17426 from mattwire/recaptcha
Make reCAPTCHA settings clearer
Seamus Lee [Thu, 4 Jun 2020 21:14:30 +0000 (07:14 +1000)]
Merge pull request #17492 from eileenmcnaughton/search
[NFC] Fix use of single quotes, strict operator
Seamus Lee [Thu, 4 Jun 2020 21:14:04 +0000 (07:14 +1000)]
Merge pull request #17488 from eileenmcnaughton/memtype
Test fixes to support apiv4 add of MembershipType
colemanw [Thu, 4 Jun 2020 11:59:28 +0000 (07:59 -0400)]
Merge pull request #17493 from pradpnayak/tinyintFixes
dev/core/-/issues/1794, changed int to tinyint for boolean fields
Pradeep Nayak [Thu, 4 Jun 2020 10:15:15 +0000 (11:15 +0100)]
set boolean fields to false if not set.
Pradeep Nayak [Thu, 4 Jun 2020 09:47:34 +0000 (10:47 +0100)]
dev/core/-/issues/1794, changed int to tinyint for boolean fields
eileen [Thu, 4 Jun 2020 07:00:54 +0000 (19:00 +1200)]
[Ref] remove calls to, and deprecate, pending function
eileen [Tue, 2 Jun 2020 08:48:10 +0000 (20:48 +1200)]
[REF] Remove always NULL param modified_id
This funnction is not now shared with any other forms
eileen [Thu, 4 Jun 2020 06:41:45 +0000 (18:41 +1200)]
Test fixes to support apiv4 add of MembershipType
eileen [Tue, 2 Jun 2020 21:37:28 +0000 (09:37 +1200)]
Convert remaining Authorize.net test to use guzzle
This allows us to remove the handling for when a.net doesn't reply
Seamus Lee [Thu, 4 Jun 2020 05:01:15 +0000 (15:01 +1000)]
Merge pull request #17486 from seamuslee001/master
5.26
Seamus Lee [Thu, 4 Jun 2020 05:00:16 +0000 (15:00 +1000)]
Merge in 5.26
Tim Otten [Thu, 4 Jun 2020 04:58:04 +0000 (21:58 -0700)]
Merge pull request #17485 from totten/5.26-misc
5.26.0 - Small edits
Tim Otten [Thu, 4 Jun 2020 04:47:13 +0000 (21:47 -0700)]
Set version to 5.26.0
Tim Otten [Thu, 4 Jun 2020 04:46:48 +0000 (21:46 -0700)]
release-notes/5.26.0 - Copy-edits
Seamus Lee [Thu, 4 Jun 2020 04:06:04 +0000 (14:06 +1000)]
Merge pull request #17484 from civicrm/5.26
5.26
Seamus Lee [Thu, 4 Jun 2020 02:26:15 +0000 (12:26 +1000)]
Merge pull request #17483 from agh1/5.26.0-release-notes-final
5.26.0 release notes final
Eileen McNaughton [Thu, 4 Jun 2020 01:02:16 +0000 (13:02 +1200)]
Merge pull request #17482 from colemanw/orderBySuffix
APIv4 - Support pseudoconstant suffixes in orderBy clause
Seamus Lee [Thu, 4 Jun 2020 00:39:32 +0000 (10:39 +1000)]
Merge pull request #17481 from eileenmcnaughton/email
[REF] Extract createFollowUpActivities
Andrew Hunt [Wed, 3 Jun 2020 23:51:13 +0000 (19:51 -0400)]
5.26.0 release notes: some final edits
Coleman Watts [Wed, 3 Jun 2020 23:09:34 +0000 (19:09 -0400)]
APIv4 - Support pseudoconstant suffixes in orderBy clause
Seamus Lee [Wed, 3 Jun 2020 23:00:26 +0000 (09:00 +1000)]
Merge pull request #17476 from civicrm/5.26
5.26
Andrew Hunt [Wed, 3 Jun 2020 00:29:30 +0000 (20:29 -0400)]
5.26.0 release notes: added late changes
Seamus Lee [Wed, 3 Jun 2020 21:18:24 +0000 (07:18 +1000)]
Merge pull request #17478 from seamuslee001/document_recent_merge_wordpress_notice
Document recent merge in regards to select fields for export screen a…
Eileen McNaughton [Wed, 3 Jun 2020 21:16:07 +0000 (09:16 +1200)]
Merge pull request #17470 from colemanw/array
NFC - Change array() to short syntax []
eileen [Tue, 26 May 2020 03:48:30 +0000 (15:48 +1200)]
[REF] Extract createFollowUpActivities
Tim Otten [Wed, 3 Jun 2020 19:21:40 +0000 (12:21 -0700)]
Update 5.26.0.md
Matthew Wire [Wed, 3 Jun 2020 09:02:03 +0000 (10:02 +0100)]
Merge pull request #17474 from eileenmcnaughton/processor_name
Remove last reference to Payment->_processorName in core & remove from processors
Matthew Wire [Wed, 3 Jun 2020 09:00:39 +0000 (10:00 +0100)]
Merge pull request #17468 from mattwire/removesingleton
Remove unused singleton from core payment processors
Tim Otten [Wed, 3 Jun 2020 07:05:24 +0000 (00:05 -0700)]
Update 5.26.0.md
Tim Otten [Wed, 3 Jun 2020 07:01:30 +0000 (00:01 -0700)]
Update 5.26.0.md
Seamus Lee [Wed, 3 Jun 2020 04:27:01 +0000 (14:27 +1000)]
Document recent merge in regards to select fields for export screen and add in the notice about WordPress compatability issue
Seamus Lee [Wed, 3 Jun 2020 04:19:34 +0000 (14:19 +1000)]
Merge pull request #17444 from seamuslee001/deb_core_1725
dev/core#1725 Remove groups, tags and notes from the returned data fo…
colemanw [Wed, 3 Jun 2020 00:57:35 +0000 (20:57 -0400)]
Merge pull request #17442 from eileenmcnaughton/email3
[REF] Switch to an api call to get the contact details.
Seamus Lee [Wed, 3 Jun 2020 00:51:06 +0000 (10:51 +1000)]
Merge pull request #17446 from Edzelopez/fix-hideshow-receivedate
Fixed hide show of start date
Seamus Lee [Wed, 3 Jun 2020 00:50:44 +0000 (10:50 +1000)]
Merge pull request #17464 from eileenmcnaughton/renew
[REF] Remove never-passed params from function signature
Eileen McNaughton [Tue, 2 Jun 2020 23:58:19 +0000 (11:58 +1200)]
Merge pull request #17447 from mattwire/repeattransactiondisablerecur
Don't allow Contribution.repeattransaction to be used without a recurring contribution
Eileen McNaughton [Tue, 2 Jun 2020 23:49:04 +0000 (11:49 +1200)]
Merge pull request #17471 from colemanw/customSpec
APIv4 - Improve custom field spec gathering
Seamus Lee [Mon, 1 Jun 2020 08:39:43 +0000 (18:39 +1000)]
dev/core#1725 Remove groups, tags and notes from the returned data for the usage in preview data to speed up loading of the select fields screen
Seamus Lee [Tue, 2 Jun 2020 22:48:48 +0000 (08:48 +1000)]
Merge pull request #17472 from alifrumin/rn-5.26
Annotated 5.26 release notes
eileen [Tue, 2 Jun 2020 21:47:47 +0000 (09:47 +1200)]
Remove last reference to Payment->_processorName in core & remove from processors
I left it on Core_Payment to keep the deprecation notice visible
Alice Frumin [Tue, 2 Jun 2020 02:16:34 +0000 (22:16 -0400)]
release-notes 5.26: annotating release notes
Eileen McNaughton [Tue, 2 Jun 2020 20:43:11 +0000 (08:43 +1200)]
Merge pull request #17469 from colemanw/memberTypeTest
[REF] Fix serialized membership field handling in RelationshipTest
Coleman Watts [Tue, 2 Jun 2020 15:13:56 +0000 (11:13 -0400)]
APIv4 - Improve custom field spec gathering
Uses the basicTypes() function instead of hard-coding contact types,
Includes all the weird variants of Participant.
Matthew Wire [Mon, 1 Jun 2020 12:03:34 +0000 (13:03 +0100)]
Add Api4 MembershipType
Coleman Watts [Tue, 2 Jun 2020 14:42:55 +0000 (10:42 -0400)]
NFC - Change array() to short syntax []
Coleman Watts [Tue, 2 Jun 2020 14:16:03 +0000 (10:16 -0400)]
Fix serialized membership field handling in RelationshipTest
These fields were being unnecessarily and incorrectly serialized by the test.
Passing an array is preferred and it will handle the serialization correctly.