civicrm-core.git
6 years agoMerge pull request #11679 from jitendrapurohit/CRM-21776
Eileen McNaughton [Sun, 20 May 2018 22:51:10 +0000 (10:51 +1200)]
Merge pull request #11679 from jitendrapurohit/CRM-21776

CRM-21776: Ensure from clause adds custom table when search query is …

6 years agoMerge pull request #12159 from tschuettler/123-core-particpiant-import-custom-fields
Eileen McNaughton [Sun, 20 May 2018 21:57:17 +0000 (09:57 +1200)]
Merge pull request #12159 from tschuettler/123-core-particpiant-import-custom-fields

dev/core#123 Retrieve existing participant custom fields for import

6 years agoMerge pull request #12156 from seamuslee001/non_numeric_membership_test
Monish Deb [Sun, 20 May 2018 13:07:42 +0000 (18:37 +0530)]
Merge pull request #12156 from seamuslee001/non_numeric_membership_test

Fix issue where non numeric number was encounted in running unit test…

6 years agoFix issue where non numeric number was encounted in running unit tests on php7.2
Seamus Lee [Thu, 17 May 2018 21:51:42 +0000 (07:51 +1000)]
Fix issue where non numeric number was encounted in running unit tests on php7.2

Unit Test in api_v3_MembershipTest was throwing an error on the non numeric value of tax_amount, tax_amount was a NULL string.

6 years agoMerge pull request #12162 from seamuslee001/group_query_count
Monish Deb [Sat, 19 May 2018 18:27:16 +0000 (23:57 +0530)]
Merge pull request #12162 from seamuslee001/group_query_count

dev/core#118 Fix issue using count on non array in Group query builder

6 years agoMerge pull request #12157 from seamuslee001/pass_by_reference_mailing
colemanw [Sat, 19 May 2018 18:26:05 +0000 (14:26 -0400)]
Merge pull request #12157 from seamuslee001/pass_by_reference_mailing

Remove pass by reference for some mailing functions

6 years agoMerge pull request #12166 from seamuslee001/token_each
Monish Deb [Sat, 19 May 2018 18:25:32 +0000 (23:55 +0530)]
Merge pull request #12166 from seamuslee001/token_each

dev/core#117 Replace deprecated each with foreach in CRM/Utils/Token.php

6 years agoMerge pull request #12167 from seamuslee001/import_each
colemanw [Sat, 19 May 2018 18:23:08 +0000 (14:23 -0400)]
Merge pull request #12167 from seamuslee001/import_each

dev/core#117 Replace deprecated each with foreach in CRM/Utils/Migrat…

6 years agoMerge pull request #12168 from seamuslee001/dev_core_131
Mathieu Lu [Sat, 19 May 2018 15:32:17 +0000 (11:32 -0400)]
Merge pull request #12168 from seamuslee001/dev_core_131

dev/core#131 Add in missing UK state Monmouthshire

6 years agoMerge pull request #12163 from seamuslee001/count_peldge_tests
Monish Deb [Sat, 19 May 2018 14:23:10 +0000 (19:53 +0530)]
Merge pull request #12163 from seamuslee001/count_peldge_tests

dev/core#118 Fix Count issues with PledgePayment and Pledge BAO tests

6 years agoMerge pull request #12164 from seamuslee001/region_create_function
Monish Deb [Sat, 19 May 2018 12:56:26 +0000 (18:26 +0530)]
Merge pull request #12164 from seamuslee001/region_create_function

dev/core#130 Remove deprecated create_function from RegionTest in fav…

6 years agodev/core#117 Replace deprecated each with foreach in CRM/Utils/Token.php
Seamus Lee [Sat, 19 May 2018 04:15:10 +0000 (14:15 +1000)]
dev/core#117 Replace deprecated each with foreach in CRM/Utils/Token.php

6 years agoMerge pull request #12165 from seamuslee001/activity_query_each
Monish Deb [Sat, 19 May 2018 09:50:31 +0000 (15:20 +0530)]
Merge pull request #12165 from seamuslee001/activity_query_each

dev/core#117 Replace deprecated each with foreach in CRM/Activity/BAO…

6 years agodev/core#131 Add in missing UK state Monmouthshire
applicado [Tue, 15 May 2018 15:01:40 +0000 (16:01 +0100)]
dev/core#131 Add in missing UK state Monmouthshire

Monmouthshire is in Wales

dev/core#131 Add in upgrade step to add in missing UK state province

6 years agodev/core#117 Replace deprecated each with foreach in CRM/Activity/BAO/Query.php
Seamus Lee [Sat, 19 May 2018 04:15:27 +0000 (14:15 +1000)]
dev/core#117 Replace deprecated each with foreach in CRM/Activity/BAO/Query.php

6 years agodev/core#117 Replace deprecated each with foreach in CRM/Utils/Migrate/Import.php
Seamus Lee [Sat, 19 May 2018 04:15:19 +0000 (14:15 +1000)]
dev/core#117 Replace deprecated each with foreach in CRM/Utils/Migrate/Import.php

6 years agodev/core#118 Fix Count issues with PledgePayment and Pledge BAO tests
Seamus Lee [Sat, 19 May 2018 03:29:50 +0000 (13:29 +1000)]
dev/core#118 Fix Count issues with PledgePayment and Pledge BAO tests

6 years agodev/core#130 Remove deprecated create_function from RegionTest in favor of an annoymo...
Seamus Lee [Sat, 19 May 2018 04:04:25 +0000 (14:04 +1000)]
dev/core#130 Remove deprecated create_function from RegionTest in favor of an annoymous function

6 years agodev/core#118 Fix issue using count on non array in Group query builder
Seamus Lee [Sat, 19 May 2018 03:30:09 +0000 (13:30 +1000)]
dev/core#118 Fix issue using count on non array in Group query builder

6 years agodev/core#123 Retrieve existing participant custom fields for import
Thomas [Fri, 18 May 2018 15:31:29 +0000 (17:31 +0200)]
dev/core#123 Retrieve existing participant custom fields for import

6 years agoTry removing some more passing by reference
Seamus Lee [Fri, 18 May 2018 09:18:16 +0000 (19:18 +1000)]
Try removing some more passing by reference

6 years agoAttempt to remove pass by reference in some mailing functions
Seamus Lee [Thu, 17 May 2018 22:34:16 +0000 (08:34 +1000)]
Attempt to remove pass by reference in some mailing functions

6 years agoMerge pull request #12154 from compucorp/122-fix-bug-with-action-links
colemanw [Thu, 17 May 2018 13:53:58 +0000 (09:53 -0400)]
Merge pull request #12154 from compucorp/122-fix-bug-with-action-links

dev/core#122 Wrong Action Links Shown for Reserved and Locked Option Groups

6 years agodev/core#122 Add check for DELETE flag before unsetting it
Michael Devery [Thu, 17 May 2018 11:01:17 +0000 (12:01 +0100)]
dev/core#122 Add check for DELETE flag before unsetting it

6 years agoMerge pull request #11629 from JMAConsulting/CRM-21675
colemanw [Wed, 16 May 2018 19:45:48 +0000 (15:45 -0400)]
Merge pull request #11629 from JMAConsulting/CRM-21675

CRM-21675: scheduled reminders: limit to group doesn't support parent groups

6 years agoMerge pull request #11772 from michaelmcandrew/CRM-21821-respect-nav-item-weight
colemanw [Wed, 16 May 2018 15:41:49 +0000 (11:41 -0400)]
Merge pull request #11772 from michaelmcandrew/CRM-21821-respect-nav-item-weight

CRM-21821 respect nav item weight

6 years agoMerge pull request #12146 from seamuslee001/contribute_import_parser_count
Monish Deb [Wed, 16 May 2018 13:09:22 +0000 (18:39 +0530)]
Merge pull request #12146 from seamuslee001/contribute_import_parser_count

(NFC) Fix cannot use count() on object that doesn't implement countab…

6 years agoMerge pull request #12000 from compucorp/timeline-name-edit-inplace
Eileen McNaughton [Wed, 16 May 2018 09:57:41 +0000 (21:57 +1200)]
Merge pull request #12000 from compucorp/timeline-name-edit-inplace

Add inplace edit for timeline name

6 years ago(NFC) Fix cannot use count() on object that doesn't implement countable in tests...
Seamus Lee [Wed, 16 May 2018 09:46:37 +0000 (19:46 +1000)]
(NFC) Fix cannot use count() on object that doesn't implement countable in tests/phpunit/CRM/Contribute/Import/Parser/ContributionTest.php

6 years agoMerge pull request #12003 from vinuvarshith/dev/core/69-fix-state-province-name-token...
Eileen McNaughton [Wed, 16 May 2018 09:18:20 +0000 (21:18 +1200)]
Merge pull request #12003 from vinuvarshith/dev/core/69-fix-state-province-name-token-issue

code/dev/69: Change Approach For Setting state_province_name

6 years agoMerge pull request #12011 from lcdservices/dev-financial-12
Eileen McNaughton [Wed, 16 May 2018 07:51:46 +0000 (19:51 +1200)]
Merge pull request #12011 from lcdservices/dev-financial-12

dev/financial#12 move soft credit item count to object property

6 years agoMerge pull request #12145 from civicrm/5.2
Eileen McNaughton [Wed, 16 May 2018 07:49:03 +0000 (19:49 +1200)]
Merge pull request #12145 from civicrm/5.2

5.2 merge to master

6 years agoMerge pull request #12143 from seamuslee001/5.2
Eileen McNaughton [Wed, 16 May 2018 07:48:24 +0000 (19:48 +1200)]
Merge pull request #12143 from seamuslee001/5.2

(NFC) Add in 5.1.0 and 5.1.1 mysql upgrade files

6 years agoMerge pull request #11962 from compucorp/55-hide-adding-option-value-for-locked-groups
Eileen McNaughton [Wed, 16 May 2018 06:58:59 +0000 (18:58 +1200)]
Merge pull request #11962 from compucorp/55-hide-adding-option-value-for-locked-groups

Hide Adding Option Value for Locked Groups

6 years agoFix unit tests
Debarshi Bhaumik [Wed, 16 May 2018 06:51:44 +0000 (12:21 +0530)]
Fix unit tests

6 years agoAdd in 5.1.0 and 5.1.1 mysql upgrade files
Seamus Lee [Wed, 16 May 2018 03:14:53 +0000 (13:14 +1000)]
Add in 5.1.0 and 5.1.1 mysql upgrade files

6 years agoMerge pull request #12135 from eileenmcnaughton/fgb_up
Eileen McNaughton [Wed, 16 May 2018 00:56:45 +0000 (12:56 +1200)]
Merge pull request #12135 from eileenmcnaughton/fgb_up

added unit test

6 years agoMerge pull request #12140 from seamuslee001/civicrm-version-filemode
Eileen McNaughton [Wed, 16 May 2018 00:45:46 +0000 (12:45 +1200)]
Merge pull request #12140 from seamuslee001/civicrm-version-filemode

(NFC) fix file permissions on civicrm-version.php

6 years agoMerge pull request #12141 from seamuslee001/file_perms_fix
Eileen McNaughton [Wed, 16 May 2018 00:44:15 +0000 (12:44 +1200)]
Merge pull request #12141 from seamuslee001/file_perms_fix

Fix file perms on files back to 664

6 years agoAdd release notes for 5.1.1
Tim Otten [Wed, 16 May 2018 00:29:24 +0000 (17:29 -0700)]
Add release notes for 5.1.1

6 years agoFix file perms on files back to 664
Seamus Lee [Tue, 15 May 2018 23:28:13 +0000 (09:28 +1000)]
Fix file perms on files back to 664

6 years ago(NFC) fix file permissions on civicrm-version.php
Seamus Lee [Tue, 15 May 2018 23:23:55 +0000 (09:23 +1000)]
(NFC) fix file permissions on civicrm-version.php

6 years agoMerge pull request #12139 from JMAConsulting/dev-drupal-17
Mathieu Lu [Tue, 15 May 2018 23:11:32 +0000 (19:11 -0400)]
Merge pull request #12139 from JMAConsulting/dev-drupal-17

(dev/drupal/17) Add Drupal8 support for getUFLocale()

6 years agoMerge pull request #12103 from seamuslee001/issue_footer
Eileen McNaughton [Tue, 15 May 2018 23:05:48 +0000 (11:05 +1200)]
Merge pull request #12103 from seamuslee001/issue_footer

(NFC) Update view issues and report bugs link in footer to point to the lab

6 years agoMerge pull request #12024 from yashodha/price_custom_search
Eileen McNaughton [Tue, 15 May 2018 23:00:36 +0000 (11:00 +1200)]
Merge pull request #12024 from yashodha/price_custom_search

core/issues/74 - 'Price Set Details for Event Participants' gives DB …

6 years agoMerge pull request #12130 from seamuslee001/karma_upgrade_2
Tim Otten [Tue, 15 May 2018 22:52:06 +0000 (15:52 -0700)]
Merge pull request #12130 from seamuslee001/karma_upgrade_2

(NFC) Update to latest versions of karma and jasmine used only in tes…

6 years agoMerge pull request #12106 from eileenmcnaughton/activity
Seamus Lee [Tue, 15 May 2018 21:57:25 +0000 (07:57 +1000)]
Merge pull request #12106 from eileenmcnaughton/activity

[NFC] Cleanup on ActivityTest class.

6 years agoMerge pull request #12132 from eileenmcnaughton/membership_type_data
Eileen McNaughton [Tue, 15 May 2018 21:03:41 +0000 (09:03 +1200)]
Merge pull request #12132 from eileenmcnaughton/membership_type_data

Add labels to membership type metadata, allowing for addField method to be used

6 years ago(dev/drupal/17) Add Drupal8 support for getUFLocale()
deb.monish [Tue, 15 May 2018 18:40:59 +0000 (00:10 +0530)]
(dev/drupal/17) Add Drupal8 support for getUFLocale()

6 years agoMerge pull request #11456 from jitendrapurohit/CRM-21598
colemanw [Tue, 15 May 2018 18:36:13 +0000 (14:36 -0400)]
Merge pull request #11456 from jitendrapurohit/CRM-21598

CRM-21598 - Case Activity issues with custom Completed Status Type

6 years agoAdd inplace edit for timeline name
Debarshi Bhaumik [Thu, 19 Apr 2018 07:19:36 +0000 (12:49 +0530)]
Add inplace edit for timeline name

6 years agoTpl cleanup
Coleman Watts [Tue, 15 May 2018 16:49:58 +0000 (12:49 -0400)]
Tpl cleanup

6 years agoMerge pull request #12136 from seamuslee001/nfc_disable_no_orderby_tests
Monish Deb [Tue, 15 May 2018 14:58:46 +0000 (20:28 +0530)]
Merge pull request #12136 from seamuslee001/nfc_disable_no_orderby_tests

(NFC) Disable tests performing quick search with no orderby as provin…

6 years agoTranslate field labels
Coleman Watts [Tue, 15 May 2018 14:20:31 +0000 (10:20 -0400)]
Translate field labels

6 years agodev/core#55 Hide option to delete option value for locked option group
Michael Devery [Tue, 15 May 2018 11:13:54 +0000 (12:13 +0100)]
dev/core#55 Hide option to delete option value for locked option group

6 years agodev/core#55 Fix typos
Michael Devery [Tue, 15 May 2018 11:02:53 +0000 (12:02 +0100)]
dev/core#55 Fix typos

6 years agodev/core#55 Remove option to delete option value for locked groups
Michael Devery [Tue, 15 May 2018 11:02:44 +0000 (12:02 +0100)]
dev/core#55 Remove option to delete option value for locked groups

6 years ago(NFC) Disable tests performing quick search with no orderby as proving to be problema...
Seamus Lee [Tue, 15 May 2018 08:48:42 +0000 (18:48 +1000)]
(NFC) Disable tests performing quick search with no orderby as proving to be problematic on different MySQL versions and add in warning in regards to the usage of CRM_Utils_SQL::supportStorageOfAccents()

Disable another flacky test

6 years agoMerge pull request #11877 from compucorp/CRM-21853-remove-implicit-is-multiple-change
Eileen McNaughton [Tue, 15 May 2018 09:06:19 +0000 (21:06 +1200)]
Merge pull request #11877 from compucorp/CRM-21853-remove-implicit-is-multiple-change

CRM-21853: Do not change 'is_multiple' unless included in the params

6 years agoadded unit test
deb.monish [Thu, 29 Mar 2018 13:26:54 +0000 (18:56 +0530)]
added unit test

6 years agoMerge pull request #12004 from samuelsov/dev/core#30#2
Eileen McNaughton [Tue, 15 May 2018 07:46:48 +0000 (19:46 +1200)]
Merge pull request #12004 from samuelsov/dev/core#30#2

dev/core#30 export of contact master_id name only if there is a master_id given (rebase)

6 years agoMerge pull request #12093 from aniesshsethh/core_105
Eileen McNaughton [Tue, 15 May 2018 07:18:18 +0000 (19:18 +1200)]
Merge pull request #12093 from aniesshsethh/core_105

dev/core#105 Manage PCP URL Wrong for the notification email under wo…

6 years agoCleanup on test class.
eileen [Thu, 10 May 2018 02:20:01 +0000 (14:20 +1200)]
Cleanup on test class.

Remove some functions that were not testing what they said they were & clarify others. Improve
formatting & declaration of unused vars

6 years agoMerge pull request #12127 from eileenmcnaughton/cust_generic
Seamus Lee [Tue, 15 May 2018 07:01:08 +0000 (17:01 +1000)]
Merge pull request #12127 from eileenmcnaughton/cust_generic

Use getter function for entity id as on some forms  is protected.

6 years agoMerge pull request #12113 from totten/JMAConsulting-dev-drupal-10
Eileen McNaughton [Tue, 15 May 2018 06:55:56 +0000 (18:55 +1200)]
Merge pull request #12113 from totten/JMAConsulting-dev-drupal-10

(dev/drupal#10)  Make civicrm-version.php self-sufficient

6 years agoAdd labels to membership type metadata, allowing for addField method to be used
eileen [Tue, 15 May 2018 02:14:50 +0000 (14:14 +1200)]
Add labels to membership type metadata, allowing for addField method to be used

6 years agoMerge pull request #12131 from seamuslee001/custom_field
Eileen McNaughton [Tue, 15 May 2018 00:37:13 +0000 (12:37 +1200)]
Merge pull request #12131 from seamuslee001/custom_field

Set Default values on is_active, is_searchable, is_view and is_active…

6 years agoMerge pull request #12032 from jitendrapurohit/core-80
colemanw [Mon, 14 May 2018 22:23:42 +0000 (18:23 -0400)]
Merge pull request #12032 from jitendrapurohit/core-80

core/issues/80 - Current Employer is not reset after relationship is …

6 years agoSet Default values on is_active, is_searchable, is_view and is_active on civicrm_cust...
Seamus Lee [Mon, 14 May 2018 21:54:14 +0000 (07:54 +1000)]
Set Default values on is_active, is_searchable, is_view and is_active on civicrm_custom_field

6 years agoMerge pull request #12116 from eileenmcnaughton/cust_field
Seamus Lee [Mon, 14 May 2018 21:36:04 +0000 (07:36 +1000)]
Merge pull request #12116 from eileenmcnaughton/cust_field

Add DB default of 0 for custom_group.is_multiple - CRM-21853

6 years ago(NFC) Update to latest versions of karma and jasmine used only in testing
Seamus Lee [Mon, 14 May 2018 21:22:38 +0000 (07:22 +1000)]
(NFC) Update to latest versions of karma and jasmine used only in testing

6 years agoMerge pull request #12124 from eileenmcnaughton/membership_metadata
colemanw [Mon, 14 May 2018 17:21:29 +0000 (13:21 -0400)]
Merge pull request #12124 from eileenmcnaughton/membership_metadata

Add field metadata to MembershipType schema info (xml)

6 years agoMerge pull request #12126 from eileenmcnaughton/membership_type
Eileen McNaughton [Mon, 14 May 2018 05:32:08 +0000 (17:32 +1200)]
Merge pull request #12126 from eileenmcnaughton/membership_type

Preliminary cleanup for Custom data support for MembershipType form

6 years agoUse getter function for entity id as on some forms is protected.
eileen [Mon, 14 May 2018 04:24:15 +0000 (16:24 +1200)]
Use getter function for entity id as on some forms  is protected.

Follow up to https://github.com/civicrm/civicrm-core/pull/12095

6 years agoMerge pull request #12125 from eileenmcnaughton/membership_config
Eileen McNaughton [Mon, 14 May 2018 04:04:53 +0000 (16:04 +1200)]
Merge pull request #12125 from eileenmcnaughton/membership_config

[NFC] Fix leakage of Form entity

6 years agoPreliminary cleanup for Custom data support for MembershipType form
Matthew Wire [Sun, 6 May 2018 17:10:02 +0000 (18:10 +0100)]
Preliminary cleanup for Custom data support for MembershipType form

6 years agoMerge pull request #12123 from eileenmcnaughton/membership_type
Eileen McNaughton [Mon, 14 May 2018 02:13:58 +0000 (14:13 +1200)]
Merge pull request #12123 from eileenmcnaughton/membership_type

Preliminary tidy up of  MembershipType form (towards custom data support)

6 years agoFix leakage of Form entity
eileen [Mon, 14 May 2018 00:57:07 +0000 (12:57 +1200)]
Fix leakage of Form entity

6 years agoAdd field metadata to MembershipType schema info (xml)
eileen [Mon, 14 May 2018 00:55:48 +0000 (12:55 +1200)]
Add field metadata to MembershipType schema info (xml)

6 years agoMerge pull request #12122 from eileenmcnaughton/cudat
Eileen McNaughton [Mon, 14 May 2018 00:12:53 +0000 (12:12 +1200)]
Merge pull request #12122 from eileenmcnaughton/cudat

tpl extraction of shared code for customDataBlock

6 years agoPreliminary tidy up of MembershipType form (towards custom data support)
Matthew Wire [Sun, 6 May 2018 17:10:02 +0000 (18:10 +0100)]
Preliminary tidy up of  MembershipType form (towards custom data support)

6 years agoMerge pull request #11908 from mattwire/membershiptype_customdata_support
Eileen McNaughton [Sun, 13 May 2018 23:00:11 +0000 (11:00 +1200)]
Merge pull request #11908 from mattwire/membershiptype_customdata_support

Support hooks for MembershipType entity

6 years agotpl extraction of shared code for customDataBlock
eileen [Tue, 8 May 2018 06:00:21 +0000 (18:00 +1200)]
tpl extraction of shared code for customDataBlock

6 years agoMerge pull request #12121 from civicrm/5.2
Seamus Lee [Sun, 13 May 2018 00:46:32 +0000 (10:46 +1000)]
Merge pull request #12121 from civicrm/5.2

5.2

6 years agoMerge pull request #12120 from eileenmcnaughton/fgb
Seamus Lee [Sun, 13 May 2018 00:45:31 +0000 (10:45 +1000)]
Merge pull request #12120 from eileenmcnaughton/fgb

Fgb

6 years agorevert some change and other fixes
deb.monish [Tue, 8 May 2018 06:36:26 +0000 (12:06 +0530)]
revert some change and other fixes

6 years ago(dev/core/68) Fix DB Error on 'Find Participant' page when MySQL FULL_GROUP_BY_MODE...
deb.monish [Wed, 18 Apr 2018 18:38:36 +0000 (00:08 +0530)]
(dev/core/68) Fix DB Error on 'Find Participant' page when MySQL FULL_GROUP_BY_MODE is enabled

6 years agoAdd create/edit pre/post hooks to MembershipType
Matthew Wire [Sat, 12 May 2018 07:38:17 +0000 (08:38 +0100)]
Add create/edit pre/post hooks to MembershipType

6 years agoAdd DB default of 0 for custom_group.is_multiple - CRM-21853
eileen [Fri, 11 May 2018 21:59:26 +0000 (09:59 +1200)]
Add DB default of 0 for custom_group.is_multiple - CRM-21853

6 years agocore/issues/80 - Current Employer is not reset after relationship is updated
Jitendra Purohit [Thu, 26 Apr 2018 12:21:27 +0000 (17:51 +0530)]
core/issues/80 - Current Employer is not reset after relationship is updated

Additional fixes

Additional fixes

6 years agoMerge pull request #12085 from seamuslee001/pledge_search_form_test
Monish Deb [Fri, 11 May 2018 04:12:17 +0000 (09:42 +0530)]
Merge pull request #12085 from seamuslee001/pledge_search_form_test

(NFC) Add unit test of submitting the Pledge Search Form

6 years agodistmaker - Add deprecation notice to generated copies of civicrm-version.php
Tim Otten [Fri, 11 May 2018 03:15:09 +0000 (20:15 -0700)]
distmaker - Add deprecation notice to generated copies of civicrm-version.php

6 years agocivicrm-version.php - Mark `civicrmVersion()` as deprecated
Tim Otten [Fri, 11 May 2018 03:14:26 +0000 (20:14 -0700)]
civicrm-version.php - Mark `civicrmVersion()` as deprecated

6 years agocivicrm-version.php - Fix CMS detection in pre-booted Drupal8
Tim Otten [Fri, 11 May 2018 02:43:49 +0000 (19:43 -0700)]
civicrm-version.php - Fix CMS detection in pre-booted Drupal8

Ex 1: Running `drush` commands
Ex 2: Running `cv` with `--level=cms-only`

6 years agocivicrm-version.php - Fix CMS detection in pre-booted WordPress
Tim Otten [Fri, 11 May 2018 02:12:30 +0000 (19:12 -0700)]
civicrm-version.php - Fix CMS detection in pre-booted WordPress

Ex 1: Running `wp-cli` commands
Ex 2: Running `cv` with `--level=cms-only`

6 years agocivicrm-version.php - Fix CMS detection in pre-booted Backdrop
Tim Otten [Fri, 11 May 2018 00:57:08 +0000 (17:57 -0700)]
civicrm-version.php - Fix CMS detection in pre-booted Backdrop

Ex 1: Running `drush` commands
Ex 2: Running `cv` with `--level=cms-only`

6 years agoCRM/Utils/System.php - Don't go through civicrm-version.php
Tim Otten [Fri, 11 May 2018 01:59:08 +0000 (18:59 -0700)]
CRM/Utils/System.php - Don't go through civicrm-version.php

In a typical environment, this is just an unnecessary file-load, and it
makes it harder to (someday) remove/deprecate `civicrm-version.php`.

6 years agocivicrm-version.php - Internal helpers should use manifestly private namespace
Tim Otten [Fri, 11 May 2018 00:38:25 +0000 (17:38 -0700)]
civicrm-version.php - Internal helpers should use manifestly private namespace

The new helper functions in this file shouldn't be used externally; this
file is just an adapter for backward-compatibility.  External callers should
still use `CRM_Utils_System::version()`, `civicrmVersion()`, or
`version.xml`.

6 years agocivicrm-version.php - Keep civicrmVersion() in global namespace
Tim Otten [Thu, 10 May 2018 23:45:06 +0000 (16:45 -0700)]
civicrm-version.php - Keep civicrmVersion() in global namespace

The function has traditionally been in the global namespace, and it
should stay there for backward compatibility.

This patch looks big, but it's really just wrapping code inside new
`namespace ...  { ...  }` blocks.

6 years agoMerge pull request #12110 from kcristiano/5.2-11936
Eileen McNaughton [Fri, 11 May 2018 00:19:20 +0000 (12:19 +1200)]
Merge pull request #12110 from kcristiano/5.2-11936

Re-Fix Case form task (export/print not working) (replace quick fix with proper fix)