From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Fri, 2 Jun 2023 00:08:43 +0000 (+1200)
Subject: Add deprecation notes to function deprecated in 2021
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=f9e63793e127c6ea32b00f53960e995e9c170f61;p=civicrm-core.git

Add deprecation notes to function deprecated in 2021

I looked to remove this but the original PR spotted it was used
by civimobile & I checked & it still is - albeit in code
that is deprecated within civimobile. I created an issue on their
repo & updated the notes on the function to point to it & also
suggest that we remove it around 5.66 (which gives another 3-4 months
for civimobile to respond now there is an active issue not
just a notice)
---

diff --git a/CRM/Member/BAO/Membership.php b/CRM/Member/BAO/Membership.php
index 15ef6231bb..303af17141 100644
--- a/CRM/Member/BAO/Membership.php
+++ b/CRM/Member/BAO/Membership.php
@@ -1769,7 +1769,9 @@ INNER JOIN  civicrm_contact contact ON ( contact.id = membership.contact_id AND
   }
 
   /**
-   * @deprecated
+   * @deprecated in CiviCRM 5.39, will be removed around CiviCRM 5.66.
+   *
+   * Deprecation issue in https://lab.civicrm.org/extensions/civimobileapi/-/issues/86
    *
    * @param int $contactID
    * @param int $membershipTypeID