From: Anthony Nemirovsky <anemirovsky@giantrabbit.com>
Date: Sat, 16 Aug 2014 00:39:34 +0000 (-0700)
Subject: Fix issue with reports creating invalid URLs when updated.
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=f37ea1c8573bf48ef3c846be46dc20155c43995f;p=civicrm-core.git

Fix issue with reports creating invalid URLs when updated.

When updating a report, if the Report Settings is set to "Include Report in
Navigation Menu", the navigation url that is created is formatted like
/civicrm/report/instance/1_reset_1, which is incorrect. The correct URL
should be /civicrm/report/instance/1?reset=1.
---

diff --git a/CRM/Report/BAO/ReportInstance.php b/CRM/Report/BAO/ReportInstance.php
index 55b36f3a4b..e21a680624 100644
--- a/CRM/Report/BAO/ReportInstance.php
+++ b/CRM/Report/BAO/ReportInstance.php
@@ -191,7 +191,7 @@ class CRM_Report_BAO_ReportInstance extends CRM_Report_DAO_ReportInstance {
       if (empty($params['id']) && empty($params['instance_id']) && !empty($navigationParams['id'])) {
         unset($navigationParams['id']);
       }
-      $navigationParams['url'] = "civicrm/report/instance/{$instance->id}&reset=1";
+      $navigationParams['url'] = "civicrm/report/instance/{$instance->id}?reset=1";
       $navigation = CRM_Core_BAO_Navigation::add($navigationParams);
 
       if (!empty($navigationParams['is_active'])) {