From: Matthew Wire <mjw@mjwconsult.co.uk>
Date: Tue, 1 Sep 2020 21:41:21 +0000 (+0100)
Subject: Remove unused passbyreference and var from ipn_process_transaction
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=f19d0e356d5de15686880d4adb84075d8dbb6053;p=civicrm-core.git

Remove unused passbyreference and var from ipn_process_transaction
---

diff --git a/api/v3/Contribution.php b/api/v3/Contribution.php
index 6303617982..aa3d7f156c 100644
--- a/api/v3/Contribution.php
+++ b/api/v3/Contribution.php
@@ -602,7 +602,6 @@ function civicrm_api3_contribution_repeattransaction($params) {
     );
   }
 
-  $original_contribution = clone $contribution;
   $input['payment_processor_id'] = civicrm_api3('contributionRecur', 'getvalue', [
     'return' => 'payment_processor_id',
     'id' => $contribution->contribution_recur_id,
@@ -626,7 +625,7 @@ function civicrm_api3_contribution_repeattransaction($params) {
     ];
     $input = array_intersect_key($params, array_fill_keys($passThroughParams, NULL));
 
-    return _ipn_process_transaction($params, $contribution, $input, $ids, $original_contribution);
+    return _ipn_process_transaction($params, $contribution, $input, $ids);
   }
   catch (Exception $e) {
     throw new API_Exception('failed to load related objects' . $e->getMessage() . "\n" . $e->getTraceAsString());
@@ -645,13 +644,11 @@ function civicrm_api3_contribution_repeattransaction($params) {
  *
  * @param array $ids
  *
- * @param CRM_Contribute_BAO_Contribution $firstContribution
- *
  * @return mixed
  * @throws \CRM_Core_Exception
  * @throws \CiviCRM_API3_Exception
  */
-function _ipn_process_transaction(&$params, $contribution, $input, $ids, $firstContribution = NULL) {
+function _ipn_process_transaction($params, $contribution, $input, $ids) {
   $objects = $contribution->_relatedObjects;
   $objects['contribution'] = &$contribution;
   $input['component'] = $contribution->_component;