From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Fri, 21 Jan 2022 03:01:57 +0000 (+1300)
Subject: Pass remove-by-reference
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=f14cf58304e7ec6361b4f4d6c302f776b02762c1;p=civicrm-core.git

Pass remove-by-reference
---

diff --git a/api/v3/utils.php b/api/v3/utils.php
index 83a212f151..03a25ae1ec 100644
--- a/api/v3/utils.php
+++ b/api/v3/utils.php
@@ -445,15 +445,15 @@ function _civicrm_api3_filter_fields_for_bao($entity, &$params, &$values) {
 }
 
 /**
- * Store values.
+ * Copy values (other than id) from params to values if they exist in fields.
  *
  * @param array $fields
  * @param array $params
  * @param array $values
  *
- * @return Bool
+ * @return bool
  */
-function _civicrm_api3_store_values(&$fields, &$params, &$values) {
+function _civicrm_api3_store_values(array $fields, array $params, &$values): bool {
   $valueFound = FALSE;
 
   $keys = array_intersect_key($params, $fields);