From: Jeremy Harris <jgh146exb@wizmail.org>
Date: Sat, 12 Oct 2019 13:12:56 +0000 (+0100)
Subject: Fix errorcheck in smtp transport
X-Git-Tag: exim-4.93-RC0~15
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=efa73277b6cab96e4bed1a5f5d42fd3fcc5d279b;p=exim.git

Fix errorcheck in smtp transport
---

diff --git a/src/src/transports/smtp.c b/src/src/transports/smtp.c
index fd550efff..c547c87fa 100644
--- a/src/src/transports/smtp.c
+++ b/src/src/transports/smtp.c
@@ -4285,7 +4285,7 @@ if (sx.completed_addr && sx.ok && sx.send_quit)
 	  /* Set up a pipe for proxying TLS for the new transport process */
 
 	  smtp_peer_options |= OPTION_TLS;
-	  if (sx.ok = (socketpair(AF_UNIX, SOCK_STREAM, 0, pfd) == 0))
+	  if ((sx.ok = socketpair(AF_UNIX, SOCK_STREAM, 0, pfd) == 0))
 	    socket_fd = pfd[1];
 	  else
 	    set_errno(sx.first_addr, errno, US"internal allocation problem",