From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Sat, 18 Mar 2023 01:57:31 +0000 (+1300)
Subject: Hard-code cacheKey as variables are not variable
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=ebe8bbe746092870f8fa1fbb08aa20d85740b7a4;p=civicrm-core.git

Hard-code cacheKey as variables are not variable
---

diff --git a/CRM/Dedupe/BAO/DedupeRuleGroup.php b/CRM/Dedupe/BAO/DedupeRuleGroup.php
index 0feb3f5e0a..49012a102f 100644
--- a/CRM/Dedupe/BAO/DedupeRuleGroup.php
+++ b/CRM/Dedupe/BAO/DedupeRuleGroup.php
@@ -141,18 +141,11 @@ class CRM_Dedupe_BAO_DedupeRuleGroup extends CRM_Dedupe_DAO_DedupeRuleGroup {
    * @return array
    *   array of importable Fields
    */
-  private static function importableFields($contactType) {
-    $status = FALSE;
+  private static function importableFields($contactType): array {
     $showAll = FALSE;
-    $isProfile = FALSE;
-    $checkPermission = TRUE;
     $withMultiCustomFields = FALSE;
 
-    $cacheKeyString = "importableFields $contactType";
-    $cacheKeyString .= $status ? '_1' : '_0';
-    $cacheKeyString .= $showAll ? '_1' : '_0';
-    $cacheKeyString .= $isProfile ? '_1' : '_0';
-    $cacheKeyString .= $checkPermission ? '_1' : '_0';
+    $cacheKeyString = 'importableFields ' . $contactType . '_0_0_0_1';
     $cacheKeyString .= '_' . CRM_Core_Config::domainID() . '_';
 
     $fields = Civi::cache('fields')->get($cacheKeyString);