From: pdontthink <pdontthink@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Date: Wed, 24 Sep 2008 20:03:31 +0000 (+0000)
Subject: Add FIXME
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=e4c581a492b60585716e3caa6ca5895ddd6a7427;p=squirrelmail.git

Add FIXME

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13286 7612ce4b-ef26-0410-bec9-ea0150e637f0
---

diff --git a/templates/default_advanced/js/dtree.js b/templates/default_advanced/js/dtree.js
index 245b497e..67fec6f4 100644
--- a/templates/default_advanced/js/dtree.js
+++ b/templates/default_advanced/js/dtree.js
@@ -289,6 +289,7 @@ dTree.prototype.clearCookie = function() {
 };
 
 // [Cookie] Sets value in a cookie
+// FIXME: although setCookie() supports the secure flag, it isn't used when called anywhere in this file; ideally it should correspond to how the flag is determined in the SM core in sqsetcookie() (including the admin config that turns the secure flag off)... also, would be good to add the HTTP only flag
 dTree.prototype.setCookie = function(cookieName, cookieValue, expires, path, domain, secure) {
 	document.cookie =
 		escape(cookieName) + '=' + escape(cookieValue)