From: Coleman Watts <coleman@civicrm.org>
Date: Wed, 10 Aug 2016 15:55:18 +0000 (-0400)
Subject: CRM-17663 - Fix race condition when loading OFC charts on dashboard
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=e26842cbe42bdeb6f10b22ab9c3be88bb4e3648d;p=civicrm-core.git

CRM-17663 - Fix race condition when loading OFC charts on dashboard
---

diff --git a/templates/CRM/Contribute/Form/ContributionCharts.tpl b/templates/CRM/Contribute/Form/ContributionCharts.tpl
index 9daf832bb9..c1d7e0c220 100644
--- a/templates/CRM/Contribute/Form/ContributionCharts.tpl
+++ b/templates/CRM/Contribute/Form/ContributionCharts.tpl
@@ -61,25 +61,15 @@
 <script type="text/javascript">
 
   CRM.$(function($) {
-      buildChart( );
+    var chartData = {/literal}{$openFlashChartData}{literal};
+    $.each(chartData, function(chartID, chartValues) {
+      createSWFObject(chartID, chartValues.divName, chartValues.size.xSize, chartValues.size.ySize, 'loadData');
+    });
   });
 
-  function buildChart( ) {
-     var chartData = {/literal}{$openFlashChartData}{literal};
-     cj.each( chartData, function( chartID, chartValues ) {
-
-   var xSize   = eval( "chartValues.size.xSize" );
-   var ySize   = eval( "chartValues.size.ySize" );
-   var divName = eval( "chartValues.divName" );
-
-   createSWFObject( chartID, divName, xSize, ySize, 'loadData' );
-     });
-  }
-
   function loadData( chartID ) {
      var allData = {/literal}{$openFlashChartData}{literal};
-     var data    = eval( "allData." + chartID + ".object" );
-     return JSON.stringify( data );
+     return JSON.stringify(allData[chartID].object);
   }
 
   function byMonthOnClick( barIndex ) {
diff --git a/templates/CRM/Report/Form/Layout/Graph.tpl b/templates/CRM/Report/Form/Layout/Graph.tpl
index 528a4da5f6..5d770b7857 100644
--- a/templates/CRM/Report/Form/Layout/Graph.tpl
+++ b/templates/CRM/Report/Form/Layout/Graph.tpl
@@ -57,24 +57,21 @@
        //fetch object and 'POST' image
        swfobject.getObjectById("open_flash_chart_{/literal}{$uniqueId}{literal}").post_image(url, true, false);
      });
-   });
 
-  function buildChart( ) {
-     var chartData = {/literal}{$openFlashChartData}{literal};
-     cj.each( chartData, function( chartID, chartValues ) {
-       var xSize   = eval( "chartValues.size.xSize" );
-       var ySize   = eval( "chartValues.size.ySize" );
-       var divName = {/literal}"open_flash_chart_{$uniqueId}"{literal};
+     function buildChart( ) {
+       var chartData = {/literal}{$openFlashChartData}{literal};
+       $.each( chartData, function( chartID, chartValues ) {
+         var divName = {/literal}"open_flash_chart_{$uniqueId}"{literal};
+         var loadDataFunction  = {/literal}"loadData{$uniqueId}"{literal};
 
-       var loadDataFunction  = {/literal}"loadData{$uniqueId}"{literal};
-       createSWFObject( chartID, divName, xSize, ySize, loadDataFunction );
-     });
-  }
+         createSWFObject( chartID, divName, chartValues.size.xSize, chartValues.size.ySize, loadDataFunction );
+       });
+     }
+   });
 
   function loadData{/literal}{$uniqueId}{literal}( chartID ) {
       var allData = {/literal}{$openFlashChartData}{literal};
-      var data    = eval( "allData." + chartID + ".object" );
-      return JSON.stringify( data );
+      return JSON.stringify(allData[chartID].object);
   }
 </script>
 {/literal}