From: colemanw <coleman@civicrm.org>
Date: Tue, 4 Jul 2023 17:57:31 +0000 (-0400)
Subject: SearchKit - Fix check for smarty syntax in rewrite output
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=de72ead1709ec7dc23515d42d65fdf2a15ae0c7e;p=civicrm-core.git

SearchKit - Fix check for smarty syntax in rewrite output

Fixes dev/core#4405
---

diff --git a/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php b/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php
index 5b099ab59e..f2f60e68c0 100644
--- a/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php
+++ b/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php
@@ -283,9 +283,10 @@ abstract class AbstractRunAction extends \Civi\Api4\Generic\AbstractAction {
    * @return string
    */
   private function rewrite(array $column, array $data): string {
-    $output = $this->replaceTokens($column['rewrite'], $data, 'view');
     // Cheap strpos to skip Smarty processing if not needed
-    if (strpos($output, '{') !== FALSE) {
+    $hasSmarty = strpos($column['rewrite'], '{') !== FALSE;
+    $output = $this->replaceTokens($column['rewrite'], $data, 'view');
+    if ($hasSmarty) {
       $smarty = \CRM_Core_Smarty::singleton();
       $output = $smarty->fetchWith("string:$output", []);
     }