From: Philip Hazel <ph10@hermes.cam.ac.uk>
Date: Thu, 25 Nov 2004 10:26:04 +0000 (+0000)
Subject: Expand error message when GnuTLS has problems setting up cert/key files.
X-Git-Tag: exim-4_50~86
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=de365dedeec38c30d7ff318eb6505d323e8a4411;p=exim.git

Expand error message when GnuTLS has problems setting up cert/key files.
---

diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index d223383ba..cd5fe9821 100644
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -1,4 +1,4 @@
-$Cambridge: exim/doc/doc-txt/ChangeLog,v 1.39 2004/11/24 16:14:50 ph10 Exp $
+$Cambridge: exim/doc/doc-txt/ChangeLog,v 1.40 2004/11/25 10:26:04 ph10 Exp $
 
 Change log file for Exim from version 4.21
 -------------------------------------------
@@ -172,6 +172,10 @@ Exim version 4.44
 40. When running the queue in the test harness, wait just a tad after forking a
     delivery process, to get repeatability of debugging output.
 
+41. Include certificate and key file names in error message when GnuTLS fails
+    to set them up, because the GnuTLS error message doesn't include the name
+    of the failing file when there is a problem reading it.
+
 
 Exim version 4.43
 -----------------
diff --git a/src/src/tls-gnu.c b/src/src/tls-gnu.c
index 14a11ed56..ade383e42 100644
--- a/src/src/tls-gnu.c
+++ b/src/src/tls-gnu.c
@@ -1,4 +1,4 @@
-/* $Cambridge: exim/src/src/tls-gnu.c,v 1.1 2004/10/07 10:39:01 ph10 Exp $ */
+/* $Cambridge: exim/src/src/tls-gnu.c,v 1.2 2004/11/25 10:26:04 ph10 Exp $ */
 
 /*************************************************
 *     Exim - an Internet mail transport agent    *
@@ -461,7 +461,12 @@ if (cert_expanded != NULL)
     cert_expanded, key_expanded);
   rc = gnutls_certificate_set_x509_key_file(x509_cred, CS cert_expanded,
     CS key_expanded, GNUTLS_X509_FMT_PEM);
-  if (rc < 0) return tls_error(US"cert/key setup", host, rc);
+  if (rc < 0) 
+    {
+    uschar *msg = string_sprintf("cert/key setup: cert=%s key=%s",
+      cert_expanded, key_expanded); 
+    return tls_error(msg, host, rc);
+    } 
   }
 
 /* A certificate is mandatory in a server, but not in a client */