From: eileen <emcnaughton@wikimedia.org>
Date: Tue, 4 Aug 2020 07:44:33 +0000 (+1200)
Subject: Improve error handling on IPN
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=ddf894d00ee749f0e13582fddbd5d28982ecbb08;p=civicrm-core.git

Improve error handling on IPN

https://civicrm.stackexchange.com/questions/37277/paypal-standard-payments-are-being-accepted-but-marked-as-incomplete-transaction/37279#37279

shows how unhelpful this error is - getting data from the exception should help.

Targetting 5.28 in case the gitlab relates to a regression & we need to solicit more debug info
---

diff --git a/CRM/Core/Payment.php b/CRM/Core/Payment.php
index 277c534611..9c998dc66d 100644
--- a/CRM/Core/Payment.php
+++ b/CRM/Core/Payment.php
@@ -1504,7 +1504,8 @@ abstract class CRM_Core_Payment {
     catch (CRM_Core_Exception $e) {
       Civi::log()->error('ipn_payment_callback_exception', [
         'context' => [
-          'backtrace' => CRM_Core_Error::formatBacktrace(debug_backtrace()),
+          'backtrace' => $e->getTraceAsString(),
+          'message' => $e->getMessage(),
         ],
       ]);
     }