From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Fri, 22 Sep 2023 07:57:17 +0000 (+1200)
Subject: Loosen action typing - doing nothing is doing something
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=d843486e47c59649189bb1ac68b41e7a2447f2c4;p=civicrm-core.git

Loosen action typing - doing nothing is doing something
---

diff --git a/CRM/Core/Form.php b/CRM/Core/Form.php
index 424c7cc6ee..d0f17d883d 100644
--- a/CRM/Core/Form.php
+++ b/CRM/Core/Form.php
@@ -1309,10 +1309,13 @@ class CRM_Core_Form extends HTML_QuickForm_Page {
   /**
    * Getter for action.
    *
-   * @return int
+   * @return int|null
    */
   public function getAction() {
     if (!is_numeric($this->_action)) {
+      if (!$this->_action) {
+        return NULL;
+      }
       CRM_Core_Error::deprecatedWarning('action should be an integer');
       return $this->_action;
     }