From: Jeremy Harris <jgh146exb@wizmail.org>
Date: Mon, 8 Aug 2016 20:07:55 +0000 (+0100)
Subject: DKIM: reduce memory usage (2nd go)
X-Git-Tag: exim-4_88_RC1~43
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=d5bccfc848adf0260c12fdc06bcf987769bfb350;p=exim.git

DKIM: reduce memory usage (2nd go)
---

diff --git a/src/src/pdkim/pdkim.c b/src/src/pdkim/pdkim.c
index 915b90e5c..bf2bbba6c 100644
--- a/src/src/pdkim/pdkim.c
+++ b/src/src/pdkim/pdkim.c
@@ -723,7 +723,12 @@ while (sig)
       const char *p;
       int q = 0;
 
-      relaxed_data = store_get(len+1);
+      /* We want to be able to free this else we allocate
+      for the entire message which could be many MB. Since
+      we don't know what allocations the SHA routines might
+      do, not safe to use store_get()/store_reset(). */
+
+      relaxed_data = malloc(len+1);
 
       for (p = data; *p; p++)
         {
@@ -767,6 +772,7 @@ while (sig)
   sig = sig->next;
   }
 
+if (relaxed_data) free(relaxed_data);
 return PDKIM_OK;
 }