From: pdontthink <pdontthink@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Date: Sat, 18 Nov 2017 22:41:40 +0000 (+0000)
Subject: Minor fix and clarify return types
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=d553520d10da5194ed85765b296fa05603ebb152;p=squirrelmail.git

Minor fix and clarify return types

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14734 7612ce4b-ef26-0410-bec9-ea0150e637f0
---

diff --git a/functions/imap_mailbox.php b/functions/imap_mailbox.php
index c520d93c..86f338d6 100755
--- a/functions/imap_mailbox.php
+++ b/functions/imap_mailbox.php
@@ -418,6 +418,7 @@ function sqimap_mailbox_exists ($imap_stream, $mailbox, $mailboxlist=null) {
  *                               is returned to the caller
  *                               (OPTIONAL; default is TRUE)
  * @return array results of select command (on success - permanentflags, flags and rights)
+ *               (on failure (and when $handle_errors is false), empty array)
  * @since 1.0 or older
  */
 function sqimap_mailbox_select ($imap_stream, $mailbox, $handle_errors=true) {
@@ -463,7 +464,7 @@ function sqimap_mailbox_select ($imap_stream, $mailbox, $handle_errors=true) {
             }
         }
     }
-    if (!isset($result['PERMANENTFLAGS'])) {
+    if (!empty($result) && !isset($result['PERMANENTFLAGS'])) {
         $result['PERMANENTFLAGS'] = $result['FLAGS'];
     }
     if (preg_match('/^\[(.+)\]/',$message, $regs)) {