From: Pradeep Nayak <pradpnayak@gmail.com>
Date: Wed, 22 May 2019 23:52:47 +0000 (+0100)
Subject: dev/financial/issues/56, Fixed Financial item entries
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=d24d6560d1d82906c9ad4918652811ac4688e791;p=civicrm-core.git

dev/financial/issues/56, Fixed Financial item entries
---

diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php
index 6b7ae24cf4..a057a9674b 100644
--- a/CRM/Contribute/BAO/Contribution.php
+++ b/CRM/Contribute/BAO/Contribution.php
@@ -3788,15 +3788,17 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac
             elseif ($previousLineItemTotal != $lineItemDetails['line_total']) {
               $taxAmount -= CRM_Utils_Array::value('tax_amount', CRM_Utils_Array::value($fieldValueId, $previousLineItems), 0);
             }
-            $itemParams['amount'] = self::getMultiplier($params['contribution']->contribution_status_id, $context) * $taxAmount;
-            $itemParams['description'] = $taxTerm;
-            if ($lineItemDetails['financial_type_id']) {
-              $itemParams['financial_account_id'] = CRM_Contribute_PseudoConstant::getRelationalFinancialAccount(
-                $lineItemDetails['financial_type_id'],
-                'Sales Tax Account is'
-              );
+            if ($taxAmount != 0) {
+              $itemParams['amount'] = self::getMultiplier($params['contribution']->contribution_status_id, $context) * $taxAmount;
+              $itemParams['description'] = $taxTerm;
+              if ($lineItemDetails['financial_type_id']) {
+                $itemParams['financial_account_id'] = CRM_Contribute_PseudoConstant::getRelationalFinancialAccount(
+                  $lineItemDetails['financial_type_id'],
+                  'Sales Tax Account is'
+                );
+              }
+              CRM_Financial_BAO_FinancialItem::create($itemParams, NULL, $trxnIds);
             }
-            CRM_Financial_BAO_FinancialItem::create($itemParams, NULL, $trxnIds);
           }
         }
       }