From: Noah Miller <nm@lemnisc.us>
Date: Sat, 14 Oct 2023 20:51:43 +0000 (-0400)
Subject: the experiment that @colemanw suggested: reject non-array $list param
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=d15b68ea48cfb1b5924df8942f586b30bb6056e3;p=civicrm-core.git

the experiment that @colemanw suggested: reject non-array $list param
---

diff --git a/CRM/Utils/Array.php b/CRM/Utils/Array.php
index b96b4bbc63..3045fb38fe 100644
--- a/CRM/Utils/Array.php
+++ b/CRM/Utils/Array.php
@@ -70,8 +70,8 @@ class CRM_Utils_Array {
     if ($list instanceof ArrayAccess) {
       return $list->offsetExists($key) ? $list[$key] : $default;
     }
-    // @todo - eliminate these from core & uncomment this line.
-    // CRM_Core_Error::deprecatedFunctionWarning('You have passed an invalid parameter for the "list"');
+    // @todo - eliminate invalid usages from core & uncomment this line.
+    CRM_Core_Error::deprecatedFunctionWarning('an array/ArrayAccess for the "list" parameter');
     return $default;
   }