From: Jeremy Harris <jgh146exb@wizmail.org>
Date: Thu, 22 Feb 2018 14:26:57 +0000 (+0000)
Subject: WIP
X-Git-Tag: exim-4_91_RC1~38
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=cfa8f329e9fddbb6db594761364854e780359ace;p=exim.git

WIP
---

diff --git a/src/src/dkim.c b/src/src/dkim.c
index ec5ba494b..092eb55c6 100644
--- a/src/src/dkim.c
+++ b/src/src/dkim.c
@@ -710,9 +710,6 @@ while ((dkim_signing_domain = string_nextinlist(&dkim_domain, &sep, NULL, 0)))
       else if (!*dkim_identity_expanded)
 	dkim_identity_expanded = NULL;
 
-  /*XXX so we currently nail signing to RSA + this hash.
-  Need to extract algo from privkey and check for disallowed combos. */
-
     if (!(sig = pdkim_init_sign(&ctx, dkim_signing_domain,
 			  dkim_signing_selector,
 			  dkim_private_key_expanded,
diff --git a/src/src/tls-openssl.c b/src/src/tls-openssl.c
index fd21adfa5..4dfeac06d 100644
--- a/src/src/tls-openssl.c
+++ b/src/src/tls-openssl.c
@@ -1819,7 +1819,6 @@ if (expcerts && *expcerts)
 	{ file = NULL; dir = expcerts; }
       else
 	{
-	/*XXX somewhere down here we leak memory per-STARTTLS, on a multi-message conn, server-side */
 	file = expcerts; dir = NULL;
 #ifndef DISABLE_OCSP
 	/* In the server if we will be offering an OCSP proof, load chain from