From: Coleman Watts <coleman@civicrm.org>
Date: Fri, 23 Oct 2015 19:03:15 +0000 (-0400)
Subject: CRM-13823 - Show icons in Angular tabs
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=cf50008770e78ff2e8a1b21c96d25f7a12b21d64;p=civicrm-core.git

CRM-13823 - Show icons in Angular tabs
---

diff --git a/ang/crmStatusPage/StatusPage.html b/ang/crmStatusPage/StatusPage.html
index fa49b3a080..efbe3c98d1 100644
--- a/ang/crmStatusPage/StatusPage.html
+++ b/ang/crmStatusPage/StatusPage.html
@@ -9,11 +9,12 @@
 
     <div crm-ui-tab-set>
       <div
-        ng-repeat="tab in [{is_visible: 1, name: 'visible'}, {is_visible: 0, name: 'hidden'}]"
+        ng-repeat="tab in [{is_visible: 1, name: 'visible', icon: 'fa-bell'}, {is_visible: 0, name: 'hidden', icon: 'fa-bell-slash-o'}]"
         crm-ui-tab
         id="tab-{{tab.name}}"
         count="{{_.where(statuses, {is_visible: tab.is_visible}).length}}"
         crm-title="tab.is_visible ? ts('Active') : ts('Hushed/Snoozed')"
+        crm-icon="{{tab.icon}}"
         >
         <div id="crm-status-list" ng-repeat="status in statuses | filter:{is_visible: tab.is_visible}" >
           <h3 class="crm-severity-{{status.severity}}">
diff --git a/ang/crmUi.js b/ang/crmUi.js
index 63ad95f2c8..b01e897d3f 100644
--- a/ang/crmUi.js
+++ b/ang/crmUi.js
@@ -661,6 +661,7 @@
         restrict: 'EA',
         scope: {
           crmTitle: '@',
+          crmIcon: '@',
           count: '@',
           id: '@'
         },
@@ -845,8 +846,11 @@
     .directive('crmIcon', function() {
       return {
         restrict: 'EA',
-        scope: {},
         link: function (scope, element, attrs) {
+          if (element.is('[crm-ui-tab]')) {
+            // handled in crmUiTab ctrl
+            return;
+          }
           if (attrs.crmIcon.substring(0,3) == 'fa-') {
             $(element).prepend('<i class="crm-i ' + attrs.crmIcon + '"></i> ');
           }
diff --git a/ang/crmUi/tabset.html b/ang/crmUi/tabset.html
index f232937945..fafb1dfdac 100644
--- a/ang/crmUi/tabset.html
+++ b/ang/crmUi/tabset.html
@@ -2,6 +2,7 @@
   <ul>
     <li ng-repeat="tab in tabs" class="ui-corner-all crm-tab-button crm-count-{{tab.count}}">
       <a href="#{{tab.id}}">
+        <i ng-if="tab.crmIcon" class="crm-i {{tab.crmIcon}}"></i>
         {{tab.$parent.$eval(tab.crmTitle)}}
         <em ng-if="tab.count">{{tab.count}}</em>
       </a>