From: Matthew Wire <devel@mrwire.co.uk>
Date: Tue, 29 May 2018 18:45:27 +0000 (+0100)
Subject: Fix saving option value with value=0
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=ce7ccb1e4a992aa3e6275da1b1c99fba710082cd;p=civicrm-core.git

Fix saving option value with value=0
---

diff --git a/CRM/Admin/Form/Options.php b/CRM/Admin/Form/Options.php
index ce018dd517..f68718d881 100644
--- a/CRM/Admin/Form/Options.php
+++ b/CRM/Admin/Form/Options.php
@@ -407,7 +407,7 @@ class CRM_Admin_Form_Options extends CRM_Admin_Form {
     $dataType = self::getOptionGroupDataType($self->_gName);
     if ($dataType && $self->_gName !== 'activity_type') {
       $validate = CRM_Utils_Type::validate($fields['value'], $dataType, FALSE);
-      if (!$validate) {
+      if ($validate === FALSE) {
         CRM_Core_Session::setStatus(
           ts('Data Type of the value field for this option value does not match ' . $dataType),
           ts('Value field Data Type mismatch'));
diff --git a/CRM/Core/OptionValue.php b/CRM/Core/OptionValue.php
index 4a9885f9c9..27a1a756f0 100644
--- a/CRM/Core/OptionValue.php
+++ b/CRM/Core/OptionValue.php
@@ -224,7 +224,7 @@ class CRM_Core_OptionValue {
     }
     $params['option_group_id'] = $optionGroupID;
 
-    if (($action & CRM_Core_Action::ADD) && empty($params['value'])) {
+    if (($action & CRM_Core_Action::ADD) && !isset($params['value'])) {
       $fieldValues = array('option_group_id' => $optionGroupID);
       // use the next available value
       /* CONVERT(value, DECIMAL) is used to convert varchar