From: Boris Bobrov <breton@cynicmansion.ru>
Date: Sun, 7 Aug 2016 23:26:25 +0000 (+0300)
Subject: Do not try to get private attributes for comments
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=cacc679a24847c9ec24475445068969c4a98b6e3;p=mediagoblin.git

Do not try to get private attributes for comments

Most probably, they are sqlalchemy's!
---

diff --git a/mediagoblin/db/models.py b/mediagoblin/db/models.py
index 6448de36..0a20278f 100644
--- a/mediagoblin/db/models.py
+++ b/mediagoblin/db/models.py
@@ -998,10 +998,17 @@ class Comment(Base):
         return self.comment().get_actor  # noqa
 
     def __getattr__(self, attr):
+        if attr.startswith('_'):
+            # if attr starts with '_', then it's probably some internal
+            # sqlalchemy variable. Since __getattr__ is called when
+            # non-existing attributes are being accessed, we should not try to
+            # fetch it from self.comment()
+            raise AttributeError
         try:
+            _log.debug('Old attr is being accessed: {0}'.format(attr))
             return getattr(self.comment(), attr)  # noqa
         except Exception as e:
-            print(e)
+            _log.error(e)
             raise
 
 class TextComment(Base, TextCommentMixin, CommentingMixin):