From: Matthew Wire (MJW Consulting) <mjw@mjwconsult.co.uk>
Date: Thu, 19 Sep 2019 23:36:06 +0000 (+0100)
Subject: Fix membership/issues#16 Duplicate lineitems when creating a recurring membership... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=c80e66524cfdc5ac7508fbb6007eb2a83adb13f2;p=civicrm-core.git

Fix membership/issues#16 Duplicate lineitems when creating a recurring membership via backend
---

diff --git a/CRM/Member/BAO/Membership.php b/CRM/Member/BAO/Membership.php
index 2e22a1d836..bbd24740df 100644
--- a/CRM/Member/BAO/Membership.php
+++ b/CRM/Member/BAO/Membership.php
@@ -376,7 +376,7 @@ class CRM_Member_BAO_Membership extends CRM_Member_DAO_Membership {
 
     // This could happen if there is no contribution or we are in one of many
     // weird and wonderful flows. This is scary code. Keep adding tests.
-    if (!empty($params['line_item']) && empty($ids['contribution'])) {
+    if (!empty($params['line_item']) && empty($ids['contribution']) && empty($params['contribution_id'])) {
 
       foreach ($params['line_item'] as $priceSetId => $lineItems) {
         foreach ($lineItems as $lineIndex => $lineItem) {