From: yashodha <yashodha@cividesk.com>
Date: Fri, 25 Aug 2023 12:14:30 +0000 (+0530)
Subject: (dev/core#4536) Fix 'Primary Membership' filter options in Membership Details report
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=c1057a3080c332bbded6b83509c9e7cdb7099093;p=civicrm-core.git

(dev/core#4536) Fix 'Primary Membership' filter options in Membership Details report
---

diff --git a/CRM/Report/Form/Member/Detail.php b/CRM/Report/Form/Member/Detail.php
index 9cc87fc1e7..8b90e2df00 100644
--- a/CRM/Report/Form/Member/Detail.php
+++ b/CRM/Report/Form/Member/Detail.php
@@ -379,18 +379,13 @@ HERESQL;
     }
   }
 
-  public function getOperationPair($type = "string", $fieldName = NULL) {
+  public function getOperationPair($type = 'string', $fieldName = NULL) {
     //re-name IS NULL/IS NOT NULL for clarity
     if ($fieldName === 'owner_membership_id') {
       $result = [];
+      $result[''] = ts('Any');
       $result['nll'] = ts('Primary members only');
       $result['nnll'] = ts('Non-primary members only');
-      $options = parent::getOperationPair($type, $fieldName);
-      foreach ($options as $key => $label) {
-        if (!array_key_exists($key, $result)) {
-          $result[$key] = $label;
-        }
-      }
     }
     else {
       $result = parent::getOperationPair($type, $fieldName);