From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Fri, 15 Apr 2022 22:26:28 +0000 (+1200)
Subject: Fix malformed query when user with no access to any financial acls accesses civimembe... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=bf9f77d3aef30333f985874e70a143473ff82cbf;p=civicrm-core.git

Fix malformed query when user with no access to any financial acls accesses civimember search
---

diff --git a/ext/financialacls/financialacls.php b/ext/financialacls/financialacls.php
index 4870bf4a97..45366d57ba 100644
--- a/ext/financialacls/financialacls.php
+++ b/ext/financialacls/financialacls.php
@@ -224,12 +224,9 @@ function _financialacls_civicrm_get_accessible_financial_types(): array {
  * @throws \API_Exception
  */
 function _financialacls_civicrm_get_membership_type_clause(): string {
-  if (!CRM_Core_Component::isEnabled('CiviMember')) {
-    return 1;
-  }
   $financialTypes = _financialacls_civicrm_get_accessible_financial_types();
-  if ($financialTypes === [0]) {
-    return 0;
+  if ($financialTypes === [0] || !CRM_Core_Component::isEnabled('CiviMember')) {
+    return '= 0';
   }
   $membershipTypes = (array) MembershipType::get(FALSE)
     ->addWhere('financial_type_id', 'IN', $financialTypes)->execute()->indexBy('id');