From: Conor Broderick <conor.broderick@robustperception.io>
Date: Tue, 4 Jul 2017 11:53:41 +0000 (+0100)
Subject: Ensure duration of lookup is set if ip resolution fails (#180)
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=be2a179dbd4ce339ac6effe2a98b2e2f1363bde8;p=blackbox_exporter.git

Ensure duration of lookup is set if ip resolution fails (#180)
---

diff --git a/utils.go b/utils.go
index c885c7f..1828a4f 100644
--- a/utils.go
+++ b/utils.go
@@ -39,6 +39,8 @@ func chooseProtocol(preferredIPProtocol string, target string, registry *prometh
 
 	resolveStart := time.Now()
 
+	defer probeDNSLookupTimeSeconds.Add(time.Since(resolveStart).Seconds())
+
 	ip, err := net.ResolveIPAddr(preferredIPProtocol, target)
 	if err != nil {
 		ip, err = net.ResolveIPAddr(fallbackProtocol, target)
@@ -47,8 +49,6 @@ func chooseProtocol(preferredIPProtocol string, target string, registry *prometh
 		}
 	}
 
-	probeDNSLookupTimeSeconds.Add(time.Since(resolveStart).Seconds())
-
 	if ip.IP.To4() == nil {
 		probeIPProtocolGauge.Set(6)
 	} else {