From: pdontthink <pdontthink@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Date: Sun, 17 Aug 2008 03:49:37 +0000 (+0000)
Subject: Fix subsequent PHP notices caused by last commit.  Also note that incorrect server... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=b8f35815398742ceb5cb6f38c18d52448f80aa9c;p=squirrelmail.git

Fix subsequent PHP notices caused by last commit.  Also note that incorrect server responses shouild be error-checked, but they are not, probably because that's indicative of more fundamental problems elsewhere.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13265 7612ce4b-ef26-0410-bec9-ea0150e637f0
---

diff --git a/functions/auth.php b/functions/auth.php
index 53fe9fd3..49b953ff 100644
--- a/functions/auth.php
+++ b/functions/auth.php
@@ -138,6 +138,7 @@ function cram_md5_response ($username,$password,$challenge) {
  */
 function digest_md5_response ($username,$password,$challenge,$service,$host,$authz='') {
     $result=digest_md5_parse_challenge($challenge);
+    //FIXME we should check that $result contains the expected values that we use below
 
     // verify server supports qop=auth
     // $qop = explode(",",$result['qop']);
@@ -199,7 +200,8 @@ function digest_md5_response ($username,$password,$challenge,$service,$host,$aut
  */
 function digest_md5_parse_challenge($challenge) {
     $challenge=base64_decode($challenge);
-    while (isset($challenge) && $challenge !== FALSE) {
+    $parsed = array();
+    while (!empty($challenge)) {
         if ($challenge{0} == ',') { // First char is a comma, must not be 1st time through loop
             $challenge=substr($challenge,1);
         }