From: Seamus Lee <seamuslee001@gmail.com>
Date: Tue, 19 May 2020 01:56:27 +0000 (+1000)
Subject: Ensure that all contribution pages including disabled ones are returned when viewing... 
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=b54147846552f24a62aa94895c27598fbdc4b728;p=civicrm-core.git

Ensure that all contribution pages including disabled ones are returned when viewing the contribution detailed report
---

diff --git a/CRM/Report/Form/Contribute/Detail.php b/CRM/Report/Form/Contribute/Detail.php
index 9d4c12d22a..73c1369b3a 100644
--- a/CRM/Report/Form/Contribute/Detail.php
+++ b/CRM/Report/Form/Contribute/Detail.php
@@ -640,7 +640,8 @@ UNION ALL
     $contributionTypes = CRM_Contribute_PseudoConstant::financialType();
     $contributionStatus = CRM_Contribute_PseudoConstant::contributionStatus(NULL, 'label');
     $paymentInstruments = CRM_Contribute_PseudoConstant::paymentInstrument();
-    $contributionPages = CRM_Contribute_PseudoConstant::contributionPage();
+    // We pass in TRUE as 2nd param so that even disabled contribution page titles are returned and replaced in the report
+    $contributionPages = CRM_Contribute_PseudoConstant::contributionPage(NULL, TRUE);
     $batches = CRM_Batch_BAO_Batch::getBatches();
     foreach ($rows as $rowNum => $row) {
       if (!empty($this->_noRepeats) && $this->_outputMode != 'csv') {