From: Elrond <elrond+mediagoblin.org@samba-tng.org>
Date: Thu, 14 Jun 2012 19:57:24 +0000 (+0200)
Subject: First migration fix: commit after each migration.
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=b105540141ce3557456059b0e5dd5e589063e2f3;p=mediagoblin.git

First migration fix: commit after each migration.

sqlite doesn't like complex changes (alter table) to happen
inside a transaction that has already done other things.
And really, each migration should say "I'm done" and commit
its changes.

This is not the full story, but it's the core of it.

Specifially the migration framework should probably do a
rollback "just in case" after each migration.
---

diff --git a/mediagoblin/db/sql/migrations.py b/mediagoblin/db/sql/migrations.py
index 453801a5..d6b709b2 100644
--- a/mediagoblin/db/sql/migrations.py
+++ b/mediagoblin/db/sql/migrations.py
@@ -33,6 +33,7 @@ def ogg_to_webm_audio(db_conn):
         file_keynames.update().where(file_keynames.c.name == 'ogg').
             values(name='webm_audio')
     )
+    db_conn.commit()
 
 
 @RegisterMigration(2, MIGRATIONS)
@@ -45,3 +46,4 @@ def add_wants_notification_column(db_conn):
     col = Column('wants_comment_notification', Boolean,
             default=True, nullable=True)
     col.create(users, populate_defaults=True)
+    db_conn.commit()