From: eileen <emcnaughton@wikimedia.org>
Date: Wed, 26 Aug 2020 22:05:04 +0000 (+1200)
Subject: Use already detemined value for contributionRecurid
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=ac6b9668d8bcb60e58896d33960fc0876f017629;p=civicrm-core.git

Use already detemined value for contributionRecurid
---

diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php
index d69c94fbac..0e8ba3d61c 100644
--- a/CRM/Contribute/BAO/Contribution.php
+++ b/CRM/Contribute/BAO/Contribution.php
@@ -4545,8 +4545,8 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac
     }
 
     // Add new soft credit against current $contribution.
-    if (!empty($objects['contributionRecur']) && $objects['contributionRecur']->id) {
-      CRM_Contribute_BAO_ContributionRecur::addrecurSoftCredit($objects['contributionRecur']->id, $contribution->id);
+    if ($recurringContributionID) {
+      CRM_Contribute_BAO_ContributionRecur::addrecurSoftCredit($recurringContributionID, $contribution->id);
     }
 
     $contribution->contribution_status_id = $contributionParams['contribution_status_id'];