From: ayleph <ayleph@thisshitistemp.com>
Date: Sun, 3 Aug 2014 22:55:16 +0000 (-0700)
Subject: Pass validated username to check_login_simple
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=a2b3c623fd53824ff84d9ac737636d30d0f52999;p=mediagoblin.git

Pass validated username to check_login_simple

The login function in mediagoblin/auth/views.py grabs the username prior to
form validation. If validation passes, the pre-validated username is passed to
the check_login_simple function.

Lowercasifying of the username occurs as part of form validation. By sending
the pre-validated username, there's a chance of sending a username with
uppercase letters. This will fail to match any user ids in the database, as
all of the usernames are lowercased during the registration process.

This change sends the post-validated username to check_login_simple, so that
any username that was entered by the user with uppercase letters has a chance
to be properly lowercased before being passed.
---

diff --git a/mediagoblin/auth/views.py b/mediagoblin/auth/views.py
index a90db0ea..03a46f7b 100644
--- a/mediagoblin/auth/views.py
+++ b/mediagoblin/auth/views.py
@@ -86,10 +86,11 @@ def login(request):
     login_failed = False
 
     if request.method == 'POST':
-        username = login_form.username.data
 
         if login_form.validate():
-            user = check_login_simple(username, login_form.password.data)
+            user = check_login_simple(
+                login_form.username.data,
+                login_form.password.data)
 
             if user:
                 # set up login in session