From: Coleman Watts <coleman@civicrm.org>
Date: Fri, 15 Jan 2016 18:38:06 +0000 (-0500)
Subject: CRM-16353 - Warn not to copy-paste legacy code
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=9d311c8f28303fe1869e621794c5de3412dc61f7;p=civicrm-core.git

CRM-16353 - Warn not to copy-paste legacy code
---

diff --git a/CRM/Batch/Page/AJAX.php b/CRM/Batch/Page/AJAX.php
index 3bf89bfa10..5355ce5874 100644
--- a/CRM/Batch/Page/AJAX.php
+++ b/CRM/Batch/Page/AJAX.php
@@ -50,7 +50,8 @@ class CRM_Batch_Page_AJAX {
   }
 
   /**
-   * Retrieve records.
+   * This function uses the deprecated v1 datatable api and needs updating. See CRM-16353.
+   * @deprecated
    */
   public static function getBatchList() {
     $sortMapper = array(
diff --git a/CRM/Campaign/Page/AJAX.php b/CRM/Campaign/Page/AJAX.php
index d04d2b1ed4..8674ffcf61 100644
--- a/CRM/Campaign/Page/AJAX.php
+++ b/CRM/Campaign/Page/AJAX.php
@@ -565,8 +565,8 @@ class CRM_Campaign_Page_AJAX {
   }
 
   /**
-   * Retrieve campaigns as for campaign dashboard.
-   *
+   * This function uses the deprecated v1 datatable api and needs updating. See CRM-16353.
+   * @deprecated
    */
   public function campaignList() {
     //get the search criteria params.
@@ -668,8 +668,8 @@ class CRM_Campaign_Page_AJAX {
   }
 
   /**
-   * Retrieve survey for survey dashboard.
-   *
+   * This function uses the deprecated v1 datatable api and needs updating. See CRM-16353.
+   * @deprecated
    */
   public function surveyList() {
     //get the search criteria params.
@@ -773,8 +773,8 @@ class CRM_Campaign_Page_AJAX {
   }
 
   /**
-   * Retrieve petitions for petition dashboard.
-   *
+   * This function uses the deprecated v1 datatable api and needs updating. See CRM-16353.
+   * @deprecated
    */
   public function petitionList() {
     //get the search criteria params.
diff --git a/CRM/Custom/Page/AJAX.php b/CRM/Custom/Page/AJAX.php
index 4885b1f17d..bdf0ec3d50 100644
--- a/CRM/Custom/Page/AJAX.php
+++ b/CRM/Custom/Page/AJAX.php
@@ -36,9 +36,10 @@
  * This class contains the functions that are called using AJAX (jQuery)
  */
 class CRM_Custom_Page_AJAX {
+
   /**
-   * Get list of options.
-   *
+   * This function uses the deprecated v1 datatable api and needs updating. See CRM-16353.
+   * @deprecated
    */
   public static function getOptionList() {
     $params = $_REQUEST;
diff --git a/CRM/Financial/Page/AJAX.php b/CRM/Financial/Page/AJAX.php
index 771fc0978c..51468b9559 100644
--- a/CRM/Financial/Page/AJAX.php
+++ b/CRM/Financial/Page/AJAX.php
@@ -260,9 +260,10 @@ class CRM_Financial_Page_AJAX {
   }
 
   /**
-   * Get output of financial transactions.
+   * This function uses the deprecated v1 datatable api and needs updating. See CRM-16353.
+   * @deprecated
    *
-   * @return string
+   * @return string|wtf??
    */
   public static function getFinancialTransactionsList() {
     $sortMapper = array(