From: Jeremy Harris <jgh146exb@wizmail.org>
Date: Tue, 21 Aug 2018 21:31:27 +0000 (+0100)
Subject: tidying
X-Git-Tag: exim-4.92-RC1~129
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=9d2ec425bdb740442417593116a136577e7ddb15;p=exim.git

tidying
---

diff --git a/src/src/ip.c b/src/src/ip.c
index 82876c62e..d9184efbf 100644
--- a/src/src/ip.c
+++ b/src/src/ip.c
@@ -250,7 +250,11 @@ if (timeout > 0) alarm(timeout);
 this peer, can send data in the SYN packet.  The peer can send data
 before it gets our ACK of its SYN,ACK - the latter is useful for
 the SMTP banner.  Other (than SMTP) cases of TCP connections can
-possibly use the data-on-syn, so support that too.  */
+possibly use the data-on-syn, so support that too.
+
+This is a Linux implementation.  It might be useable on FreeBSD; I have
+not checked.  I think MacOS has a "connectx" call for this purpose,
+rather than using "sendto" ? */
 
 if (fastopen_blob && tcp_fastopen_ok)
   {
diff --git a/src/src/smtp_in.c b/src/src/smtp_in.c
index daaab9172..e59dece25 100644
--- a/src/src/smtp_in.c
+++ b/src/src/smtp_in.c
@@ -4717,9 +4717,6 @@ while (done <= 0)
 #if defined(SUPPORT_TLS) && defined(EXPERIMENTAL_REQUIRETLS)
 	  case ENV_MAIL_OPT_REQTLS:
 	    {
-	    const uschar * list = value;
-	    int sep = ',';
-	    const uschar * opt;
 	    uschar * r, * t;
 
 	    if (!requiretls_advertised)