From: Sam Saffron <sam.saffron@gmail.com>
Date: Thu, 16 Jan 2014 00:48:20 +0000 (-0800)
Subject: eval is evil, unconditionally evil, can not allow it, searching for another solution
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=92d6e15a76e689e62662b821ee8eba111b83d768;p=discourse_docker.git

eval is evil, unconditionally evil, can not allow it, searching for another solution
---

diff --git a/launcher b/launcher
index c43f41c..d35ab09 100755
--- a/launcher
+++ b/launcher
@@ -135,7 +135,7 @@ case "$command" in
       fi
       run_command="$run_command /pups/bin/pups --stdin"
 
-      (exec echo "$input" | eval docker run $env -e DOCKER_HOST_IP=$docker_ip -cidfile $cidbootstrap -i -a stdin -a stdout -a stderr $volumes $image \
+      (exec echo "$input" | docker run $env -e DOCKER_HOST_IP=$docker_ip -cidfile $cidbootstrap -i -a stdin -a stdout -a stderr $volumes $image \
          /bin/bash -c "$run_command") \
          || (docker rm `cat $cidbootstrap` && rm $cidbootstrap)
 
@@ -205,7 +205,7 @@ case "$command" in
              exit 1
            fi
 
-           eval docker run $env -e DOCKER_HOST_IP=$docker_ip -name $config -cidfile $cidfile $ports \
+           docker run $env -e DOCKER_HOST_IP=$docker_ip -name $config -cidfile $cidfile $ports \
                       -d $volumes $local_discourse/$config /usr/bin/runsvdir -P /etc/service
 
            exit 0