From: Sebastian Spaeth Date: Fri, 16 Nov 2012 12:18:37 +0000 (+0100) Subject: No need to strip the tag 4 times X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=9061383de260ec3ed2c551793d91ee672d9989e6;p=mediagoblin.git No need to strip the tag 4 times spaetz' rule: Don't do sth 4 times when once suffices. Signed-off-by: Sebastian Spaeth --- diff --git a/mediagoblin/tools/text.py b/mediagoblin/tools/text.py index 24a4d282..96df49d2 100644 --- a/mediagoblin/tools/text.py +++ b/mediagoblin/tools/text.py @@ -68,12 +68,11 @@ def convert_to_tag_list_of_dicts(tag_string): # Split the tag string into a list of tags for tag in stripped_tag_string.split(','): - + tag = tag.strip() # Ignore empty or duplicate tags - if tag.strip() and tag.strip() not in [t['name'] for t in taglist]: - - taglist.append({'name': tag.strip(), - 'slug': url.slugify(tag.strip())}) + if tag and tag not in [t['name'] for t in taglist]: + taglist.append({'name': tag, + 'slug': url.slugify(tag)}) return taglist