From: colemanw <coleman@civicrm.org>
Date: Tue, 2 Jan 2024 15:08:53 +0000 (-0500)
Subject: Fix e-notice on contact create for low-permissioned user
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=902fd88c3c78832e3d944aef08d3b075a83e84d2;p=civicrm-core.git

Fix e-notice on contact create for low-permissioned user

This cleans up some very messy code which was emitting e-notices when the 'group' key was missing.
This can happen when the current user does not have permissions to add contacts to groups.
---

diff --git a/CRM/Contact/Form/Contact.php b/CRM/Contact/Form/Contact.php
index 1691362928..d9059f9391 100644
--- a/CRM/Contact/Form/Contact.php
+++ b/CRM/Contact/Form/Contact.php
@@ -987,14 +987,9 @@ class CRM_Contact_Form_Contact extends CRM_Core_Form {
       $params['preferred_communication_method'] = 'null';
     }
 
-    $group = $params['group'] ?? NULL;
-    $params['group'] = ($params['group'] == '') ? [] : $params['group'];
-    if (!empty($group)) {
-      $group = is_array($group) ? $group : explode(',', $group);
-      $params['group'] = [];
-      foreach ($group as $key => $value) {
-        $params['group'][$value] = 1;
-      }
+    if (array_key_exists('group', $params)) {
+      $group = is_array($params['group']) ? $params['group'] : explode(',', $params['group']);
+      $params['group'] = array_fill_keys($group, 1);
     }
 
     if (!empty($params['image_URL'])) {