From: Harmon <Harmon758@gmail.com>
Date: Sun, 14 Feb 2021 11:43:15 +0000 (-0600)
Subject: Stop allowing positional arguments for API.add_list_members
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=8eb900f12e62a21dad9314d0caf9035471baf840;p=tweepy.git

Stop allowing positional arguments for API.add_list_members

Also improve endpoint parameters order to match Twitter API documentation
---

diff --git a/tweepy/api.py b/tweepy/api.py
index fd2fedd..901dc2e 100644
--- a/tweepy/api.py
+++ b/tweepy/api.py
@@ -1012,17 +1012,17 @@ class API:
         )
 
     @payload('list')
-    def add_list_members(self, screen_name=None, user_id=None, slug=None,
-                         list_id=None, owner_id=None, owner_screen_name=None,
-                         **kwargs):
+    def add_list_members(self, **kwargs):
         """ :reference: https://developer.twitter.com/en/docs/accounts-and-users/create-manage-lists/api-reference/post-lists-members-create_all
         """
+        if 'user_id' in kwargs:
+            kwargs['user_id'] = list_to_csv(kwargs['user_id'])
+        if 'screen_name' in kwargs:
+            kwargs['screen_name'] = list_to_csv(kwargs['screen_name'])
         return self.request(
-            'POST', 'lists/members/create_all', list_to_csv(screen_name),
-            list_to_csv(user_id), slug, list_id, owner_id, owner_screen_name,
-            endpoint_parameters=(
-                'screen_name', 'user_id', 'slug', 'list_id', 'owner_id',
-                'owner_screen_name'
+            'POST', 'lists/members/create_all', endpoint_parameters=(
+                'list_id', 'slug', 'user_id', 'screen_name',
+                'owner_screen_name', 'owner_id'
             ), **kwargs
         )