From: Joe Murray <joe.murray@jmaconsulting.biz>
Date: Mon, 18 Nov 2013 22:05:22 +0000 (-0500)
Subject: CRM-13793 assignment has no effect error cleanup
X-Git-Url: https://vcs.fsf.org/?a=commitdiff_plain;h=8ce923d149a58990361be8b0f7f999c9ee71cce9;p=civicrm-core.git

CRM-13793 assignment has no effect error cleanup
---

diff --git a/CRM/Core/BAO/Navigation.php b/CRM/Core/BAO/Navigation.php
index 037acf0334..3ba44506d0 100644
--- a/CRM/Core/BAO/Navigation.php
+++ b/CRM/Core/BAO/Navigation.php
@@ -488,10 +488,7 @@ ORDER BY parent_id, weight";
 
     $makeLink = FALSE;
     if (isset($url) && $url) {
-      if (substr($url, 0, 4) === 'http') {
-        $url = $url;
-      }
-      else {
+      if (substr($url, 0, 4) !== 'http') {
         //CRM-7656 --make sure to separate out url path from url params,
         //as we'r going to validate url path across cross-site scripting.
         $urlParam = CRM_Utils_System::explode('&', str_replace('?', '&', $url), 2);